[jira] [Resolved] (HBASE-17393) Logic in TimeRange#includesTimeRange is incorrect

["huaxiang sun (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-17393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

huaxiang sun resolved HBASE-17393.
----------------------------------
    Resolution: Invalid

The definition of TimeRange is different from the client side and the server side. At the client side, it is [start, end), at the server side, it is [start, end]. Comments have been added at the server side.

> Logic in TimeRange#includesTimeRange is incorrect
> -------------------------------------------------
>
>                 Key: HBASE-17393
>                 URL: https://issues.apache.org/jira/browse/HBASE-17393
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>            Priority: Minor
>
> In the code,
> https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java#L181
>  
> return getMin() < tr.getMax() && getMax() >= tr.getMin();
> Given that TimeRange is defined as [minStamp,maxStamp), 
> Assume that TimeRange(4, 5). includesTimeRange(TimeRange(5,6)).
> So it will be (4 < 6) && (5 >=5), the result is true.
> Same for TimeRangeTracker#includesTimeRange



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)