You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@celeborn.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/06/11 13:19:48 UTC

[GitHub] [incubator-celeborn] pan3793 commented on pull request #1406: [CELEBORN-494][PERF] RssInputStream fetch side support blacklist to avoid client side timeout in same worker multiple times during fetch

pan3793 commented on PR #1406:
URL: https://github.com/apache/incubator-celeborn/pull/1406#issuecomment-1586165686

   It seems like we are mixing up the terms "excludedWorker" and "blacklist". 
   
   First of all, I don't object "blacklist", but we should unify them.
   
   There are some options I think:
   
   1. use "blacklist" anywhere
   2. use "exclusion" anywhere, even it does not mention excluding what, but it should be clear we are excluding bad workers
   3. use "excludedWorker" or "workerExclusion" based on the context.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org