[jira] [Comment Edited] (CASSANDRA-14935) PendingAntiCompaction should be more judicious in the compactions it cancels

["Marcus Eriksson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742884#comment-16742884 ] 

Marcus Eriksson edited comment on CASSANDRA-14935 at 1/15/19 9:17 AM:
----------------------------------------------------------------------

tests: https://circleci.com/gh/krummas/workflows/cassandra/tree/marcuse%2F14935
patch: https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14935?expand=1

Basic idea is to track which sstables are involved in which compaction in {{CompactionInfo}} and give {{runWithCompactionsDisabled}} a predicate on which sstables to abort compaction for. The predicate is then used when starting anticompactions (both to avoid cancelling compactions in repaired data and for the non-intersecting ranges) and when starting sub range compactions


was (Author: krummas):
tests: https://circleci.com/gh/krummas/workflows/cassandra/tree/marcuse%2F14935
patch: https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14935?expand=1

basic idea is to track which sstables are involved in the compaction in {{CompactionInfo}} and give {{runWithCompactionsDisabled}} a predicate on which sstables to abort compaction for.


> PendingAntiCompaction should be more judicious in the compactions it cancels
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-14935
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14935
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Major
>             Fix For: 4.0
>
>
> PendingAntiCompaction currently cancels all ongoing compactions to be able to grab the sstables it requires - it should;
> * avoid stopping ongoing anticompactions - for example, if we have an sstable [0, 100] and are anticompacting it on [0, 50] - now if we start a new incremental repair on [51, 100] we will (try to) stop the first one. Instead we should fail the new incremental repair request.
> * avoid stopping unrelated regular compactions - we should only stop regular compactions for the sstables the new anticompaction needs
> This requires us to keep track of which sstables are being compacted by a given compaction id.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org