You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/26 11:33:05 UTC
[GitHub] [apisix-java-plugin-runner] Hugo-X opened a new pull request #74: fix(sample): StopRequestDemoFilter (#67)
Hugo-X opened a new pull request #74:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/74
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
#67
___
### Bugfix
- Description
The type of **conf.get("stop_response_code")** can be Double or String, ClassCastException may happen.
- How to fix?
Convert the type of **conf.get("stop_response_code")**
___
### New feature or improvement
- Describe the details and related test reports.
- Source branch
- Related commits and pull requests
- Target branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #74: fix(sample): StopRequestDemoFilter (#67)
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #74:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/74#issuecomment-927314049
can add test about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass merged pull request #74: fix(sample): StopRequestDemoFilter
Posted by GitBox <gi...@apache.org>.
tzssangglass merged pull request #74:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] dmsolr commented on a change in pull request #74: fix(sample): StopRequestDemoFilter (#67)
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #74:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/74#discussion_r731465598
##########
File path: sample/pom.xml
##########
@@ -49,5 +49,24 @@
<groupId>io.projectreactor</groupId>
<artifactId>reactor-core</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-starter-test</artifactId>
+ <scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-classic</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
Review comment:
sparing-boot-starter-test is under ASF v2 which is okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #74: fix(sample): StopRequestDemoFilter (#67)
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #74:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/74#issuecomment-945259012
hi，@Hugo-X, the `StopRequestDemoFilterTest.java` should add a valid license header, just as:https://github.com/apache/apisix-java-plugin-runner/blob/a5ca9ca8045a19694b94c57986ae7d298eff986e/runner-core/src/main/java/org/apache/apisix/plugin/runner/codec/DelayedDecoder.java#L1-L16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #74: fix(sample): StopRequestDemoFilter (#67)
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #74:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/74#discussion_r730514394
##########
File path: sample/pom.xml
##########
@@ -49,5 +49,24 @@
<groupId>io.projectreactor</groupId>
<artifactId>reactor-core</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-starter-test</artifactId>
+ <scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-classic</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
Review comment:
@dmsolr Do you know that these jar packages have LINCESE issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org