You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/22 00:07:14 UTC

[GitHub] [airflow] dstandish commented on pull request #26576: Add oracledb thick mode support for oracle provider

dstandish commented on PR #26576:
URL: https://github.com/apache/airflow/pull/26576#issuecomment-1254352083

   > I'm not sure [init_oracle_client](https://github.com/oracle/python-oracledb/blob/main/src/oracledb/impl/thick/utils.pyx#L436) returns a client - seems to be just setting up the parameters for calling the thick client. I think?
   
   doesn't really matter.  why retrieve the conn in two places, in two different ways? if you do it in `__init__.py`, why do we do it again in `get_conn`?  
   
   what's the difference between the way we handle the airflow conn in init vs in get_conn?  probably there shouldn't be any difference, because probably it should just be done once and in one place right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org