You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Conor MacNeill <co...@cortexebusiness.com.au> on 2003/07/03 16:26:53 UTC
Checkstyle Audit
I've done a checkstyle audit with the new xdoc generating stylesheets and
uploaded this to the server
http://ant.apache.org/reports/checkstyle/
It's not linked into the rest of the site (nor is it in CVS). It's mainly just
for interest at the moment. It does show which files are good candidates for
some cleanup action :-).
BTW, this is checkstyle on maximum volume. I'll probably turn it down a bit a
little later on. It is too late to fix some of our code now, for backward
compatibility reasons, so I'll be trying to focus on what can be fixed.
If you hover over a line in the detail report it will show which checkstyle
module triggered the report.
Conor
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
On Fri, 4 Jul 2003 08:10 pm, Antoine Levy-Lambert wrote:
> Hi Conor,
> I am a beotian with xml/xsl.
> How do you run the style sheets yourself against the source code of ant ?
> Antoine
Had to look that one up. The check.xml file contains all the tasks necessary
to run the audit.
Conor
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by Antoine Levy-Lambert <an...@antbuild.com>.
Hi Conor,
I am a beotian with xml/xsl.
How do you run the style sheets yourself against the source code of ant ?
Antoine
----- Original Message -----
From: "Conor MacNeill" <co...@cortexebusiness.com.au>
To: <de...@ant.apache.org>
Sent: Thursday, July 03, 2003 4:26 PM
Subject: Checkstyle Audit
> I've done a checkstyle audit with the new xdoc generating stylesheets and
> uploaded this to the server
>
> http://ant.apache.org/reports/checkstyle/
>
> It's not linked into the rest of the site (nor is it in CVS). It's mainly
just
> for interest at the moment. It does show which files are good candidates
for
> some cleanup action :-).
>
> BTW, this is checkstyle on maximum volume. I'll probably turn it down a
bit a
> little later on. It is too late to fix some of our code now, for backward
> compatibility reasons, so I'll be trying to focus on what can be fixed.
>
> If you hover over a line in the detail report it will show which
checkstyle
> module triggered the report.
>
> Conor
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by peter reilly <pe...@corvil.com>.
I know ...
Ah well,
Peter
On Thu, 2003-07-03 at 16:30, Stefan Bodewig wrote:
> On 03 Jul 2003, peter reilly <pe...@corvil.com> wrote:
>
> > minor: The "LeftCurlyCheck" is against my in-house rule that
> > if there is a multi line condition, the { should be
> > on a separate line - but I can live the rule.
>
> You inhouse rule is against Ant's coding style, which comes from here
> <http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html> 8-)
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by Stefan Bodewig <bo...@apache.org>.
On 03 Jul 2003, peter reilly <pe...@corvil.com> wrote:
> minor: The "LeftCurlyCheck" is against my in-house rule that
> if there is a multi line condition, the { should be
> on a separate line - but I can live the rule.
You inhouse rule is against Ant's coding style, which comes from here
<http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html> 8-)
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
On Fri, 4 Jul 2003 08:26 pm, peter reilly wrote:
> If that is done, the java-docs should also be included.
>
> In any case, it is easy to run the check locally (once
> one figures out that ant -f check.xml checkstyle needs
> to be run before ant -f check.xml ;-)
> Peter
>
:-) I just did that while I was working on the XSL stylesheets. The checkstyle
step is expensive. An <uptodate> in there might be a good idea. Of course,
I'm not sure what the best default should be since I generate the text report
and a tocheck setting to get clickable links in my editor.
Conor
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by Antoine Levy-Lambert <an...@antbuild.com>.
It sounds good. I wish I would know something about Gump to be able to help.
Antoine
----- Original Message -----
From: "Conor MacNeill" <co...@cortexebusiness.com.au>
To: "Ant Developers List" <de...@ant.apache.org>
Sent: Friday, July 04, 2003 12:23 PM
Subject: Re: Checkstyle Audit
> On Fri, 4 Jul 2003 05:32 pm, Antoine Levy-Lambert wrote:
> > Hi Conor,
> >
> > actually, it might be even better if the pages were generated by a cron
job
> > running daily, or even better, if a kind of cvs commit daemon would
> > regenerate the pages corresponding to each changed source file.
> >
>
> It's ad-hoc at the moment. What I would like is to create an ant-site or
> ant-reports project in Gump and run it nightly from there. It would need
more
> work on the HTML generation from the generated xdocs. It could also
> incorporate the xdocs manual generation. We may need to rethink how we
> publish the site.
>
> Conor
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by peter reilly <pe...@corvil.com>.
On Fri, 2003-07-04 at 11:23, Conor MacNeill wrote:
> On Fri, 4 Jul 2003 05:32 pm, Antoine Levy-Lambert wrote:
> > Hi Conor,
> >
> > actually, it might be even better if the pages were generated by a cron job
> > running daily, or even better, if a kind of cvs commit daemon would
> > regenerate the pages corresponding to each changed source file.
> >
>
> It's ad-hoc at the moment. What I would like is to create an ant-site or
> ant-reports project in Gump and run it nightly from there. It would need more
> work on the HTML generation from the generated xdocs. It could also
> incorporate the xdocs manual generation. We may need to rethink how we
> publish the site.
If that is done, the java-docs should also be included.
In any case, it is easy to run the check locally (once
one figures out that ant -f check.xml checkstyle needs
to be run before ant -f check.xml ;-)
Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
On Fri, 4 Jul 2003 05:32 pm, Antoine Levy-Lambert wrote:
> Hi Conor,
>
> actually, it might be even better if the pages were generated by a cron job
> running daily, or even better, if a kind of cvs commit daemon would
> regenerate the pages corresponding to each changed source file.
>
It's ad-hoc at the moment. What I would like is to create an ant-site or
ant-reports project in Gump and run it nightly from there. It would need more
work on the HTML generation from the generated xdocs. It could also
incorporate the xdocs manual generation. We may need to rethink how we
publish the site.
Conor
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by Antoine Levy-Lambert <an...@antbuild.com>.
Hi Conor,
actually, it might be even better if the pages were generated by a cron job
running daily, or even better, if a kind of cvs commit daemon would
regenerate the pages corresponding to each changed source file.
Cheers,
Antoine
----- Original Message -----
From: "Conor MacNeill" <co...@cortexebusiness.com.au>
To: "Ant Developers List" <de...@ant.apache.org>
Sent: Friday, July 04, 2003 1:13 AM
Subject: Re: Checkstyle Audit
> On Fri, 4 Jul 2003 01:15 am, peter reilly wrote:
> > Excellent work.
> > I have a problem with three rules:
> >
> > major: The "DesignForExtensionCheck" seems a bit silly.
> > minor: The "LeftCurlyCheck" is against my in-house rule that
> > if there is a multi line condition, the { should be
> > on a separate line - but I can live the rule.
> > minor: "RedundantThrowsCheck: It complains about BuildException.
> >
>
> Thanks for the feedback.
>
> I can remove the first and third.
>
> I'll regenerate the pages tonight.
>
> Conor
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
On Fri, 4 Jul 2003 01:15 am, peter reilly wrote:
> Excellent work.
> I have a problem with three rules:
>
> major: The "DesignForExtensionCheck" seems a bit silly.
> minor: The "LeftCurlyCheck" is against my in-house rule that
> if there is a multi line condition, the { should be
> on a separate line - but I can live the rule.
> minor: "RedundantThrowsCheck: It complains about BuildException.
>
Thanks for the feedback.
I can remove the first and third.
I'll regenerate the pages tonight.
Conor
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by Gus Heck <gu...@cognition.olin.edu>.
> minor: "RedundantThrowsCheck: It complains about BuildException.
So is it prefered to eliminate the throws BuildException? or keep it?
I'm willing to fix my code if I know what is actually desired here.
Gus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by peter reilly <pe...@corvil.com>.
Excellent work.
I have a problem with three rules:
major: The "DesignForExtensionCheck" seems a bit silly.
minor: The "LeftCurlyCheck" is against my in-house rule that
if there is a multi line condition, the { should be
on a separate line - but I can live the rule.
minor: "RedundantThrowsCheck: It complains about BuildException.
Peter
On Thu, 2003-07-03 at 15:26, Conor MacNeill wrote:
> I've done a checkstyle audit with the new xdoc generating stylesheets and
> uploaded this to the server
>
> http://ant.apache.org/reports/checkstyle/
>
> It's not linked into the rest of the site (nor is it in CVS). It's mainly just
> for interest at the moment. It does show which files are good candidates for
> some cleanup action :-).
>
> BTW, this is checkstyle on maximum volume. I'll probably turn it down a bit a
> little later on. It is too late to fix some of our code now, for backward
> compatibility reasons, so I'll be trying to focus on what can be fixed.
>
> If you hover over a line in the detail report it will show which checkstyle
> module triggered the report.
>
> Conor
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by Stefan Bodewig <bo...@apache.org>.
On 04 Jul 2003, peter reilly <pe...@corvil.com> wrote:
> I am surprised you do not see the tooltips
I do now - and I'm no longer surprised. I must have disabled tooltips
some time ago, can't remember why and when.
Sorry for the noise
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by peter reilly <pe...@corvil.com>.
I am surprised you do not see the tooltips
The mozilla page
http://www.mozilla.org/docs/web-developer/faq.html
makes a little song and dance over suporting
tooltips for the title attribute.
Peter
On Fri, 2003-07-04 at 12:50, Stefan Bodewig wrote:
> On Fri, 4 Jul 2003, Conor MacNeill <co...@cortexebusiness.com.au>
> wrote:
>
> > The pages validate by w3c.org so maybe a bug in Mozilla 1.4?
>
> I don't think that the W3C tests whether the title attribute generates
> a tooltip 8-)
>
> Peter says that it works for him, which is strange. I'll simply
> accept it as an inconvenience.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by Stefan Bodewig <bo...@apache.org>.
On Fri, 4 Jul 2003, Conor MacNeill <co...@cortexebusiness.com.au>
wrote:
> The pages validate by w3c.org so maybe a bug in Mozilla 1.4?
I don't think that the W3C tests whether the title attribute generates
a tooltip 8-)
Peter says that it works for him, which is strange. I'll simply
accept it as an inconvenience.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
On Fri, 4 Jul 2003 08:51 pm, Stefan Bodewig wrote:
> On Fri, 4 Jul 2003, Conor MacNeill <co...@cortexebusiness.com.au>
>
> wrote:
> > Works on Mozilla 1.2.1 on Linux :-( It is just a title attribute in
> > an anchor with no href.
>
> It seems as if the href was required for it to work in 1.4.
>
The pages validate by w3c.org so maybe a bug in Mozilla 1.4?
Conor
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by peter reilly <pe...@corvil.com>.
I just downloaded mozilla 1.4, and the tooltips
work fine on Linux.
Peter
On Fri, 2003-07-04 at 11:51, Stefan Bodewig wrote:
> On Fri, 4 Jul 2003, Conor MacNeill <co...@cortexebusiness.com.au>
> wrote:
>
> > Works on Mozilla 1.2.1 on Linux :-( It is just a title attribute in
> > an anchor with no href.
>
> It seems as if the href was required for it to work in 1.4.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by Stefan Bodewig <bo...@apache.org>.
On Fri, 4 Jul 2003, Conor MacNeill <co...@cortexebusiness.com.au>
wrote:
> Works on Mozilla 1.2.1 on Linux :-( It is just a title attribute in
> an anchor with no href.
It seems as if the href was required for it to work in 1.4.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
On Fri, 4 Jul 2003 08:23 pm, Stefan Bodewig wrote:
> On Fri, 4 Jul 2003, Conor MacNeill <co...@cortexebusiness.com.au>
>
> wrote:
> > If you hover over a line in the detail report it will show which
> > checkstyle module triggered the report.
>
> Doesn't seem to work for Mozilla 1.4 on Linux.
>
Works on Mozilla 1.2.1 on Linux :-( It is just a title attribute in an anchor
with no href.
Conor
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Checkstyle Audit
Posted by Stefan Bodewig <bo...@apache.org>.
On Fri, 4 Jul 2003, Conor MacNeill <co...@cortexebusiness.com.au>
wrote:
> If you hover over a line in the detail report it will show which
> checkstyle module triggered the report.
Doesn't seem to work for Mozilla 1.4 on Linux.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org