You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/03 02:46:07 UTC

[GitHub] [pulsar] equanz opened a new pull request #7439: [pulsar-client-cpp] Add MessageId to send Message

equanz opened a new pull request #7439:
URL: https://github.com/apache/pulsar/pull/7439


   Fixes https://github.com/apache/pulsar-client-node/issues/94
   
   ### Motivation
   We want to return MessageId at Producer.send in pulsar-client-node. It use Producer::send internally but send method can't return MessageId(sendAsync was already implemented in https://github.com/apache/pulsar/pull/4811).
   
   ### Modifications
   Add MessageId to Message instance of Producer::send argument.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   
   * Check MessageId at E2E test
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy merged pull request #7439: [pulsar-client-cpp] Add MessageId to send Message

Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #7439:
URL: https://github.com/apache/pulsar/pull/7439


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #7439: [pulsar-client-cpp] Add MessageId to send Message

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7439:
URL: https://github.com/apache/pulsar/pull/7439#issuecomment-653837040


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] equanz commented on pull request #7439: [pulsar-client-cpp] Add MessageId to send Message

Posted by GitBox <gi...@apache.org>.
equanz commented on pull request #7439:
URL: https://github.com/apache/pulsar/pull/7439#issuecomment-653391550


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org