You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by amandamoran <gi...@git.apache.org> on 2015/11/24 21:55:00 UTC
[GitHub] incubator-trafodion pull request: [[ TRAFODION 1636 & TRAFODION 16...
GitHub user amandamoran opened a pull request:
https://github.com/apache/incubator-trafodion/pull/187
[[ TRAFODION 1636 & TRAFODION 1642 ]] Fix for how DCS directory is found and named
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amandamoran/incubator-trafodion bugfixesInstall
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #187
----
commit 6e7836547f659d7e318b192ef8f3020a4991e0d8
Author: Amanda Moran <am...@apache.com>
Date: 2015-11-24T20:52:41Z
Small change in how DCS directory is found and named
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [[ TRAFODION 1636 & TRAFODION 16...
Posted by amandamoran <gi...@git.apache.org>.
Github user amandamoran commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/187#discussion_r45805784
--- Diff: install/installer/dcs_installer ---
@@ -136,7 +136,8 @@ echo "***INFO: untarring build file $DCS_BUILD_FILE"
tar -xzf $DCS_BUILD_FILE
# get the dcs install directory name which is imbedded in the tar file
-DCS_DIR=$(tar -tf $DCS_BUILD_FILE | grep LICENSE | sed -e "s@\(^.*\)/LICENSE.txt@\1@")
+DCS_DIR=$(tar -tf $DCD_BUILD_FILE | grep --max-count=1 bin | sed -e "s@\(^.*\)/bin/@\1@")
--- End diff --
Yes, it is. Thanks Dave!
On Tue, Nov 24, 2015 at 2:37 PM, DaveBirdsall <no...@github.com>
wrote:
> In install/installer/dcs_installer
> <https://github.com/apache/incubator-trafodion/pull/187#discussion_r45805519>
> :
>
> > @@ -136,7 +136,8 @@ echo "***INFO: untarring build file $DCS_BUILD_FILE"
> > tar -xzf $DCS_BUILD_FILE
> >
> > # get the dcs install directory name which is imbedded in the tar file
> > -DCS_DIR=$(tar -tf $DCS_BUILD_FILE | grep LICENSE | sed -e "s@\(^.*\)/LICENSE.txt@\1@")
> > +DCS_DIR=$(tar -tf $DCD_BUILD_FILE | grep --max-count=1 bin | sed -e "s@\(^.*\)/bin/@\1@")
>
> Is there a typo here? "DCD..." as opposed to "DCS..."
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-trafodion/pull/187/files#r45805519>.
>
--
Thanks,
Amanda Moran
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [[ TRAFODION 1636 & TRAFODION 16...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/187#discussion_r45805519
--- Diff: install/installer/dcs_installer ---
@@ -136,7 +136,8 @@ echo "***INFO: untarring build file $DCS_BUILD_FILE"
tar -xzf $DCS_BUILD_FILE
# get the dcs install directory name which is imbedded in the tar file
-DCS_DIR=$(tar -tf $DCS_BUILD_FILE | grep LICENSE | sed -e "s@\(^.*\)/LICENSE.txt@\1@")
+DCS_DIR=$(tar -tf $DCD_BUILD_FILE | grep --max-count=1 bin | sed -e "s@\(^.*\)/bin/@\1@")
--- End diff --
Is there a typo here? "DCD..." as opposed to "DCS..."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [[ TRAFODION 1636 & TRAFODION 16...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/187
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---