You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2018/04/18 15:01:19 UTC
[Bug 62312] New: Add Proxy Authentication support to websocket
client
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
Bug ID: 62312
Summary: Add Proxy Authentication support to websocket client
Product: Tomcat 9
Version: 9.0.7
Hardware: PC
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: WebSocket
Assignee: dev@tomcat.apache.org
Reporter: jmokos@riverbed.com
Target Milestone: -----
Created attachment 35880
--> https://bz.apache.org/bugzilla/attachment.cgi?id=35880&action=edit
Patch to provide proxy authentication to websocket client
The attached patch provides proxy authentication support to the websocket
client via the ClientEndpointConfig.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
--- Comment #15 from radhika.jaju@veritas.com <ra...@veritas.com> ---
Thanks Joe Mokos and Mark Thomas. Really appreciate it.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
--- Comment #9 from radhika.jaju@veritas.com <ra...@veritas.com> ---
We need the proxy basic authentication support for websocket connection as we
are using the tomcat websocket client library.
Any possibility of this getting it bundled with the 9.0.x version of Tomcat?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
--- Comment #14 from Mark Thomas <ma...@apache.org> ---
It was only so quick due to the great work already done by Joe Mokos.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #12 from Mark Thomas <ma...@apache.org> ---
Fixed in:
- 10.1.x for 10.1.0-M18 onwards
- 10.0.x for 10.0.24 onwards
- 9.0.x for 9.0.66 onwards
- 8.5.x for 8.5.83 onwards
Many thanks to Joe Mokos for the original patch. While there was a lot of
refactoring in the final set of commits, the underlying fix is exactly as
proposed in the original patch.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
--- Comment #13 from radhika.jaju@veritas.com <ra...@veritas.com> ---
Wow, Thanks so much for quick resolution..
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
--- Comment #5 from Joe Mokos <jm...@riverbed.com> ---
I've made the changes you outlined in your previous comments.
The diff file also contains changes to do realm validation.
Let me know if additional info is needed.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
--- Comment #8 from Mark Thomas <ma...@apache.org> ---
(In reply to radhika.jaju@veritas.com from comment #7)
> Is this available in any released version?
No.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
--- Comment #11 from Mark Thomas <ma...@apache.org> ---
I'm looking at this now.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |atuljadhav274@gmail.com
--- Comment #10 from Mark Thomas <ma...@apache.org> ---
*** Bug 59758 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
Joe Mokos <jm...@riverbed.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #35887|0 |1
is obsolete| |
--- Comment #4 from Joe Mokos <jm...@riverbed.com> ---
Created attachment 35984
--> https://bz.apache.org/bugzilla/attachment.cgi?id=35984&action=edit
Git diffs for proxy authentication support
git diff of trunk w/proxy auth changes vs trunk
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
--- Comment #2 from Joe Mokos <jm...@riverbed.com> ---
I've uploaded a 2nd patch file generated from git that supersedes the 1st patch
file. This patch file contains the following changes:
1. The original algorithm used to choose the proxy authentication scheme
always chose the first Proxy-Authenticate header returned on the 407 response.
Of course the first proxy I tried this on supported NTLM. So "invalid
authentication scheme" was logged and authorization failed. I changed the
algorithm to choose the first Proxy-Authenticate header that contained a scheme
supported by the websocket client, ie Digest or Basic.
2. The algorithm used to choose the WWW authenticate scheme had the same
problem as the proxy authenticate scheme so the same change was applied there.
3. The variable arguments supplied to getString were not being appended to the
base message. For instance, the exception messages for an unsupported auth
scheme rendered as "wsWebSocketContainer.unsupportedProxyAuthScheme" rather
than "wsWebSocketContainer.unsupportedProxyAuthScheme 407 NTLM". {n} tokens
were added to first argument of getSTring to support the appropriate number of
variable arguments.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
Joe Mokos <jm...@riverbed.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #35880|0 |1
is obsolete| |
--- Comment #1 from Joe Mokos <jm...@riverbed.com> ---
Created attachment 35887
--> https://bz.apache.org/bugzilla/attachment.cgi?id=35887&action=edit
Change for proxy authentication with updated scheme selection algorithm
This attachment supersedes all previous attachments
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
--- Comment #6 from Joe Mokos <jm...@riverbed.com> ---
I've made the changes you outlined in your previous comments.
The diff file is against the trunk as of 6/22/2018. It also contains changes
to do realm validation.
Let me know if additional info is needed.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
--- Comment #3 from Mark Thomas <ma...@apache.org> ---
Please provide a diff against trunk rather than a sequence of patch files.
Please remove all the getString {n} changes from the proposed diff.
Substitution is correctly handled by Tomcat's StringManager implementation.
The patch is not using the StringManager correctly. New strings need to be
defined in LocalStrings.properties
Please add ALv2 headers (as per the Tomcat source files) to all new files.
Please remove all @author tags.
Please document the new properties in web-socket-howto.xml
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
Christopher Schultz <ch...@christopherschultz.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #35880|0 |1
is patch| |
Attachment #35880|application/mbox |text/plain
mime type| |
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62312] Add Proxy Authentication support to websocket client
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312
--- Comment #7 from radhika.jaju@veritas.com <ra...@veritas.com> ---
Is this available in any released version?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org