You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/03/27 06:56:26 UTC

[GitHub] [incubator-hudi] garyli1019 opened a new pull request #1454: MINOR update doc to include inc query on partitions

garyli1019 opened a new pull request #1454: MINOR update doc to include inc query on partitions
URL: https://github.com/apache/incubator-hudi/pull/1454
 
 
   Change Impala matrix
   Add incremental pulling from certain partitions to 0.5.2 and latest Doc
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] garyli1019 commented on issue #1454: MINOR update doc to include inc query on partitions

Posted by GitBox <gi...@apache.org>.
garyli1019 commented on issue #1454: MINOR update doc to include inc query on partitions
URL: https://github.com/apache/incubator-hudi/pull/1454#issuecomment-605511322
 
 
   thanks for reviewing! Addressed the comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #1454: MINOR update doc to include inc query on partitions

Posted by GitBox <gi...@apache.org>.
garyli1019 commented on a change in pull request #1454: MINOR update doc to include inc query on partitions
URL: https://github.com/apache/incubator-hudi/pull/1454#discussion_r399702927
 
 

 ##########
 File path: docs/_docs/0.5.2/2_3_querying_data.md
 ##########
 @@ -146,8 +146,9 @@ The following snippet shows how to obtain all records changed after `beginInstan
 ```java
  Dataset<Row> hudiIncQueryDF = spark.read()
      .format("org.apache.hudi")
-     .option(DataSourceReadOptions.QUERY_TYPE_OPT_KEY(), DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL())
+     .option(DataSourceReadOptions.QUERY_TYPE_OPT_KEY(),DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL())
 
 Review comment:
   yes, deleted the space accidentally 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1454: MINOR update doc to include inc query on partitions

Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1454: MINOR update doc to include inc query on partitions
URL: https://github.com/apache/incubator-hudi/pull/1454#discussion_r399658424
 
 

 ##########
 File path: docs/_docs/0.5.2/2_3_querying_data.md
 ##########
 @@ -146,8 +146,9 @@ The following snippet shows how to obtain all records changed after `beginInstan
 ```java
  Dataset<Row> hudiIncQueryDF = spark.read()
      .format("org.apache.hudi")
-     .option(DataSourceReadOptions.QUERY_TYPE_OPT_KEY(), DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL())
+     .option(DataSourceReadOptions.QUERY_TYPE_OPT_KEY(),DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL())
 
 Review comment:
   better to keep a blank, keep it as is?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] leesf merged pull request #1454: MINOR update doc to include inc query on partitions

Posted by GitBox <gi...@apache.org>.
leesf merged pull request #1454: MINOR update doc to include inc query on partitions
URL: https://github.com/apache/incubator-hudi/pull/1454
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services