[jira] [Commented] (FELIX-5750) Clarify relation of "Enable Proxy/Load Balancer Connection" Jetty feature and SSL Filter

["Konrad Windszus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-5750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264439#comment-16264439 ] 

Konrad Windszus commented on FELIX-5750:
----------------------------------------

After having a closer look at http://www.eclipse.org/jetty/javadoc/9.4.7.v20170914/org/eclipse/jetty/server/ForwardedRequestCustomizer.html it seems to me, that we should rather deprecate the SSL filter and point everyone to the Jetty feature (although it is not that flexible). But since it is built into Jetty the sendRedirect is much less invasive than via the SSL Filter (which still feels a bit hacky to me). Is there any use case you cannot cover with the new Jetty module?

> Clarify relation of "Enable Proxy/Load Balancer Connection" Jetty feature and SSL Filter
> ----------------------------------------------------------------------------------------
>
>                 Key: FELIX-5750
>                 URL: https://issues.apache.org/jira/browse/FELIX-5750
>             Project: Felix
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: http.jetty-3.2.0
>            Reporter: Konrad Windszus
>
> With the addition of FELIX-5207 (documented in http://www.eclipse.org/jetty/javadoc/9.4.7.v20170914/org/eclipse/jetty/server/ForwardedRequestCustomizer.html) and the SSL Filter (described in http://felix.apache.org/documentation/subprojects/apache-felix-http-service.html#ssl-filter-configuration-properties) it seems that there are two different mechanisms in place to actually achieve the same. Please clarify in the documentation how these two relate and which one to choose for which use case. Even the SSL filter allows to configure the headers since https://issues.apache.org/jira/browse/FELIX-4330.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)