You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Christopher L. Shannon (JIRA)" <ji...@apache.org> on 2018/07/16 11:45:00 UTC
[jira] [Comment Edited] (AMQ-7006) CLONE - STOMP protocol converter
tracks pending ACKS in Client mode but doesn't remove all ACK'd IDs, just
the one submitted.
[ https://issues.apache.org/jira/browse/AMQ-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545100#comment-16545100 ]
Christopher L. Shannon edited comment on AMQ-7006 at 7/16/18 11:44 AM:
-----------------------------------------------------------------------
This patch looks ok to me but for the logging you should use the SLF4J logger and not System.out.println statements. In general it's also good to add a test or two (if possible, might be tricky to verify in this case because the behavior is not broken just a memory leak) to show the patch works and to prevent future issues.
[~tabish121] - Before I merge does since you worked on AMQ-5423 can you take a quick look and make sure this looks good to you as well?
was (Author: christopher.l.shannon):
This patch looks generally ok to me but for the logging you should use the SLF4J logger and not System.out.println statements. In general it's also good to add a test or two (if possible, might be tricky to verify in this case because the behavior is not broken just a memory leak) to show the patch works and to prevent future issues.
[~tabish121] - Before I merge does since you worked on AMQ-5423 can you take a quick look and make sure this looks good to you as well?
> CLONE - STOMP protocol converter tracks pending ACKS in Client mode but doesn't remove all ACK'd IDs, just the one submitted.
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-7006
> URL: https://issues.apache.org/jira/browse/AMQ-7006
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.15.3
> Reporter: Avikash Mishra
> Priority: Major
> Attachments: AMQ-6975_Remove_all_pending_acks_that_have_been_dispatched_.patch
>
>
> The patch referenced in AMQ-5423 only addressed the memory leak for Client-Individual mode. Client mode is still affected as multiple messages are acknowledged with a single ACK. The single ACK is removed from memory but all the rest remain which grows over time until AMQ crashes or until the client session ends and all the pending ACKs are cleaned up at that point. At the moment we are having to regularly restart our STOMP clients to prevent the memory leak from causing a crash.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)