You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2026/10/01 09:24:46 UTC
[Impala-ASF-CR] IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24987
Change subject: IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
......................................................................
IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
_execute_and_collect_profiles() started the queries in quick
succession, expecting them to reach the admission queue in the same
order - the fetching of results happens in the original order and was
not prepared for out of order admission (the next query can't be
admitted before the results of the previous are fetched as result
spooling is disabled for these queries).
As ExecuteStatement RPC waits only for planning to finish and admission
is done on a different thread, a query requested later can actually
reach the admission queue earlier. This is more likely in tests with
admissiond where the gap between planning and admission is longer,
leading to frequent test failures in the ACService case.
The fix is to serialize admission by waiting for a query to reach the
admission queue (admitted, queued or rejected) before starting the
next one. This adds some delay to the function (worst case around 100ms
per query start when admissiond is used), but this seems small enough
to no alter the semantics of the calling tests.
Assisted-by: Claude Opus 5 (Claude Code)
Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 15 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/24987/1
--
To view, visit http://gerrit.cloudera.org:8080/24987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad
Gerrit-Change-Number: 24987
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24987 )
Change subject: IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24275/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad
Gerrit-Change-Number: 24987
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Oct 2026 09:45:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24987 )
Change subject: IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24987/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24987/1//COMMIT_MSG@26
PS1, Line 26: no
typo: not
--
To view, visit http://gerrit.cloudera.org:8080/24987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad
Gerrit-Change-Number: 24987
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Oct 2026 09:35:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24987 )
Change subject: IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14181/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad
Gerrit-Change-Number: 24987
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Oct 2026 12:05:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24987 )
Change subject: IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24987/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24987/1//COMMIT_MSG@26
PS1, Line 26: no
> typo: not
Done
--
To view, visit http://gerrit.cloudera.org:8080/24987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad
Gerrit-Change-Number: 24987
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Oct 2026 12:04:08 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24987 )
Change subject: IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
......................................................................
Patch Set 1: Code-Review+2
LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/24987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad
Gerrit-Change-Number: 24987
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Oct 2026 12:00:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24987 )
Change subject: IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
......................................................................
IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
_execute_and_collect_profiles() started the queries in quick
succession, expecting them to reach the admission queue in the same
order - the fetching of results happens in the original order and was
not prepared for out of order admission (the next query can't be
admitted before the results of the previous are fetched as result
spooling is disabled for these queries).
As ExecuteStatement RPC waits only for planning to finish and admission
is done on a different thread, a query requested later can actually
reach the admission queue earlier. This is more likely in tests with
admissiond where the gap between planning and admission is longer,
leading to frequent test failures in the ACService case.
The fix is to serialize admission by waiting for a query to reach the
admission queue (admitted, queued or rejected) before starting the
next one. This adds some delay to the function (worst case around 100ms
per query start when admissiond is used), but this seems small enough
to not alter the semantics of the calling tests.
Assisted-by: Claude Opus 5 (Claude Code)
Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad
Reviewed-on: http://gerrit.cloudera.org:8080/24987
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 15 insertions(+), 7 deletions(-)
Approvals:
Csaba Ringhofer: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/24987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad
Gerrit-Change-Number: 24987
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24987 )
Change subject: IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
......................................................................
Patch Set 2: Code-Review+2
thx for the fast reviews! carrying +2 from Zoltan
--
To view, visit http://gerrit.cloudera.org:8080/24987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad
Gerrit-Change-Number: 24987
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Oct 2026 12:03:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Arnab Karmakar, Zoltan Borok-Nagy, Mihaly Szjatinya, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24987
to look at the new patch set (#2).
Change subject: IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
......................................................................
IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
_execute_and_collect_profiles() started the queries in quick
succession, expecting them to reach the admission queue in the same
order - the fetching of results happens in the original order and was
not prepared for out of order admission (the next query can't be
admitted before the results of the previous are fetched as result
spooling is disabled for these queries).
As ExecuteStatement RPC waits only for planning to finish and admission
is done on a different thread, a query requested later can actually
reach the admission queue earlier. This is more likely in tests with
admissiond where the gap between planning and admission is longer,
leading to frequent test failures in the ACService case.
The fix is to serialize admission by waiting for a query to reach the
admission queue (admitted, queued or rejected) before starting the
next one. This adds some delay to the function (worst case around 100ms
per query start when admissiond is used), but this seems small enough
to not alter the semantics of the calling tests.
Assisted-by: Claude Opus 5 (Claude Code)
Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 15 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/24987/2
--
To view, visit http://gerrit.cloudera.org:8080/24987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad
Gerrit-Change-Number: 24987
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24987 )
Change subject: IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad
Gerrit-Change-Number: 24987
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Oct 2026 16:44:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
Posted by "Mihaly Szjatinya (Code Review)" <ge...@cloudera.org>.
Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/24987 )
Change subject: IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests
......................................................................
Patch Set 1: Code-Review+1
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/24987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad
Gerrit-Change-Number: 24987
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Comment-Date: Thu, 01 Oct 2026 10:54:21 +0000
Gerrit-HasComments: No