[GitHub] [airflow] kaxil commented on a change in pull request #14990: Fix url generation for TriggerDagRunOperatorLink

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #14990:
URL: https://github.com/apache/airflow/pull/14990#discussion_r611173022



##########
File path: tests/utils/test_helpers.py
##########
@@ -140,10 +141,18 @@ def test_merge_dicts_recursive_right_only(self):
 
     @conf_vars(
         {
-            ("webserver", "dag_default_view"): "custom",
+            ("webserver", "dag_default_view"): "graph",
         }
     )
     def test_build_airflow_url_with_query(self):
+        """
+        Test query generated with dag_id and params
+        """
         query = {"dag_id": "test_dag", "param": "key/to.encode"}
-        url = build_airflow_url_with_query(query)
-        assert url == "/custom?dag_id=test_dag&param=key%2Fto.encode"
+        expected_url = "/graph?dag_id=test_dag&param=key%2Fto.encode"
+
+        from airflow.www.app import cached_app
+
+        with cached_app(testing=True).test_request_context():
+            assert build_airflow_url_with_query(query) == expected_url
+

Review comment:
       ```suggestion
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org