You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by Alberto Rodríguez <ar...@gmail.com> on 2014/10/28 11:29:54 UTC
Review Request 27279: METAMODEL-90 - Csv and Excel Data Context
constructors accept non existing files
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27279/
-----------------------------------------------------------
Review request for MetaModel.
Repository: metamodel
Description
-------
Added javadoc
Diffs
-----
csv/src/main/java/org/apache/metamodel/csv/CsvDataContext.java 9d56b1b27a047fa77e3d15ea3a3a03849b811ee6
excel/src/main/java/org/apache/metamodel/excel/ExcelDataContext.java 26a64c7304c8baf651b9af0879603745c25d3f6d
Diff: https://reviews.apache.org/r/27279/diff/
Testing
-------
Thanks,
Alberto Rodríguez
Re: Review Request 27279: METAMODEL-90 - Csv and Excel Data Context
constructors accept non existing files
Posted by Kasper Sørensen <i....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27279/#review58785
-----------------------------------------------------------
I think the sentence here has a more internal flavour than what I'd prefer for something that describes the method to an external audience. I'd rather stress the fact a bit like this "the file provided can be either existing or non-existing. In the case of non-existing files, a file will be automatically created when a CREATE TABLE update is executed on the DataContext."
- Kasper Sørensen
On okt. 28, 2014, 10:30 a.m., Alberto Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27279/
> -----------------------------------------------------------
>
> (Updated okt. 28, 2014, 10:30 a.m.)
>
>
> Review request for MetaModel.
>
>
> Repository: metamodel
>
>
> Description
> -------
>
> Added javadoc
>
>
> Diffs
> -----
>
> csv/src/main/java/org/apache/metamodel/csv/CsvDataContext.java 9d56b1b27a047fa77e3d15ea3a3a03849b811ee6
> excel/src/main/java/org/apache/metamodel/excel/ExcelDataContext.java 26a64c7304c8baf651b9af0879603745c25d3f6d
>
> Diff: https://reviews.apache.org/r/27279/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alberto Rodríguez
>
>
Re: Review Request 27279: METAMODEL-90 - Csv and Excel Data Context
constructors accept non existing files
Posted by Alberto Rodríguez <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27279/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 10:30 a.m.)
Review request for MetaModel.
Repository: metamodel
Description
-------
Added javadoc
Diffs
-----
csv/src/main/java/org/apache/metamodel/csv/CsvDataContext.java 9d56b1b27a047fa77e3d15ea3a3a03849b811ee6
excel/src/main/java/org/apache/metamodel/excel/ExcelDataContext.java 26a64c7304c8baf651b9af0879603745c25d3f6d
Diff: https://reviews.apache.org/r/27279/diff/
Testing
-------
Thanks,
Alberto Rodríguez