You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "nielm (via GitHub)" <gi...@apache.org> on 2023/12/19 15:28:50 UTC
[PR] Fix race condition in SpannerAccessor [beam]
nielm opened a new pull request, #29820:
URL: https://github.com/apache/beam/pull/29820
It is possible for the SpannerAccessor to be in the process of being closed at the same time as its refcount is being increased.
This would lead to java.lang.IllegalStateException: Pool has been closed errors
ISSUE TBD
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix race condition in SpannerAccessor [beam]
Posted by "VardhanThigle (via GitHub)" <gi...@apache.org>.
VardhanThigle commented on code in PR #29820:
URL: https://github.com/apache/beam/pull/29820#discussion_r1432424914
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
Review Comment:
Given that all access are serialised now, would it make sense to make the refcounts non-atomic and (possibly) members of `SpannerAccessror` Class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix race condition in SpannerAccessor [beam]
Posted by "VardhanThigle (via GitHub)" <gi...@apache.org>.
VardhanThigle commented on code in PR #29820:
URL: https://github.com/apache/beam/pull/29820#discussion_r1432424914
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
Review Comment:
Given that the getOrCreate/close are serialised now, would it make sense to make the refcounts non-atomic and (possibly) members of `SpannerAccessror` Class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix race condition in SpannerAccessor [beam]
Posted by "nielm (via GitHub)" <gi...@apache.org>.
nielm commented on code in PR #29820:
URL: https://github.com/apache/beam/pull/29820#discussion_r1432494347
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
Review Comment:
Yes, that makes sense. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix race condition in SpannerAccessor [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29820:
URL: https://github.com/apache/beam/pull/29820#issuecomment-1866023789
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @m-trieu for label java.
R: @Abacn for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix race condition in SpannerAccessor [beam]
Posted by "VardhanThigle (via GitHub)" <gi...@apache.org>.
VardhanThigle commented on PR #29820:
URL: https://github.com/apache/beam/pull/29820#issuecomment-1863802021
Thanks for the PR.
I have filed the issue at https://github.com/apache/beam/issues/29832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix race condition in SpannerAccessor [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #29820:
URL: https://github.com/apache/beam/pull/29820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix race condition in SpannerAccessor [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29820:
URL: https://github.com/apache/beam/pull/29820#issuecomment-1871110621
Reminder, please take a look at this pr: @m-trieu @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org