You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/02/27 15:27:16 UTC
Re: Review Request 71950: Updated containerizer's `update()` method to
handle resource limits.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71950/#review219674
-----------------------------------------------------------
src/tests/master_tests.cpp
Line 202 (original), 202 (patched)
<https://reviews.apache.org/r/71950/#comment307887>
I think we have some new cases of this in the codebase which need to be updated (at least one in file 'src/tests/master_draining_tests.cpp').
- Greg Mann
On Jan. 9, 2020, 1:37 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71950/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2020, 1:37 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10050
> https://issues.apache.org/jira/browse/MESOS-10050
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated containerizer's `update()` method to handle resource limits.
>
>
> Diffs
> -----
>
> src/slave/containerizer/composing.hpp 0f838fa63b02d38606a6c484f01d24952d569721
> src/slave/containerizer/composing.cpp d854794fc4775fb8a05efc233d488a64b9ef620a
> src/slave/containerizer/containerizer.hpp 6a9ebed5e55ad1cfed6340479743ef2bb4c05dab
> src/slave/containerizer/docker.hpp 0349f537cef9651427e0e3ed33fd693107e07aa0
> src/slave/containerizer/docker.cpp 2a9b2ffcbd01ae916839ae43c8342285ac3e14a2
> src/slave/containerizer/mesos/containerizer.hpp 9e86ff43535c4be937baa238442e8f0db8857a27
> src/slave/containerizer/mesos/containerizer.cpp dd940162b1e44dbdab1773894b2b33a260fdc8da
> src/tests/containerizer.hpp e05ce0323e032911d46d8682661ffe4463fdc276
> src/tests/containerizer.cpp 3ac992f8599e8a48f428b506f5bdecc722050c6a
> src/tests/containerizer/docker_containerizer_tests.cpp 689a7220a09f2a58dffdf0dc9fd9f0548600be0e
> src/tests/containerizer/mock_containerizer.hpp 8700257a9347199ed6e32b8b6b2a58787d68af03
> src/tests/master_tests.cpp 9688f5f0266f7c7142b54d488f2c13b427e542c0
> src/tests/mock_docker.hpp 4a2266fb1239cbc96c7df74b997212e3b3b01c75
> src/tests/registrar_zookeeper_tests.cpp 9d3ea5f194374fb3492fdfa8bd2efeef55fc4743
> src/tests/scheduler_tests.cpp 299d3a06ca1fd55ef55dc9be323b98a4da3be31a
> src/tests/slave_tests.cpp fd4fd6bd1baca0e4521999d2c08e6eab78e57a4f
>
>
> Diff: https://reviews.apache.org/r/71950/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>