You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2017/03/06 16:54:34 UTC

Re: [4/7] [text] Updated RELEASE-NOTES.txt in preparation for 1.0 release

On 5 March 2017 at 04:05,  <ch...@apache.org> wrote:
> Updated RELEASE-NOTES.txt in preparation for 1.0 release
>
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
> Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/bfdd0aa8
> Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/bfdd0aa8
> Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/bfdd0aa8
>
> Branch: refs/heads/release
> Commit: bfdd0aa8f794cfcecfd07aa9e506412ba914375a
> Parents: 85a247b
> Author: Rob Tompkins <ch...@apache.org>
> Authored: Sat Mar 4 22:54:52 2017 -0500
> Committer: Rob Tompkins <ch...@apache.org>
> Committed: Sat Mar 4 22:54:52 2017 -0500
>
> ----------------------------------------------------------------------
>  RELEASE-NOTES.txt | 42 +++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 39 insertions(+), 3 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/commons-text/blob/bfdd0aa8/RELEASE-NOTES.txt
> ----------------------------------------------------------------------
> diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
> index 56769a8..5964146 100644
> --- a/RELEASE-NOTES.txt
> +++ b/RELEASE-NOTES.txt
> @@ -1,5 +1,5 @@
>                            Apache Commons Text
> -                           Version 1.0-beta-1
> +                              Version 1.0
>                               Release Notes
>
>
> @@ -13,6 +13,42 @@ Java environment.
>
>  Apache Commons Text is a library focused on algorithms working on strings.
>
> +
> +INCOMPATIBLE CHANGES
> +====================
> +
> +All package names changed from org.apache.commons.text.beta in 1.0-beta-1 to
> +org.apache.commons.text in 1.0.
> +
> +Methods StringEscapeUtils#escapeHtml3Once and StringEscapeUtils#escapeHtml4Once
> +have been removed; see TEXT-40
> +
> +JAVA 9 SUPPORT
> +==============
> +
> +At our time of release of 1.0-beta-1, our build succeeds with Java 9-ea build 158,

That should be 1.0

> +and we believe all of our features to be Java 9 compatible. However, when we run
> +"mvn clean site" we have failures.
> +
> +FIXED BUGS
> +==========
> +
> +o TEXT-64:   Investigate locale issue in ExtendedMessageFormatTest. Thanks to
> +             chtompki.
> +o TEXT-69:   Resolve PMD/CMD Violations
> +o TEXT-65:   Fixing the 200 checkstyle errors present in 1.0-beta-1.
> +o TEXT-63:   Mutable fields should be private.
> +
> +REMOVED
> +=======
> +
> +o TEXT-40:   Escape HTML characters only once: revert.
> +
> +
> +
> +                        Release Notes for version 1.0-beta-1
> +
> +
>  A NOTE ON THE HISTORY OF THE CODE
>  =================================
>
> @@ -28,8 +64,8 @@ Lang into Commons Text.
>  JAVA 9 SUPPORT
>  ==============
>
> -At our time of release our build succeeds with Java 9-ea build 153, and we
> -believe all of our features to be Java 9 compatible.
> +At our time of release of 1.0-beta-1, our build succeeds with Java 9-ea build 153,
> +and we believe all of our features to be Java 9 compatible.
>
>  NEW FEATURES
>  ============
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [4/7] [text] Updated RELEASE-NOTES.txt in preparation for 1.0 release

Posted by Rob Tompkins <ch...@gmail.com>.

> On Mar 6, 2017, at 1:45 PM, sebb <se...@gmail.com> wrote:
> 
>> On 6 March 2017 at 18:20, Rob Tompkins <ch...@gmail.com> wrote:
>> 
>> 
>>>> On Mar 6, 2017, at 11:54 AM, sebb <se...@gmail.com> wrote:
>>>> 
>>>> On 5 March 2017 at 04:05,  <ch...@apache.org> wrote:
>>>> Updated RELEASE-NOTES.txt in preparation for 1.0 release
>>>> 
>>>> 
>>>> Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
>>>> Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/bfdd0aa8
>>>> Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/bfdd0aa8
>>>> Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/bfdd0aa8
>>>> 
>>>> Branch: refs/heads/release
>>>> Commit: bfdd0aa8f794cfcecfd07aa9e506412ba914375a
>>>> Parents: 85a247b
>>>> Author: Rob Tompkins <ch...@apache.org>
>>>> Authored: Sat Mar 4 22:54:52 2017 -0500
>>>> Committer: Rob Tompkins <ch...@apache.org>
>>>> Committed: Sat Mar 4 22:54:52 2017 -0500
>>>> 
>>>> ----------------------------------------------------------------------
>>>> RELEASE-NOTES.txt | 42 +++++++++++++++++++++++++++++++++++++++---
>>>> 1 file changed, 39 insertions(+), 3 deletions(-)
>>>> ----------------------------------------------------------------------
>>>> 
>>>> 
>>>> http://git-wip-us.apache.org/repos/asf/commons-text/blob/bfdd0aa8/RELEASE-NOTES.txt
>>>> ----------------------------------------------------------------------
>>>> diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
>>>> index 56769a8..5964146 100644
>>>> --- a/RELEASE-NOTES.txt
>>>> +++ b/RELEASE-NOTES.txt
>>>> @@ -1,5 +1,5 @@
>>>>                          Apache Commons Text
>>>> -                           Version 1.0-beta-1
>>>> +                              Version 1.0
>>>>                             Release Notes
>>>> 
>>>> 
>>>> @@ -13,6 +13,42 @@ Java environment.
>>>> 
>>>> Apache Commons Text is a library focused on algorithms working on strings.
>>>> 
>>>> +
>>>> +INCOMPATIBLE CHANGES
>>>> +====================
>>>> +
>>>> +All package names changed from org.apache.commons.text.beta in 1.0-beta-1 to
>>>> +org.apache.commons.text in 1.0.
>>>> +
>>>> +Methods StringEscapeUtils#escapeHtml3Once and StringEscapeUtils#escapeHtml4Once
>>>> +have been removed; see TEXT-40
>>>> +
>>>> +JAVA 9 SUPPORT
>>>> +==============
>>>> +
>>>> +At our time of release of 1.0-beta-1, our build succeeds with Java 9-ea build 158,
>>> 
>>> That should be 1.0
>> 
>> Thanks for that catch. You think I should re-build the release candidate? Feels like it.
> 
> I don't have a view on that. Mistakes happen. It can be mentioned in
> the Announce and fixed on the download site.
> 
> In any case, I would wait in case other issues are found.

Sounds good thanks again. 

> 
>> -Rob
>> 
>>> 
>>>> +and we believe all of our features to be Java 9 compatible. However, when we run
>>>> +"mvn clean site" we have failures.
>>>> +
>>>> +FIXED BUGS
>>>> +==========
>>>> +
>>>> +o TEXT-64:   Investigate locale issue in ExtendedMessageFormatTest. Thanks to
>>>> +             chtompki.
>>>> +o TEXT-69:   Resolve PMD/CMD Violations
>>>> +o TEXT-65:   Fixing the 200 checkstyle errors present in 1.0-beta-1.
>>>> +o TEXT-63:   Mutable fields should be private.
>>>> +
>>>> +REMOVED
>>>> +=======
>>>> +
>>>> +o TEXT-40:   Escape HTML characters only once: revert.
>>>> +
>>>> +
>>>> +
>>>> +                        Release Notes for version 1.0-beta-1
>>>> +
>>>> +
>>>> A NOTE ON THE HISTORY OF THE CODE
>>>> =================================
>>>> 
>>>> @@ -28,8 +64,8 @@ Lang into Commons Text.
>>>> JAVA 9 SUPPORT
>>>> ==============
>>>> 
>>>> -At our time of release our build succeeds with Java 9-ea build 153, and we
>>>> -believe all of our features to be Java 9 compatible.
>>>> +At our time of release of 1.0-beta-1, our build succeeds with Java 9-ea build 153,
>>>> +and we believe all of our features to be Java 9 compatible.
>>>> 
>>>> NEW FEATURES
>>>> ============
>>>> 
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [4/7] [text] Updated RELEASE-NOTES.txt in preparation for 1.0 release

Posted by sebb <se...@gmail.com>.
On 6 March 2017 at 18:20, Rob Tompkins <ch...@gmail.com> wrote:
>
>
>> On Mar 6, 2017, at 11:54 AM, sebb <se...@gmail.com> wrote:
>>
>>> On 5 March 2017 at 04:05,  <ch...@apache.org> wrote:
>>> Updated RELEASE-NOTES.txt in preparation for 1.0 release
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/bfdd0aa8
>>> Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/bfdd0aa8
>>> Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/bfdd0aa8
>>>
>>> Branch: refs/heads/release
>>> Commit: bfdd0aa8f794cfcecfd07aa9e506412ba914375a
>>> Parents: 85a247b
>>> Author: Rob Tompkins <ch...@apache.org>
>>> Authored: Sat Mar 4 22:54:52 2017 -0500
>>> Committer: Rob Tompkins <ch...@apache.org>
>>> Committed: Sat Mar 4 22:54:52 2017 -0500
>>>
>>> ----------------------------------------------------------------------
>>> RELEASE-NOTES.txt | 42 +++++++++++++++++++++++++++++++++++++++---
>>> 1 file changed, 39 insertions(+), 3 deletions(-)
>>> ----------------------------------------------------------------------
>>>
>>>
>>> http://git-wip-us.apache.org/repos/asf/commons-text/blob/bfdd0aa8/RELEASE-NOTES.txt
>>> ----------------------------------------------------------------------
>>> diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
>>> index 56769a8..5964146 100644
>>> --- a/RELEASE-NOTES.txt
>>> +++ b/RELEASE-NOTES.txt
>>> @@ -1,5 +1,5 @@
>>>                           Apache Commons Text
>>> -                           Version 1.0-beta-1
>>> +                              Version 1.0
>>>                              Release Notes
>>>
>>>
>>> @@ -13,6 +13,42 @@ Java environment.
>>>
>>> Apache Commons Text is a library focused on algorithms working on strings.
>>>
>>> +
>>> +INCOMPATIBLE CHANGES
>>> +====================
>>> +
>>> +All package names changed from org.apache.commons.text.beta in 1.0-beta-1 to
>>> +org.apache.commons.text in 1.0.
>>> +
>>> +Methods StringEscapeUtils#escapeHtml3Once and StringEscapeUtils#escapeHtml4Once
>>> +have been removed; see TEXT-40
>>> +
>>> +JAVA 9 SUPPORT
>>> +==============
>>> +
>>> +At our time of release of 1.0-beta-1, our build succeeds with Java 9-ea build 158,
>>
>> That should be 1.0
>
> Thanks for that catch. You think I should re-build the release candidate? Feels like it.

I don't have a view on that. Mistakes happen. It can be mentioned in
the Announce and fixed on the download site.

In any case, I would wait in case other issues are found.

> -Rob
>
>>
>>> +and we believe all of our features to be Java 9 compatible. However, when we run
>>> +"mvn clean site" we have failures.
>>> +
>>> +FIXED BUGS
>>> +==========
>>> +
>>> +o TEXT-64:   Investigate locale issue in ExtendedMessageFormatTest. Thanks to
>>> +             chtompki.
>>> +o TEXT-69:   Resolve PMD/CMD Violations
>>> +o TEXT-65:   Fixing the 200 checkstyle errors present in 1.0-beta-1.
>>> +o TEXT-63:   Mutable fields should be private.
>>> +
>>> +REMOVED
>>> +=======
>>> +
>>> +o TEXT-40:   Escape HTML characters only once: revert.
>>> +
>>> +
>>> +
>>> +                        Release Notes for version 1.0-beta-1
>>> +
>>> +
>>> A NOTE ON THE HISTORY OF THE CODE
>>> =================================
>>>
>>> @@ -28,8 +64,8 @@ Lang into Commons Text.
>>> JAVA 9 SUPPORT
>>> ==============
>>>
>>> -At our time of release our build succeeds with Java 9-ea build 153, and we
>>> -believe all of our features to be Java 9 compatible.
>>> +At our time of release of 1.0-beta-1, our build succeeds with Java 9-ea build 153,
>>> +and we believe all of our features to be Java 9 compatible.
>>>
>>> NEW FEATURES
>>> ============
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [4/7] [text] Updated RELEASE-NOTES.txt in preparation for 1.0 release

Posted by Rob Tompkins <ch...@gmail.com>.

> On Mar 6, 2017, at 11:54 AM, sebb <se...@gmail.com> wrote:
> 
>> On 5 March 2017 at 04:05,  <ch...@apache.org> wrote:
>> Updated RELEASE-NOTES.txt in preparation for 1.0 release
>> 
>> 
>> Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/bfdd0aa8
>> Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/bfdd0aa8
>> Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/bfdd0aa8
>> 
>> Branch: refs/heads/release
>> Commit: bfdd0aa8f794cfcecfd07aa9e506412ba914375a
>> Parents: 85a247b
>> Author: Rob Tompkins <ch...@apache.org>
>> Authored: Sat Mar 4 22:54:52 2017 -0500
>> Committer: Rob Tompkins <ch...@apache.org>
>> Committed: Sat Mar 4 22:54:52 2017 -0500
>> 
>> ----------------------------------------------------------------------
>> RELEASE-NOTES.txt | 42 +++++++++++++++++++++++++++++++++++++++---
>> 1 file changed, 39 insertions(+), 3 deletions(-)
>> ----------------------------------------------------------------------
>> 
>> 
>> http://git-wip-us.apache.org/repos/asf/commons-text/blob/bfdd0aa8/RELEASE-NOTES.txt
>> ----------------------------------------------------------------------
>> diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
>> index 56769a8..5964146 100644
>> --- a/RELEASE-NOTES.txt
>> +++ b/RELEASE-NOTES.txt
>> @@ -1,5 +1,5 @@
>>                           Apache Commons Text
>> -                           Version 1.0-beta-1
>> +                              Version 1.0
>>                              Release Notes
>> 
>> 
>> @@ -13,6 +13,42 @@ Java environment.
>> 
>> Apache Commons Text is a library focused on algorithms working on strings.
>> 
>> +
>> +INCOMPATIBLE CHANGES
>> +====================
>> +
>> +All package names changed from org.apache.commons.text.beta in 1.0-beta-1 to
>> +org.apache.commons.text in 1.0.
>> +
>> +Methods StringEscapeUtils#escapeHtml3Once and StringEscapeUtils#escapeHtml4Once
>> +have been removed; see TEXT-40
>> +
>> +JAVA 9 SUPPORT
>> +==============
>> +
>> +At our time of release of 1.0-beta-1, our build succeeds with Java 9-ea build 158,
> 
> That should be 1.0

Thanks for that catch. You think I should re-build the release candidate? Feels like it. 

-Rob

> 
>> +and we believe all of our features to be Java 9 compatible. However, when we run
>> +"mvn clean site" we have failures.
>> +
>> +FIXED BUGS
>> +==========
>> +
>> +o TEXT-64:   Investigate locale issue in ExtendedMessageFormatTest. Thanks to
>> +             chtompki.
>> +o TEXT-69:   Resolve PMD/CMD Violations
>> +o TEXT-65:   Fixing the 200 checkstyle errors present in 1.0-beta-1.
>> +o TEXT-63:   Mutable fields should be private.
>> +
>> +REMOVED
>> +=======
>> +
>> +o TEXT-40:   Escape HTML characters only once: revert.
>> +
>> +
>> +
>> +                        Release Notes for version 1.0-beta-1
>> +
>> +
>> A NOTE ON THE HISTORY OF THE CODE
>> =================================
>> 
>> @@ -28,8 +64,8 @@ Lang into Commons Text.
>> JAVA 9 SUPPORT
>> ==============
>> 
>> -At our time of release our build succeeds with Java 9-ea build 153, and we
>> -believe all of our features to be Java 9 compatible.
>> +At our time of release of 1.0-beta-1, our build succeeds with Java 9-ea build 153,
>> +and we believe all of our features to be Java 9 compatible.
>> 
>> NEW FEATURES
>> ============
>> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org