You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Charles Reiss <wo...@gmail.com> on 2011/11/03 00:16:55 UTC
Re: Review Request: include more header files in tests/process_spawn.cpp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2663/
-----------------------------------------------------------
(Updated 2011-11-02 23:16:55.919606)
Review request for mesos.
Summary (updated)
-------
Currently, tests/process_spawn.cpp uses INT_MAX but only includes <iostream> which is not gaurenteed (and apparently does not on some systems) to define INT_MAX, causing a compilation error.
This addresses bug MESOS-37.
https://issues.apache.org/jira/browse/MESOS-37
Diffs
-----
src/tests/process_spawn.cpp 4f60296
Diff: https://reviews.apache.org/r/2663/diff
Testing
-------
Thanks,
Charles
Re: Review Request: include more header files in tests/process_spawn.cpp
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2663/#review3222
-----------------------------------------------------------
src/tests/process_spawn.cpp
<https://reviews.apache.org/r/2663/#comment7174>
For posterity: we've tried to keep the ordering consistent in the code base.
C headers
C++ headers
Project headers (i.e., those that use "" instead of <>).
- Benjamin
On 2011-11-02 23:16:55, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2663/
> -----------------------------------------------------------
>
> (Updated 2011-11-02 23:16:55)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> Currently, tests/process_spawn.cpp uses INT_MAX but only includes <iostream> which is not gaurenteed (and apparently does not on some systems) to define INT_MAX, causing a compilation error.
>
>
> This addresses bug MESOS-37.
> https://issues.apache.org/jira/browse/MESOS-37
>
>
> Diffs
> -----
>
> src/tests/process_spawn.cpp 4f60296
>
> Diff: https://reviews.apache.org/r/2663/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: include more header files in tests/process_spawn.cpp
Posted by Andy Konwinski <an...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2663/#review3152
-----------------------------------------------------------
Ship it!
Looks great, thanks Charles!
- Andy
On 2011-11-02 23:16:55, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2663/
> -----------------------------------------------------------
>
> (Updated 2011-11-02 23:16:55)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> Currently, tests/process_spawn.cpp uses INT_MAX but only includes <iostream> which is not gaurenteed (and apparently does not on some systems) to define INT_MAX, causing a compilation error.
>
>
> This addresses bug MESOS-37.
> https://issues.apache.org/jira/browse/MESOS-37
>
>
> Diffs
> -----
>
> src/tests/process_spawn.cpp 4f60296
>
> Diff: https://reviews.apache.org/r/2663/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>