You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/03/01 11:25:08 UTC
[GitHub] [bookkeeper] codecov-commenter commented on pull request #3827: clean code: remove unused comment
codecov-commenter commented on PR #3827:
URL: https://github.com/apache/bookkeeper/pull/3827#issuecomment-1449938037
# [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3827?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3827](https://codecov.io/gh/apache/bookkeeper/pull/3827?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28ed53c) into [master](https://codecov.io/gh/apache/bookkeeper/commit/a96317e3537abff1d5759356ee27fc1044740f44?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a96317e) will **decrease** coverage by `7.90%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3827 +/- ##
============================================
- Coverage 68.35% 60.46% -7.90%
+ Complexity 6757 5855 -902
============================================
Files 473 473
Lines 40963 40963
Branches 5241 5241
============================================
- Hits 28002 24768 -3234
- Misses 10706 13979 +3273
+ Partials 2255 2216 -39
```
| Flag | Coverage Δ | |
|---|---|---|
| bookie | `39.99% <ø> (+0.05%)` | :arrow_up: |
| client | `?` | |
| remaining | `29.58% <ø> (-0.05%)` | :arrow_down: |
| replication | `41.34% <ø> (-0.08%)` | :arrow_down: |
| tls | `21.03% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/bookkeeper/pull/3827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/bookkeeper/bookie/BookieImpl.java](https://codecov.io/gh/apache/bookkeeper/pull/3827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL0Jvb2tpZUltcGwuamF2YQ==) | `70.00% <ø> (-1.25%)` | :arrow_down: |
| [...a/org/apache/bookkeeper/client/api/BookKeeper.java](https://codecov.io/gh/apache/bookkeeper/pull/3827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L2FwaS9Cb29rS2VlcGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../bookkeeper/proto/checksum/DummyDigestManager.java](https://codecov.io/gh/apache/bookkeeper/pull/3827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vY2hlY2tzdW0vRHVtbXlEaWdlc3RNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...okkeeper/client/BookieAddressResolverDisabled.java](https://codecov.io/gh/apache/bookkeeper/pull/3827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L0Jvb2tpZUFkZHJlc3NSZXNvbHZlckRpc2FibGVkLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...keeper/proto/ReadLastConfirmedAndEntryContext.java](https://codecov.io/gh/apache/bookkeeper/pull/3827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vUmVhZExhc3RDb25maXJtZWRBbmRFbnRyeUNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...kkeeper/client/impl/LastConfirmedAndEntryImpl.java](https://codecov.io/gh/apache/bookkeeper/pull/3827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L2ltcGwvTGFzdENvbmZpcm1lZEFuZEVudHJ5SW1wbC5qYXZh) | `0.00% <0.00%> (-95.84%)` | :arrow_down: |
| [...per/client/DynamicWeightedRandomSelectionImpl.java](https://codecov.io/gh/apache/bookkeeper/pull/3827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L0R5bmFtaWNXZWlnaHRlZFJhbmRvbVNlbGVjdGlvbkltcGwuamF2YQ==) | `0.00% <0.00%> (-92.07%)` | :arrow_down: |
| [...kkeeper/client/DefaultEnsemblePlacementPolicy.java](https://codecov.io/gh/apache/bookkeeper/pull/3827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L0RlZmF1bHRFbnNlbWJsZVBsYWNlbWVudFBvbGljeS5qYXZh) | `0.00% <0.00%> (-87.81%)` | :arrow_down: |
| [...per/client/RegionAwareEnsemblePlacementPolicy.java](https://codecov.io/gh/apache/bookkeeper/pull/3827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L1JlZ2lvbkF3YXJlRW5zZW1ibGVQbGFjZW1lbnRQb2xpY3kuamF2YQ==) | `0.00% <0.00%> (-81.70%)` | :arrow_down: |
| [...a/org/apache/bookkeeper/client/UpdateLedgerOp.java](https://codecov.io/gh/apache/bookkeeper/pull/3827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L1VwZGF0ZUxlZGdlck9wLmphdmE=) | `0.00% <0.00%> (-78.27%)` | :arrow_down: |
| ... and [122 more](https://codecov.io/gh/apache/bookkeeper/pull/3827?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org