You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by "juergbi (via GitHub)" <gi...@apache.org> on 2025/11/02 18:18:38 UTC
[PR] Drop support for Python 3.9 [buildstream]
juergbi opened a new pull request, #2085:
URL: https://github.com/apache/buildstream/pull/2085
Python 3.9 is no longer maintained upstream and at least one Python package (Click) has dropped support for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Drop support for Python 3.9 [buildstream]
Posted by "juergbi (via GitHub)" <gi...@apache.org>.
juergbi commented on code in PR #2085:
URL: https://github.com/apache/buildstream/pull/2085#discussion_r2486128588
##########
pyproject.toml:
##########
@@ -53,10 +53,11 @@ environment = { BST_BUNDLE_BUILDBOX = "1" }
manylinux-x86_64-image = "manylinux_2_28"
skip = [
- # BuildStream supports Python >= 3.9
+ # BuildStream supports Python >= 3.10
Review Comment:
The best way would be to migrate project metadata to `pyproject.toml`. However, if I remember correctly, it's not possible to add `[project]` with a single field such as `requires-python` and leave everything else as is. We'd have to migrate all the project metadata over from `setup.py`. While that would be nice, it may be a bit more work and should be a separate PR (I'm not sure whether we could keep the non-metadata parts of `setup.py` as is).
However, it does seem reasonable to replace part of the `skip` list with `project-requires-python`. I'll give this a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Drop support for Python 3.9 [buildstream]
Posted by "juergbi (via GitHub)" <gi...@apache.org>.
juergbi commented on code in PR #2085:
URL: https://github.com/apache/buildstream/pull/2085#discussion_r2486247001
##########
pyproject.toml:
##########
@@ -53,10 +53,11 @@ environment = { BST_BUNDLE_BUILDBOX = "1" }
manylinux-x86_64-image = "manylinux_2_28"
skip = [
- # BuildStream supports Python >= 3.9
+ # BuildStream supports Python >= 3.10
Review Comment:
`project-requires-python` can't be set in `pyproject.toml`, unfortunately. I had to set `python_requires` in `setup.cfg` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Drop support for Python 3.9 [buildstream]
Posted by "juergbi (via GitHub)" <gi...@apache.org>.
juergbi merged PR #2085:
URL: https://github.com/apache/buildstream/pull/2085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Drop support for Python 3.9 [buildstream]
Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim commented on code in PR #2085:
URL: https://github.com/apache/buildstream/pull/2085#discussion_r2486395507
##########
pyproject.toml:
##########
@@ -53,10 +53,11 @@ environment = { BST_BUNDLE_BUILDBOX = "1" }
manylinux-x86_64-image = "manylinux_2_28"
skip = [
- # BuildStream supports Python >= 3.9
+ # BuildStream supports Python >= 3.10
Review Comment:
I think I have a wip branch for migrating to pyproject.toml. We can probably land it and build on it, I'll send a pull request later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Drop support for Python 3.9 [buildstream]
Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim commented on code in PR #2085:
URL: https://github.com/apache/buildstream/pull/2085#discussion_r2486075947
##########
pyproject.toml:
##########
@@ -53,10 +53,11 @@ environment = { BST_BUNDLE_BUILDBOX = "1" }
manylinux-x86_64-image = "manylinux_2_28"
skip = [
- # BuildStream supports Python >= 3.9
+ # BuildStream supports Python >= 3.10
Review Comment:
I wonder if we could set `requires-python` above and not have to update this list every time we bump the dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org