[Bug 8078] Shortcircuiting does not work as expected

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8078

--- Comment #3 from Henrik Krohns <ap...@hege.li> ---
There is nothing mysterious about this issue.

Original complaint was that shortcircuiting RCVD_IN_VALIDITY_CERTIFIED results
in MISSING_* rules hitting.

If you look at the MISSING_* rules, they are just dumb metas referring to
various exists: rules.

meta MISSING_FROM              !__HAS_FROM
header    __HAS_FROM              exists:From

Network rules are run at -100 priority, so if they receive a quick response and
shortcircuiting is activated, rules like __HAS_FROM are not even run yet since
default rule priority 0 is not reached.

Since we decided to let meta rules evaluate with unrun dependencies, everything
works as designed.

Logical fix is to adjust priority for all commonly referred rules in metas.
Lowest priority seen in stock ruleset is -1000, for example shortcircuiting
USER_IN_WELCOMELIST has the same effect. So __HAS_FROM and others need to be
set at -2000 for example. This requires no code commits, only rule changes,
I'll change the necessary ones.

-- 
You are receiving this mail because:
You are the assignee for the bug.