You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/01/23 07:08:18 UTC
[GitHub] [guacamole-client] mike-jumper opened a new pull request #465:
GUACAMOLE-937: Return null on bindAs() failures. Rely on caller to
interpret and handle failures.
mike-jumper opened a new pull request #465: GUACAMOLE-937: Return null on bindAs() failures. Rely on caller to interpret and handle failures.
URL: https://github.com/apache/guacamole-client/pull/465
Throwing `GuacamoleInvalidCredentialsException` breaks separation of concerns (`bindAs()` shouldn't assume that it's being used during login and that credentials given are the Guacamole user's credentials), and has unintended side effects (throwing subclasses of `GuacamoleUnauthorizedException` causes implicit session invalidation).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] necouchman commented on issue #465:
GUACAMOLE-937: Return null on bindAs() failures. Rely on caller to
interpret and handle failures.
Posted by GitBox <gi...@apache.org>.
necouchman commented on issue #465: GUACAMOLE-937: Return null on bindAs() failures. Rely on caller to interpret and handle failures.
URL: https://github.com/apache/guacamole-client/pull/465#issuecomment-578021919
Cool. Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] mike-jumper commented on issue #465:
GUACAMOLE-937: Return null on bindAs() failures. Rely on caller to
interpret and handle failures.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on issue #465: GUACAMOLE-937: Return null on bindAs() failures. Rely on caller to interpret and handle failures.
URL: https://github.com/apache/guacamole-client/pull/465#issuecomment-577534924
I've marked this as a draft as I've intentionally based it off the change from #464, as it would otherwise conflict.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] mike-jumper commented on issue #465:
GUACAMOLE-937: Return null on bindAs() failures. Rely on caller to
interpret and handle failures.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on issue #465: GUACAMOLE-937: Return null on bindAs() failures. Rely on caller to interpret and handle failures.
URL: https://github.com/apache/guacamole-client/pull/465#issuecomment-578020667
I'll rebase to latest to avoid the duplicate commit there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] necouchman merged pull request #465:
GUACAMOLE-937: Return null on bindAs() failures. Rely on caller to
interpret and handle failures.
Posted by GitBox <gi...@apache.org>.
necouchman merged pull request #465: GUACAMOLE-937: Return null on bindAs() failures. Rely on caller to interpret and handle failures.
URL: https://github.com/apache/guacamole-client/pull/465
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] mike-jumper commented on issue #465:
GUACAMOLE-937: Return null on bindAs() failures. Rely on caller to
interpret and handle failures.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on issue #465: GUACAMOLE-937: Return null on bindAs() failures. Rely on caller to interpret and handle failures.
URL: https://github.com/apache/guacamole-client/pull/465#issuecomment-578021417
There. Back to having one commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services