[GitHub] [zeppelin] rickchengx commented on a change in pull request #4174: [ZEPPELIN-5442] Allow users to set a separate namespace for the interpreter

[GitBox <gi...@apache.org>]

rickchengx commented on a change in pull request #4174:
URL: https://github.com/apache/zeppelin/pull/4174#discussion_r685626738



##########
File path: k8s/zeppelin-server.yaml
##########
@@ -213,14 +213,15 @@ rules:
   resources: ["roles", "rolebindings"]
   verbs: ["bind", "create", "get", "update", "patch", "list", "delete", "watch"]
 ---
-kind: RoleBinding
+kind: ClusterRoleBinding
 apiVersion: rbac.authorization.k8s.io/v1
 metadata:
   name: zeppelin-server-role-binding
 subjects:
 - kind: ServiceAccount
   name: zeppelin-server
+  namespace: default

Review comment:
       Yes, the namespace of zeppelin server is not sure. But the `clusterrolebinding` needs to specify the namespace of the service account, which is applied by user when user is creating the zeppelin server in k8s.
   
   So if user does not apply the `zeppelin-server` in the default namespace, he also needs to modify this `namespace` field in the `clusterrolebinding`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org