You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "phet (via GitHub)" <gi...@apache.org> on 2023/11/22 21:11:38 UTC
[PR] Prevent NPE in `FlowCompilationValidationHelper.validateAndHandleConcurrentExecution` [gobblin]
phet opened a new pull request, #3836:
URL: https://github.com/apache/gobblin/pull/3836
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
Flow compilation failures currently result in an NPE:
```
java.lang.NullPointerException: null
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:770) ~[guava-21.0.jar:?]
at com.google.common.base.Optional.of(Optional.java:105) ~[guava-21.0.jar:?]
at org.apache.gobblin.service.modules.utils.FlowCompilationValidationHelper.validateAndHandleConcurrentExecution(FlowCompilationValidationHelper.java:114) ~[gobblin-service-0.18.0-dev-483.jar:?]
at org.apache.gobblin.service.modules.orchestration.Orchestrator.orchestrate(Orchestrator.java:240) ~[gobblin-service-0.18.0-dev-483.jar:?]
...
```
Prevent this by using (guava) `Optional.fromNullable` rather than `Optional.of`, which does not permit nulls
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
existing unit tests
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prevent NPE in `FlowCompilationValidationHelper.validateAndHandleConcurrentExecution` [gobblin]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3836:
URL: https://github.com/apache/gobblin/pull/3836#issuecomment-1823616117
## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3836?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`97e8459`)](https://app.codecov.io/gh/apache/gobblin/commit/97e845915b9374d82791b3782e4279531df429f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 47.55% compared to head [(`01ae551`)](https://app.codecov.io/gh/apache/gobblin/pull/3836?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 45.99%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3836 +/- ##
============================================
- Coverage 47.55% 45.99% -1.57%
+ Complexity 11041 2178 -8863
============================================
Files 2157 416 -1741
Lines 85400 17984 -67416
Branches 9491 2194 -7297
============================================
- Hits 40613 8271 -32342
+ Misses 41090 8828 -32262
+ Partials 3697 885 -2812
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3836?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prevent NPE in `FlowCompilationValidationHelper.validateAndHandleConcurrentExecution` [gobblin]
Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo merged PR #3836:
URL: https://github.com/apache/gobblin/pull/3836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org