You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2011/06/10 07:26:59 UTC

[jira] [Commented] (HBASE-3963) Schedule all log-spliiting at startup all at once

    [ https://issues.apache.org/jira/browse/HBASE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047003#comment-13047003 ] 

stack commented on HBASE-3963:
------------------------------

@Mingjian The patch looks good to me (Did you test it?).  You do not have the same tab spacing as the surrounding code (two spaces for a tab not the four or tab character you have).  A bunch of your patch is just white space changes.  In future try and keep the formatting of surrounding code.

> Schedule all log-spliiting at startup all at once
> -------------------------------------------------
>
>                 Key: HBASE-3963
>                 URL: https://issues.apache.org/jira/browse/HBASE-3963
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>         Attachments: schedule-all-splitlog.patch
>
>
> When distributed log splitting is enabled then it is better to call splitLog() for all region servers simultaneously. A large number of splitlog tasks will get scheduled - one for each log file. But a splitlog-worker (region server) executes only one task at a time and there shouldn't be a danger of DFS overload. Scheduling all the tasks at once ensures maximum parallelism.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira