You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "garydgregory (via GitHub)" <gi...@apache.org> on 2025/11/03 16:56:10 UTC

[PR] Lang 1786 dont write to the console [commons-lang]

garydgregory opened a new pull request, #1481:
URL: https://github.com/apache/commons-lang/pull/1481

   [[LANG-1786] A lot of warnings on the console when using FastDateFormat
   with JDK25](https://issues.apache.org/jira/browse/LANG-1786)
   
   Add and use `TimeZones.getTimeZone(String)` as a way to avoid writing to
   the console on Java 25:
   ```java
       /**
        * Delegates to {@link TimeZone#getTimeZone(String)} with special behavior on Java 25.
        * <p>
        * On Java 25, this methods temporarily disables writing warnings to the system error stream. On Java before 25, this method delegates to
        * {@link TimeZone#getTimeZone(String)}.
        * </p>
        * <p>
        * On Java 25, this message is of the form:
        * </p>
        *
        * <pre>
        * WARNING: Use of the three-letter time zone ID "the-given-id" is deprecated and it will be removed in a future release
        * </pre>
        *
        * @param id Same as {@link TimeZone#getTimeZone(String)}.
        * @return Same as {@link TimeZone#getTimeZone(String)}.
        * @since 3.20.0
        */
       public static synchronized TimeZone getTimeZone(final String id) {
   ```
   
   Before you push a pull request, review this list:
   
   - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI).
   - [ ] I used AI to create any part of, or all of, this pull request.
   - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
   - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Lang 1786 dont write to the console [commons-lang]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1481:
URL: https://github.com/apache/commons-lang/pull/1481#issuecomment-3481557591

   This is an alternative to https://github.com/apache/commons-lang/pull/1480 that doesn't break compatibility.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [LANG-1786] Don't write to the console when getting a TimeZone [commons-lang]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1481:
URL: https://github.com/apache/commons-lang/pull/1481#issuecomment-3503552681

   Closing in favor of [LANG-1786] Map deprecated TimeZone short IDs and avoid JRE WARNINGs to the console #1483


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [LANG-1786] Don't write to the console when getting a TimeZone [commons-lang]

Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1481:
URL: https://github.com/apache/commons-lang/pull/1481#issuecomment-3482596336

   Let me see what I can do with #1480 and see what you think. Probably tomorrow


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [LANG-1786] Don't write to the console when getting a TimeZone [commons-lang]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1481:
URL: https://github.com/apache/commons-lang/pull/1481#issuecomment-3496519318

   I'll probably close this PR in favor of https://github.com/apache/commons-lang/pull/1482
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [LANG-1786] Don't write to the console when getting a TimeZone [commons-lang]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1481:
URL: https://github.com/apache/commons-lang/pull/1481#issuecomment-3482574266

   That is indeed a concern in theory but I'm not sure how it would play out in practice.
   
   An alternative is to use the same new API (TimeZones.getTImeZone()) and cache TimeZone's for short IDs such the message is only logged once per call for that ID. That feels less hacky even though TimeZone objects are already cached in the JRE.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [LANG-1786] Don't write to the console when getting a TimeZone [commons-lang]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #1481: [LANG-1786] Don't write to the console when getting a TimeZone
URL: https://github.com/apache/commons-lang/pull/1481


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [LANG-1786] Don't write to the console when getting a TimeZone [commons-lang]

Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1481:
URL: https://github.com/apache/commons-lang/pull/1481#issuecomment-3482482379

   Oh boy. While this is a valiant effort... I think System.setErr() could lead to much worse issues, like loss of legitimate logs from another thread.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org