You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by John Roesler <vv...@apache.org> on 2020/07/04 17:16:53 UTC
Re: [VOTE] KIP-418: A method-chaining way to branch KStream
Hi Ivan,
Congratulations! It looks like you have 3 binding and 2 non-binding votes, so you can announce this KIP as accepted and follow up with a PR.
Thanks,
John
On Mon, Jun 29, 2020, at 20:46, Bill Bejeck wrote:
> Thanks for the KIP Ivan, +1 (binding).
>
> -Bill
>
> On Mon, Jun 29, 2020 at 7:22 PM Guozhang Wang <wa...@gmail.com> wrote:
>
> > +1 (binding). Thanks Ivan!
> >
> >
> > Guozhang
> >
> > On Mon, Jun 29, 2020 at 3:55 AM Jorge Esteban Quilcate Otoya <
> > quilcate.jorge@gmail.com> wrote:
> >
> > > This will be a great addition. Thanks Ivan!
> > >
> > > +1 (non-binding)
> > >
> > > On Fri, Jun 26, 2020 at 7:07 PM John Roesler <vv...@apache.org>
> > wrote:
> > >
> > > > Thanks, Ivan!
> > > >
> > > > I’m +1 (binding)
> > > >
> > > > -John
> > > >
> > > > On Thu, May 28, 2020, at 17:24, Ivan Ponomarev wrote:
> > > > > Hello all!
> > > > >
> > > > > I'd like to start the vote for KIP-418 which proposes deprecation of
> > > > > current `branch` method and provides a method-chaining based API for
> > > > > branching.
> > > > >
> > > > >
> > > >
> > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-418%3A+A+method-chaining+way+to+branch+KStream
> > > > >
> > > > > Regards,
> > > > >
> > > > > Ivan
> > > > >
> > > >
> > >
> >
> >
> > --
> > -- Guozhang
> >
>
Re: [VOTE] KIP-418: A method-chaining way to branch KStream
Posted by Ivan Ponomarev <ip...@mail.ru.INVALID>.
Hello everyone,
this is to warn that actual implementation of KIP-418 differs with the
approved specification in two points:
1. Instead of multiple overloaded variants of Branched.with we now have
Branched.withFunction (for functions) and Branched.withConsumer (for
consumers). This is because of compiler warnings about overloading:
Function and Consumer are indistinguishable for Java compiler when
supplied as lambdas, and thus we need to name methods differently.
2. 'Fully covariant' signatures like Consumer<? super KStream<? super K,
? super V>> don't work as expected. Using Consumer<? super KStream<K,
V>> etc. instead
I have updated the KIP.
Does anyone want to object these changes?
Regards,
Ivan
06.07.2020 21:43, Matthias J. Sax пишет:
> I am late, but I am also +1 (binding).
>
> -Matthias
>
> On 7/6/20 2:16 AM, Ivan Ponomarev wrote:
>> Wow!
>>
>> So excited to hear that!
>>
>> Thanks for your collaboration, now it's my turn to write a PR.
>>
>> Regards,
>>
>> Ivan
>>
>> 04.07.2020 20:16, John Roesler пишет:
>>> Hi Ivan,
>>>
>>> Congratulations! It looks like you have 3 binding and 2 non-binding
>>> votes, so you can announce this KIP as accepted and follow up with a PR.
>>>
>>> Thanks,
>>> John
>>>
>>> On Mon, Jun 29, 2020, at 20:46, Bill Bejeck wrote:
>>>> Thanks for the KIP Ivan, +1 (binding).
>>>>
>>>> -Bill
>>>>
>>>> On Mon, Jun 29, 2020 at 7:22 PM Guozhang Wang <wa...@gmail.com>
>>>> wrote:
>>>>
>>>>> +1 (binding). Thanks Ivan!
>>>>>
>>>>>
>>>>> Guozhang
>>>>>
>>>>> On Mon, Jun 29, 2020 at 3:55 AM Jorge Esteban Quilcate Otoya <
>>>>> quilcate.jorge@gmail.com> wrote:
>>>>>
>>>>>> This will be a great addition. Thanks Ivan!
>>>>>>
>>>>>> +1 (non-binding)
>>>>>>
>>>>>> On Fri, Jun 26, 2020 at 7:07 PM John Roesler <vv...@apache.org>
>>>>> wrote:
>>>>>>
>>>>>>> Thanks, Ivan!
>>>>>>>
>>>>>>> I’m +1 (binding)
>>>>>>>
>>>>>>> -John
>>>>>>>
>>>>>>> On Thu, May 28, 2020, at 17:24, Ivan Ponomarev wrote:
>>>>>>>> Hello all!
>>>>>>>>
>>>>>>>> I'd like to start the vote for KIP-418 which proposes deprecation of
>>>>>>>> current `branch` method and provides a method-chaining based API for
>>>>>>>> branching.
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-418%3A+A+method-chaining+way+to+branch+KStream
>>>>>
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>>
>>>>>>>> Ivan
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> -- Guozhang
>>>>>
>>>>
>>
>
Re: [VOTE] KIP-418: A method-chaining way to branch KStream
Posted by "Matthias J. Sax" <mj...@apache.org>.
I am late, but I am also +1 (binding).
-Matthias
On 7/6/20 2:16 AM, Ivan Ponomarev wrote:
> Wow!
>
> So excited to hear that!
>
> Thanks for your collaboration, now it's my turn to write a PR.
>
> Regards,
>
> Ivan
>
> 04.07.2020 20:16, John Roesler пишет:
>> Hi Ivan,
>>
>> Congratulations! It looks like you have 3 binding and 2 non-binding
>> votes, so you can announce this KIP as accepted and follow up with a PR.
>>
>> Thanks,
>> John
>>
>> On Mon, Jun 29, 2020, at 20:46, Bill Bejeck wrote:
>>> Thanks for the KIP Ivan, +1 (binding).
>>>
>>> -Bill
>>>
>>> On Mon, Jun 29, 2020 at 7:22 PM Guozhang Wang <wa...@gmail.com>
>>> wrote:
>>>
>>>> +1 (binding). Thanks Ivan!
>>>>
>>>>
>>>> Guozhang
>>>>
>>>> On Mon, Jun 29, 2020 at 3:55 AM Jorge Esteban Quilcate Otoya <
>>>> quilcate.jorge@gmail.com> wrote:
>>>>
>>>>> This will be a great addition. Thanks Ivan!
>>>>>
>>>>> +1 (non-binding)
>>>>>
>>>>> On Fri, Jun 26, 2020 at 7:07 PM John Roesler <vv...@apache.org>
>>>> wrote:
>>>>>
>>>>>> Thanks, Ivan!
>>>>>>
>>>>>> I’m +1 (binding)
>>>>>>
>>>>>> -John
>>>>>>
>>>>>> On Thu, May 28, 2020, at 17:24, Ivan Ponomarev wrote:
>>>>>>> Hello all!
>>>>>>>
>>>>>>> I'd like to start the vote for KIP-418 which proposes deprecation of
>>>>>>> current `branch` method and provides a method-chaining based API for
>>>>>>> branching.
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-418%3A+A+method-chaining+way+to+branch+KStream
>>>>
>>>>>>>
>>>>>>> Regards,
>>>>>>>
>>>>>>> Ivan
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> -- Guozhang
>>>>
>>>
>
Re: [VOTE] KIP-418: A method-chaining way to branch KStream
Posted by Ivan Ponomarev <ip...@mail.ru.INVALID>.
Wow!
So excited to hear that!
Thanks for your collaboration, now it's my turn to write a PR.
Regards,
Ivan
04.07.2020 20:16, John Roesler пишет:
> Hi Ivan,
>
> Congratulations! It looks like you have 3 binding and 2 non-binding votes, so you can announce this KIP as accepted and follow up with a PR.
>
> Thanks,
> John
>
> On Mon, Jun 29, 2020, at 20:46, Bill Bejeck wrote:
>> Thanks for the KIP Ivan, +1 (binding).
>>
>> -Bill
>>
>> On Mon, Jun 29, 2020 at 7:22 PM Guozhang Wang <wa...@gmail.com> wrote:
>>
>>> +1 (binding). Thanks Ivan!
>>>
>>>
>>> Guozhang
>>>
>>> On Mon, Jun 29, 2020 at 3:55 AM Jorge Esteban Quilcate Otoya <
>>> quilcate.jorge@gmail.com> wrote:
>>>
>>>> This will be a great addition. Thanks Ivan!
>>>>
>>>> +1 (non-binding)
>>>>
>>>> On Fri, Jun 26, 2020 at 7:07 PM John Roesler <vv...@apache.org>
>>> wrote:
>>>>
>>>>> Thanks, Ivan!
>>>>>
>>>>> I’m +1 (binding)
>>>>>
>>>>> -John
>>>>>
>>>>> On Thu, May 28, 2020, at 17:24, Ivan Ponomarev wrote:
>>>>>> Hello all!
>>>>>>
>>>>>> I'd like to start the vote for KIP-418 which proposes deprecation of
>>>>>> current `branch` method and provides a method-chaining based API for
>>>>>> branching.
>>>>>>
>>>>>>
>>>>>
>>>>
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-418%3A+A+method-chaining+way+to+branch+KStream
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> Ivan
>>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> -- Guozhang
>>>
>>