[GitHub] [pinot] walterddr commented on a diff in pull request #9887: [multistage] improved task scheduling

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9887:
URL: https://github.com/apache/pinot/pull/9887#discussion_r1037538646


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/InMemoryMailboxService.java:
##########
@@ -22,22 +22,25 @@
 import java.util.concurrent.ArrayBlockingQueue;
 import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.ConcurrentHashMap;
+import java.util.function.Consumer;
 import org.apache.pinot.query.runtime.blocks.TransferableBlock;
 
 
 public class InMemoryMailboxService implements MailboxService<TransferableBlock> {
   // channel manager
   private final String _hostname;
   private final int _mailboxPort;
+  private final Consumer<MailboxIdentifier> _gotMailCallback;

Review Comment:
   nit: _receivedMailboxContentCallback



##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -165,28 +165,31 @@ private TransferableBlock produceAggregatedBlock() {
    */
   private boolean consumeInputBlocks() {
     TransferableBlock block = _inputOperator.nextBlock();
-    // setting upstream error block
-    if (block.isErrorBlock()) {
-      _upstreamErrorBlock = block;
-      return true;
-    } else if (block.isEndOfStreamBlock()) {
-      _readyToConstruct = true;
-      return true;
-    }
+    while (!block.isNoOpBlock()) {

Review Comment:
   this looks like a tight loop? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org