Re: [jira] Commented: (CAMEL-527) Break dependency cycle between camel and camel.impl

[Hadrian Zbarcea <hz...@gmail.com>]

Hi,

I think this kind of changes have a big impact on other projects using  
camel, such as activemq and servicemix.  Not only code changes are  
required in these projects, but their ability to work with different  
versions of camel.  This has a cascading effect on users of such  
projects who may have to consider updating to camel 1.4 too.

I would suggest asking their opinion in the future before making such  
changes.

My $0.02,
Hadrian


On Jun 4, 2008, at 1:51 AM, Claus Ibsen (JIRA) wrote:

>
>    [ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43212 
> #action_43212 ]
>
> Claus Ibsen commented on CAMEL-527:
> -----------------------------------
>
> Sending        camel-core\src\main\java\org\apache\camel 
> \CamelContext.java
> Sending        camel-core\src\main\java\org\apache\camel 
> \EndpointInject.java
> Sending        camel-core\src\main\java\org\apache\camel\impl 
> \CamelTemplate.java
> Sending        camel-core\src\main\java\org\apache\camel\impl 
> \DefaultCamelContext.java
> Adding         camel-core\src\main\java\org\apache\camel\impl 
> \DefaultProducerTemplate.java
> Sending        camel-core\src\test\java\org\apache\camel 
> \ContextTestSupport.java
> Sending        camel-core\src\test\java\org\apache\camel\component 
> \file\DirectoryCreateIssueTest.java
> Sending        camel-core\src\test\java\org\apache\camel\component\vm 
> \VmRouteTest.java
> Sending        camel-core\src\test\java\org\apache\camel\impl 
> \StringDataFormatTest.java
> Sending        camel-core\src\test\java\org\apache\camel\processor 
> \SetOutBodyTest.java
> Sending        camel-core\src\test\java\org\apache\camel\processor 
> \TryProcessorHandleTest.java
> Sending        camel-core\src\test\java\org\apache\camel\processor 
> \aggregator\AlbertoAggregatorTest.java
> Sending        components\camel-jms\src\test\java\org\apache\camel 
> \component\jms\JmsRouteRequestReplyTest.java
> Transmitting file data .............
> Committed revision 662986.
>
>> Break dependency cycle between camel and camel.impl
>> ---------------------------------------------------
>>
>>                Key: CAMEL-527
>>                URL: https://issues.apache.org/activemq/browse/CAMEL-527
>>            Project: Apache Camel
>>         Issue Type: Improvement
>>         Components: camel-core
>>   Affects Versions: 1.3.0
>>           Reporter: Christian Schneider
>>           Assignee: Hadrian Zbarcea
>>            Fix For: 1.4.0
>>
>>        Attachments: producertemplate.patch, servicehelper.patch
>>
>>  Original Estimate: 3 hours
>> Remaining Estimate: 3 hours
>>
>> Currently there is a dependency cycle between camel and camel.impl.  
>> While I think there is no problem when impl uses camel the other  
>> direction should not occur. Luckily there ist only one case where  
>> this happens. The class CamelTemplate from camel uses  
>> ServiceSupport from impl.
>> As a solution I would suggest to move ServiceSupport and Service to  
>> util. ServiceHelper is already in util and Service as well as  
>> ServiceSupport do not need any other classes. This would help to  
>> break the dependency cycle and at the same time move some classes  
>> out of the already quite big camel package.
>
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>