You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2026/02/08 10:13:05 UTC

[PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

slawekjaranowski opened a new pull request, #3259:
URL: https://github.com/apache/maven-surefire/pull/3259

   - add documentation about planed change
   - allow to disable warnings
   
   ----
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2791466826


##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -2967,6 +2975,7 @@ public boolean isApplicable() {
         @Override
         public void addProviderProperties() throws MojoExecutionException {
             convertTestNGParameters();
+            providerDeprecationWarning("TestNG provider is deprecated, will be removed in future versions of plugin.");

Review Comment:
   technically support will not be removed but only the specific provider code.
   So in fact users do not know they are using this provider as it's added automatically by the plugin.
   I feel strange to add a warning, it looks like telling users TestNG will not be supported anymore which is wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2784291336


##########
maven-surefire-plugin/src/site/markdown/migration355.md.vm:
##########
@@ -0,0 +1,72 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+Migration to 3.5.5 version
+==========================
+
+In the `3.6.x` version of ${thisPlugin} plugin, the removal of providers for `JUnit 3, 4` and `TestNG` is planned,
+so these providers are deprecated in the `3.5.5` version.
+
+If you want to stay on the `3.5.x` version, you can continue to use the `JUnit 3, 4` and `TestNG` providers without any changes,
+but you should be aware that these providers will be removed in the `3.6.x` version.
+
+In the `3.5.5` version of ${thisPlugin} plugin, a warning message will be emitted if you are using the `JUnit 3, 4` or `TestNG` providers.
+You can suppress this warning by setting the parameter `providerDeprecationWarning` to `false`.
+
+You should consider migrating your tests to `JUnit 5`, but if you want to continue using `JUnit 3, 4` or `TestNG`,
+Preparing for next version you can try the instructions below.
+
+**NOTE**: The JUnit engine will be automatically added to your project with `3.6.x` version of ${thisPlugin} plugin,
+so you don't need to add it manually.
+
+JUnit 3 and 4
+-------------
+
+You need to upgrade your `junit` dependencies to version `4.12` or higher (the recommended version is `4.13.2`), and add the `junit-vintage-engine` dependency to your project:

Review Comment:
   `junit-vintage-engine` will be reported as not used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2791457897


##########
maven-surefire-plugin/src/site/markdown/migration355.md.vm:
##########
@@ -0,0 +1,74 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+Migration to 3.5.5 version
+==========================
+
+In the `3.6.x` version of ${thisPlugin} plugin, the removal of providers for `JUnit 3, 4` and `TestNG` is planned,
+so these providers are deprecated in the `3.5.5` version.
+
+If you want to stay on the `3.5.x` version, you can continue to use the `JUnit 3, 4` and `TestNG` providers without any changes,
+but you should be aware that these providers will be removed in the `3.6.x` version.
+
+In the `3.5.5` version of ${thisPlugin} plugin, a warning message will be emitted if you are using the `JUnit 3, 4` or `TestNG` providers.
+You can suppress this warning by setting the parameter `providerDeprecationWarning` to `false`.
+
+You should consider migrating your tests to JUnit 5, but if you want to continue using `JUnit 3, 4` or `TestNG`,
+you can try using the `JUnit Platform` with the appropriate engines for these testing frameworks.
+
+Below are instructions for using the  `JUnit 3, 4` and `TestNG` with `JUnit Platform`.
+
+**NOTE**: The JUnit engine will be automatically added to your project with `3.6.x` version of ${thisPlugin} plugin,
+so you don't need to add it manually.
+
+JUnit 3 and 4
+-------------
+
+You need to upgrade your `junit` dependencies to version `4.12` or higher (the recommended version is `4.13.2`), and add the `junit-vintage-engine` dependency to your project:
+
+```xml
+<dependency>
+    <groupId>junit</groupId>
+    <artifactId>junit</artifactId>
+    <version>4.13.2</version>
+</dependency>
+<dependency>
+    <groupId>org.junit.vintage</groupId>
+    <artifactId>junit-vintage-engine</artifactId>
+    <version>5.14.2</version>
+    <scope>test</scope>
+</dependency>
+```
+Please refer to the documentation for more details [Migrating from JUnit 4](https://docs.junit.org/5.14.2/migrating-from-junit4.html)
+
+TestNG
+------
+
+You need to use the [TestNG Engine for the JUnit Platform](https://github.com/junit-team/testng-engine), so add the `testng-engine` dependency to your project:

Review Comment:
   this will be done automatically as well.
   Not sure we need to document this. except if users need a specific version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2786762575


##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -558,6 +558,21 @@ public class IntegrationTestMojo extends AbstractSurefireMojo {
     @Parameter(property = "failsafe.excludeJUnit5Engines")
     private String[] excludeJUnit5Engines;
 
+    /**
+     * Warning about deprecated providers and features planed to remove in <code>3.6.x</code> plugin version.
+     * <br>
+     *
+     * Set to <code>false</code> to disable the warning if you want to stay on the <code>3.5.x</code> plugin version.
+     * <br>
+     *
+     * See the documentation for more details:<br>
+     * <a href="https://maven.apache.org/surefire/maven-failsafe-plugin/migration355.html">Migration to 3.5.5 version</a>
+     *
+     * @since 3.5.5
+     */
+    @Parameter(property = "failsafe.providerDeprecationWarning", defaultValue = "true")

Review Comment:
   well I would simply emit those warning in 3.6.x when users have upgraded.
   if user do not upgrade there is no much need.
   But if they test an upgrade they will see the warnings.
   upgrade are automatic so users should look at what is happening when they upgrade



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2791449235


##########
maven-surefire-plugin/src/site/markdown/migration355.md.vm:
##########
@@ -0,0 +1,72 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+Migration to 3.5.5 version
+==========================
+
+In the `3.6.x` version of ${thisPlugin} plugin, the removal of providers for `JUnit 3, 4` and `TestNG` is planned,
+so these providers are deprecated in the `3.5.5` version.
+
+If you want to stay on the `3.5.x` version, you can continue to use the `JUnit 3, 4` and `TestNG` providers without any changes,
+but you should be aware that these providers will be removed in the `3.6.x` version.
+
+In the `3.5.5` version of ${thisPlugin} plugin, a warning message will be emitted if you are using the `JUnit 3, 4` or `TestNG` providers.
+You can suppress this warning by setting the parameter `providerDeprecationWarning` to `false`.
+
+You should consider migrating your tests to `JUnit 5`, but if you want to continue using `JUnit 3, 4` or `TestNG`,
+Preparing for next version you can try the instructions below.
+
+**NOTE**: The JUnit engine will be automatically added to your project with `3.6.x` version of ${thisPlugin} plugin,
+so you don't need to add it manually.
+
+JUnit 3 and 4
+-------------
+
+You need to upgrade your `junit` dependencies to version `4.12` or higher (the recommended version is `4.13.2`), and add the `junit-vintage-engine` dependency to your project:

Review Comment:
   `add the `junit-vintage-engine` dependency to your project`
   this will be added automatically with the new version to keep covering junit 3/4.
   If we want to say something about this it should be more about explaining if users need a specific version of junit-vintage-engine the should add it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#issuecomment-3882267535

   I'm a bit -0 on those providers warning as it will be look like 
   running project with junit4
   ```
   [INFO] Using auto detected provider org.apache.maven.surefire.junit.JUnit3Provider
   [WARNING] JUnit4 provider is deprecated, will be removed in future versions of plugin
   ```
   or with testNG
   ```
   [INFO] Using auto detected provider org.apache.maven.surefire.testng.TestNGProvider
   [WARNING] TestNG provider is deprecated, will be removed in future versions of plugin.
   ```
   Reading this most of the users who doesn't know anything about surefire architecture with providers will enter in some panic mode and think "Oh I will not be able to run anymore my junit3/4 to TestNG tests"  
   We are refining the internal Surefire architecture regarding providers, but for most users, this change is invisible.
   Many users aren't aware that Surefire automatically scans your project dependencies, sets up the test environment for you and add some provider. This behavior is not changing. whether you use JUnit 3/4 or TestNG, we will still automatically detect the framework and inject the correct provider (only one) and dependencies for users.
   The only breaking change: We are removing the legacy provider for POJO tests (tests that run without a framework). Unless you are running raw POJO tests, your build will (should :)) continue to pass with zero changes.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2795534246


##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -2967,6 +2975,7 @@ public boolean isApplicable() {
         @Override
         public void addProviderProperties() throws MojoExecutionException {
             convertTestNGParameters();
+            providerDeprecationWarning("TestNG provider is deprecated, will be removed in future versions of plugin.");

Review Comment:
   it right



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#issuecomment-3888462428

   > Ok, it is right all providers will be works by jupiter engine which will be added automatically.
   > 
   > Only Pojo test will stop working as I see, but It is not easy detect ...
   > 
   > so we can only think to deprecated the `suiteXmlFiles` parameter ... but now I'm not sure ...
   
   well this is deprecated as well in 3.6.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2796585626


##########
maven-surefire-plugin/src/site/markdown/migration355.md.vm:
##########
@@ -0,0 +1,74 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+Migration to 3.5.5 version
+==========================
+
+In the `3.6.x` version of ${thisPlugin} plugin, the removal of providers for `JUnit 3, 4` and `TestNG` is planned,
+so these providers are deprecated in the `3.5.5` version.
+
+If you want to stay on the `3.5.x` version, you can continue to use the `JUnit 3, 4` and `TestNG` providers without any changes,
+but you should be aware that these providers will be removed in the `3.6.x` version.

Review Comment:
   reading this I feel like "oh  junit 3/4 and TestNG will not work anymore"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2784421448


##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -558,6 +558,21 @@ public class IntegrationTestMojo extends AbstractSurefireMojo {
     @Parameter(property = "failsafe.excludeJUnit5Engines")
     private String[] excludeJUnit5Engines;
 
+    /**
+     * Warning about deprecated providers and features planed to remove in <code>3.6.x</code> plugin version.
+     * <br>
+     *
+     * Set to <code>false</code> to disable the warning if you want to stay on the <code>3.5.x</code> plugin version.
+     * <br>
+     *
+     * See the documentation for more details:<br>
+     * <a href="https://maven.apache.org/surefire/maven-failsafe-plugin/migration355.html">Migration to 3.5.5 version</a>
+     *
+     * @since 3.5.5
+     */
+    @Parameter(property = "failsafe.providerDeprecationWarning", defaultValue = "true")

Review Comment:
   that is true ... we can remove such property and emit warning with deprecation always, even if user take decision to stay with old version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2784424351


##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -558,6 +558,21 @@ public class IntegrationTestMojo extends AbstractSurefireMojo {
     @Parameter(property = "failsafe.excludeJUnit5Engines")
     private String[] excludeJUnit5Engines;
 
+    /**
+     * Warning about deprecated providers and features planed to remove in <code>3.6.x</code> plugin version.
+     * <br>
+     *
+     * Set to <code>false</code> to disable the warning if you want to stay on the <code>3.5.x</code> plugin version.
+     * <br>
+     *
+     * See the documentation for more details:<br>
+     * <a href="https://maven.apache.org/surefire/maven-failsafe-plugin/migration355.html">Migration to 3.5.5 version</a>
+     *
+     * @since 3.5.5
+     */
+    @Parameter(property = "failsafe.providerDeprecationWarning", defaultValue = "true")

Review Comment:
   I don't know what is better ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2791449235


##########
maven-surefire-plugin/src/site/markdown/migration355.md.vm:
##########
@@ -0,0 +1,72 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+Migration to 3.5.5 version
+==========================
+
+In the `3.6.x` version of ${thisPlugin} plugin, the removal of providers for `JUnit 3, 4` and `TestNG` is planned,
+so these providers are deprecated in the `3.5.5` version.
+
+If you want to stay on the `3.5.x` version, you can continue to use the `JUnit 3, 4` and `TestNG` providers without any changes,
+but you should be aware that these providers will be removed in the `3.6.x` version.
+
+In the `3.5.5` version of ${thisPlugin} plugin, a warning message will be emitted if you are using the `JUnit 3, 4` or `TestNG` providers.
+You can suppress this warning by setting the parameter `providerDeprecationWarning` to `false`.
+
+You should consider migrating your tests to `JUnit 5`, but if you want to continue using `JUnit 3, 4` or `TestNG`,
+Preparing for next version you can try the instructions below.
+
+**NOTE**: The JUnit engine will be automatically added to your project with `3.6.x` version of ${thisPlugin} plugin,
+so you don't need to add it manually.
+
+JUnit 3 and 4
+-------------
+
+You need to upgrade your `junit` dependencies to version `4.12` or higher (the recommended version is `4.13.2`), and add the `junit-vintage-engine` dependency to your project:

Review Comment:
   > `add the `junit-vintage-engine` dependency to your project`
   
   this will be added automatically with the new version to keep covering junit 3/4.
   If we want to say something about this it should be more about explaining if users need a specific version of junit-vintage-engine the should add it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2791449235


##########
maven-surefire-plugin/src/site/markdown/migration355.md.vm:
##########
@@ -0,0 +1,72 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+Migration to 3.5.5 version
+==========================
+
+In the `3.6.x` version of ${thisPlugin} plugin, the removal of providers for `JUnit 3, 4` and `TestNG` is planned,
+so these providers are deprecated in the `3.5.5` version.
+
+If you want to stay on the `3.5.x` version, you can continue to use the `JUnit 3, 4` and `TestNG` providers without any changes,
+but you should be aware that these providers will be removed in the `3.6.x` version.
+
+In the `3.5.5` version of ${thisPlugin} plugin, a warning message will be emitted if you are using the `JUnit 3, 4` or `TestNG` providers.
+You can suppress this warning by setting the parameter `providerDeprecationWarning` to `false`.
+
+You should consider migrating your tests to `JUnit 5`, but if you want to continue using `JUnit 3, 4` or `TestNG`,
+Preparing for next version you can try the instructions below.
+
+**NOTE**: The JUnit engine will be automatically added to your project with `3.6.x` version of ${thisPlugin} plugin,
+so you don't need to add it manually.
+
+JUnit 3 and 4
+-------------
+
+You need to upgrade your `junit` dependencies to version `4.12` or higher (the recommended version is `4.13.2`), and add the `junit-vintage-engine` dependency to your project:

Review Comment:
   `add the `junit-vintage-engine` dependency to your project`
   this will be added automatically with the new version.
   If we want to say something about this it should be more about explaining if users need a specific version of junit-vintage-engine the should add it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2782264470


##########
maven-surefire-plugin/src/site/markdown/migration355.md.vm:
##########
@@ -0,0 +1,72 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+Migration to 3.5.5 version
+==========================
+
+In the `3.6.x` version of ${thisPlugin} plugin, the removal of providers for `JUnit 3, 4` and `TestNG` is planned,
+so these providers are deprecated in the `3.5.5` version.
+
+If you want to stay on the `3.5.x` version, you can continue to use the `JUnit 3, 4` and `TestNG` providers without any changes,
+but you should be aware that these providers will be removed in the `3.6.x` version.
+
+In the `3.5.5` version of ${thisPlugin} plugin, a warning message will be emitted if you are using the `JUnit 3, 4` or `TestNG` providers.
+You can suppress this warning by setting the parameter `providerDeprecationWarning` to `false`.
+
+You should consider migrating your tests to `JUnit 5`, but if you want to continue using `JUnit 3, 4` or `TestNG`,
+Preparing for next version you can try the instructions below.

Review Comment:
   this sentence is wonky



##########
maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefireMojo.java:
##########
@@ -535,6 +535,21 @@ public class SurefireMojo extends AbstractSurefireMojo implements SurefireReport
     @Parameter(property = "surefire.excludeJUnit5Engines")
     private String[] excludeJUnit5Engines;
 
+    /**
+     * Warning about deprecated providers and features planed to remove in <code>3.6.x</code> plugin version.

Review Comment:
   planned to be removed



##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -558,6 +558,21 @@ public class IntegrationTestMojo extends AbstractSurefireMojo {
     @Parameter(property = "failsafe.excludeJUnit5Engines")
     private String[] excludeJUnit5Engines;
 
+    /**
+     * Warning about deprecated providers and features planed to remove in <code>3.6.x</code> plugin version.
+     * <br>
+     *
+     * Set to <code>false</code> to disable the warning if you want to stay on the <code>3.5.x</code> plugin version.
+     * <br>
+     *
+     * See the documentation for more details:<br>
+     * <a href="https://maven.apache.org/surefire/maven-failsafe-plugin/migration355.html">Migration to 3.5.5 version</a>
+     *
+     * @since 3.5.5
+     */
+    @Parameter(property = "failsafe.providerDeprecationWarning", defaultValue = "true")

Review Comment:
   do we really want a property that is nothing but disabling a warning? This feels lile maybe it isn't really deprecated



##########
maven-surefire-plugin/src/site/markdown/migration355.md.vm:
##########
@@ -0,0 +1,72 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+Migration to 3.5.5 version
+==========================
+
+In the `3.6.x` version of ${thisPlugin} plugin, the removal of providers for `JUnit 3, 4` and `TestNG` is planned,
+so these providers are deprecated in the `3.5.5` version.
+
+If you want to stay on the `3.5.x` version, you can continue to use the `JUnit 3, 4` and `TestNG` providers without any changes,
+but you should be aware that these providers will be removed in the `3.6.x` version.
+
+In the `3.5.5` version of ${thisPlugin} plugin, a warning message will be emitted if you are using the `JUnit 3, 4` or `TestNG` providers.
+You can suppress this warning by setting the parameter `providerDeprecationWarning` to `false`.
+
+You should consider migrating your tests to `JUnit 5`, but if you want to continue using `JUnit 3, 4` or `TestNG`,
+Preparing for next version you can try the instructions below.
+
+**NOTE**: The JUnit engine will be automatically added to your project with `3.6.x` version of ${thisPlugin} plugin,
+so you don't need to add it manually.
+
+JUnit 3 and 4
+-------------
+
+You need to upgrade your `junit` dependencies to version `4.12` or higher (the recommended version is `4.13.2`), and add the `junit-vintage-engine` dependency to your project:

Review Comment:
   I hope this doesn't cause any unused dependency warnings



##########
maven-surefire-plugin/src/site/markdown/migration355.md.vm:
##########
@@ -0,0 +1,72 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+Migration to 3.5.5 version
+==========================
+
+In the `3.6.x` version of ${thisPlugin} plugin, the removal of providers for `JUnit 3, 4` and `TestNG` is planned,
+so these providers are deprecated in the `3.5.5` version.
+
+If you want to stay on the `3.5.x` version, you can continue to use the `JUnit 3, 4` and `TestNG` providers without any changes,
+but you should be aware that these providers will be removed in the `3.6.x` version.
+
+In the `3.5.5` version of ${thisPlugin} plugin, a warning message will be emitted if you are using the `JUnit 3, 4` or `TestNG` providers.
+You can suppress this warning by setting the parameter `providerDeprecationWarning` to `false`.
+
+You should consider migrating your tests to `JUnit 5`, but if you want to continue using `JUnit 3, 4` or `TestNG`,
+Preparing for next version you can try the instructions below.
+
+**NOTE**: The JUnit engine will be automatically added to your project with `3.6.x` version of ${thisPlugin} plugin,
+so you don't need to add it manually.
+
+JUnit 3 and 4
+-------------
+
+You need to upgrade your `junit` dependencies to version `4.12` or higher (the recommended version is `4.13.2`), and add the `junit-vintage-engine` dependency to your project:
+
+```xml
+<dependency>
+    <groupId>junit</groupId>
+    <artifactId>junit</artifactId>
+    <version>4.13.2</version>
+</dependency>
+<dependency>
+    <groupId>org.junit.vintage</groupId>
+    <artifactId>junit-vintage-engine</artifactId>
+    <version>5.14.2</version>
+    <scope>test</scope>
+</dependency>
+```
+Please refer to the documentation for more details [Migrating from JUnit 4](https://docs.junit.org/5.14.2/migrating-from-junit4.html)
+
+TestNG
+------
+
+You need to use a [TestNG Engine for the JUnit Platform](https://github.com/junit-team/testng-engine), so add the `testng-engine` dependency to your project:

Review Comment:
   use a --> use the



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2784263048


##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -558,6 +558,21 @@ public class IntegrationTestMojo extends AbstractSurefireMojo {
     @Parameter(property = "failsafe.excludeJUnit5Engines")
     private String[] excludeJUnit5Engines;
 
+    /**
+     * Warning about deprecated providers and features planed to remove in <code>3.6.x</code> plugin version.

Review Comment:
   planned to be removed



##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -558,6 +558,21 @@ public class IntegrationTestMojo extends AbstractSurefireMojo {
     @Parameter(property = "failsafe.excludeJUnit5Engines")
     private String[] excludeJUnit5Engines;
 
+    /**
+     * Warning about deprecated providers and features planed to remove in <code>3.6.x</code> plugin version.
+     * <br>
+     *
+     * Set to <code>false</code> to disable the warning if you want to stay on the <code>3.5.x</code> plugin version.
+     * <br>
+     *
+     * See the documentation for more details:<br>
+     * <a href="https://maven.apache.org/surefire/maven-failsafe-plugin/migration355.html">Migration to 3.5.5 version</a>
+     *
+     * @since 3.5.5
+     */
+    @Parameter(property = "failsafe.providerDeprecationWarning", defaultValue = "true")

Review Comment:
   silencing warnings usually doesn't happen at the level of a maven property. It's a logging option. Too many switches and flags causes cognitive overload. At some point you need to make a decision.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2786945453


##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -558,6 +558,21 @@ public class IntegrationTestMojo extends AbstractSurefireMojo {
     @Parameter(property = "failsafe.excludeJUnit5Engines")
     private String[] excludeJUnit5Engines;
 
+    /**
+     * Warning about deprecated providers and features planed to remove in <code>3.6.x</code> plugin version.
+     * <br>
+     *
+     * Set to <code>false</code> to disable the warning if you want to stay on the <code>3.5.x</code> plugin version.
+     * <br>
+     *
+     * See the documentation for more details:<br>
+     * <a href="https://maven.apache.org/surefire/maven-failsafe-plugin/migration355.html">Migration to 3.5.5 version</a>
+     *
+     * @since 3.5.5
+     */
+    @Parameter(property = "failsafe.providerDeprecationWarning", defaultValue = "true")

Review Comment:
   in 3.6.x warning will not be emited ... we will drop providers implementations



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#issuecomment-3873720557

   > silencing warnings usually doesn't happen at the level of a maven property. It's a logging option. Too many switches and flags causes cognitive overload. At some point you need to make a decision.
   
   that is true ... we can remove such property and emit warning with deprecation always, even if user take decision to stay with old version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2791153375


##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -558,6 +558,21 @@ public class IntegrationTestMojo extends AbstractSurefireMojo {
     @Parameter(property = "failsafe.excludeJUnit5Engines")
     private String[] excludeJUnit5Engines;
 
+    /**
+     * Warning about deprecated providers and features planed to remove in <code>3.6.x</code> plugin version.
+     * <br>
+     *
+     * Set to <code>false</code> to disable the warning if you want to stay on the <code>3.5.x</code> plugin version.
+     * <br>
+     *
+     * See the documentation for more details:<br>
+     * <a href="https://maven.apache.org/surefire/maven-failsafe-plugin/migration355.html">Migration to 3.5.5 version</a>
+     *
+     * @since 3.5.5
+     */
+    @Parameter(property = "failsafe.providerDeprecationWarning", defaultValue = "true")

Review Comment:
   well I find weird to add field here which is almost already deprecated :) 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2795533358


##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -558,6 +558,21 @@ public class IntegrationTestMojo extends AbstractSurefireMojo {
     @Parameter(property = "failsafe.excludeJUnit5Engines")
     private String[] excludeJUnit5Engines;
 
+    /**
+     * Warning about deprecated providers and features planed to remove in <code>3.6.x</code> plugin version.
+     * <br>
+     *
+     * Set to <code>false</code> to disable the warning if you want to stay on the <code>3.5.x</code> plugin version.
+     * <br>
+     *
+     * See the documentation for more details:<br>
+     * <a href="https://maven.apache.org/surefire/maven-failsafe-plugin/migration355.html">Migration to 3.5.5 version</a>
+     *
+     * @since 3.5.5
+     */
+    @Parameter(property = "failsafe.providerDeprecationWarning", defaultValue = "true")

Review Comment:
   ok, next parameter will be not needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2784158701


##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -558,6 +558,21 @@ public class IntegrationTestMojo extends AbstractSurefireMojo {
     @Parameter(property = "failsafe.excludeJUnit5Engines")
     private String[] excludeJUnit5Engines;
 
+    /**
+     * Warning about deprecated providers and features planed to remove in <code>3.6.x</code> plugin version.
+     * <br>
+     *
+     * Set to <code>false</code> to disable the warning if you want to stay on the <code>3.5.x</code> plugin version.
+     * <br>
+     *
+     * See the documentation for more details:<br>
+     * <a href="https://maven.apache.org/surefire/maven-failsafe-plugin/migration355.html">Migration to 3.5.5 version</a>
+     *
+     * @since 3.5.5
+     */
+    @Parameter(property = "failsafe.providerDeprecationWarning", defaultValue = "true")

Review Comment:
   Goal is inform users about planned changes in 3.6.x 
   We assume that some users can stay at 3.5.x due to changes in 3.6.x, so we provide a possibility to suppress warnings in a such case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2791469591


##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -2998,7 +3007,9 @@ public boolean isApplicable() {
         }
 
         @Override
-        public void addProviderProperties() {}
+        public void addProviderProperties() {

Review Comment:
   ditto.
   same comment. Junit3 will be still supported. vintage engine will be added magically same as provider is added magically in versions previous the big change.



##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -3290,6 +3303,7 @@ public void addProviderProperties() throws MojoExecutionException {
             convertJunitCoreParameters();
             convertGroupParameters();
             convertJunitEngineParameters();
+            providerDeprecationWarning("JUnit4 provider is deprecated, will be removed in future versions of plugin.");

Review Comment:
   ditto.
   same comment. Junit4 will be still supported. vintage engine will be added magically same as provider is added magically in versions previous the big change.



##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -3039,7 +3050,9 @@ public boolean isApplicable() {
         }
 
         @Override
-        public void addProviderProperties() {}
+        public void addProviderProperties() {

Review Comment:
   ditto.
   same comment. Junit4 will be still supported. vintage engine will be added magically same as provider is added magically in versions previous the big change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski closed pull request #3259: Deprecate JUnit 3,4 and TestNG providers
URL: https://github.com/apache/maven-surefire/pull/3259


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#issuecomment-3887260721

   Ok, it is right all providers will be works by jupiter engine which will be added automatically.
   
   Only Pojo test will stop working as I see, but It is not easy detect ...
   
   so we can only think to deprecated the `suiteXmlFiles` parameter ... but now I'm not sure ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate JUnit 3,4 and TestNG providers [maven-surefire]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2784405914


##########
maven-surefire-plugin/src/site/markdown/migration355.md.vm:
##########
@@ -0,0 +1,72 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+Migration to 3.5.5 version
+==========================
+
+In the `3.6.x` version of ${thisPlugin} plugin, the removal of providers for `JUnit 3, 4` and `TestNG` is planned,
+so these providers are deprecated in the `3.5.5` version.
+
+If you want to stay on the `3.5.x` version, you can continue to use the `JUnit 3, 4` and `TestNG` providers without any changes,
+but you should be aware that these providers will be removed in the `3.6.x` version.
+
+In the `3.5.5` version of ${thisPlugin} plugin, a warning message will be emitted if you are using the `JUnit 3, 4` or `TestNG` providers.
+You can suppress this warning by setting the parameter `providerDeprecationWarning` to `false`.
+
+You should consider migrating your tests to `JUnit 5`, but if you want to continue using `JUnit 3, 4` or `TestNG`,
+Preparing for next version you can try the instructions below.

Review Comment:
   I have rewrite this sentence



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org