You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/05/27 20:11:24 UTC
[GitHub] [couchdb] sklassen opened a new pull request #2911: 2906 couchjs sm version
sklassen opened a new pull request #2911:
URL: https://github.com/apache/couchdb/pull/2911
## Overview
couchjs returns couchdb version but not the version of spidermonkey used at compile time
Since each version has it's own help.h I just added the directories version number to the end of the first line eg "(SpiderMonkey 60)"
## Testing recommendations
I have compiled the code can ran couchjs -V
## Related Issues or Pull Requests
This addresses issue #2906
## Checklist
- [X] Code is written and works correctly
- [X] Changes are covered by tests
- [X] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [X] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] janl commented on pull request #2911: 2906 couchjs sm version
Posted by GitBox <gi...@apache.org>.
janl commented on pull request #2911:
URL: https://github.com/apache/couchdb/pull/2911#issuecomment-635214509
this is good!
IIRC the 60 side can also build against 68, so we need to be a little bit smarter there. Or we are more lazy and make it `60 or later`, not sure that would help ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] janl commented on pull request #2911: 2906 couchjs sm version
Posted by GitBox <gi...@apache.org>.
janl commented on pull request #2911:
URL: https://github.com/apache/couchdb/pull/2911#issuecomment-635478696
wait., when I looked there was no diff for /68, did this get added behind my back or did I just miss this earlier? Apologies!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] wohali merged pull request #2911: 2906 couchjs sm version
Posted by GitBox <gi...@apache.org>.
wohali merged pull request #2911:
URL: https://github.com/apache/couchdb/pull/2911
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] wohali commented on pull request #2911: 2906 couchjs sm version
Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #2911:
URL: https://github.com/apache/couchdb/pull/2911#issuecomment-635441400
@janl Nope, we ended up having to fork, so the `60/` directory only builds SM60 now. `68/` does 68.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org