You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2016/09/30 13:22:30 UTC
[GitHub] brooklyn-server pull request #362: bump httpcomponents versions
GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-server/pull/362
bump httpcomponents versions
note core and client are no longer kept in sync; latest version of each has been taken
this seems to fix strange problems with `HttpRequestSensorYamlTest` failing in maven but working in eclipse, presumably due to use of `TestHttpServer` using these components. it does not however fix the JVM crash in that test under java 7 sadly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/brooklyn-server bump-httpcomponents-versions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/362.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #362
----
commit da2453de7a50ba05f7443d32ecbd01e522425fa6
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2016-09-30T13:19:10Z
bump httpcomponents versions
note core and client are no longer kept in sync; latest version of each has been taken
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #362: bump httpcomponents versions
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/362
recent changes: fixed one compatibility issue, refer to v0.11 not 0.10, and rebased on master . (see last two commits for these tiny recent changes)
i don't seem to get the failing tests @neykov reports so maybe that was a different issue
re karaf and impact on "httpasyncclient:jar:4.1 (a dependency of cxf-rt-transports-http-hc, which is needed by winrm4j)", as noted by @aledsage, i have not tested either. i'll try to do this but others (cc @bostko re winrm4j) may be more efficient at doing that which is fine also!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #362: bump httpcomponents versions
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/362
Another reason to upgrade - current version doesn't use system proxy passed through `-Djava.net.useSystemProxies=true` or `-Dhttp.proxyHost`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #362: bump httpcomponents versions
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/362
LGTM. Feels like the right moment to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #362: bump httpcomponents versions
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/362
See https://github.com/cloudsoft/winrm4j/pull/44 for another reason to upgrade to CXF 3.1.9.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #362: bump httpcomponents versions
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/362
See https://issues.apache.org/jira/browse/BROOKLYN-423 for tracking the upgrade to cxf 3.1.9, and some initial findings. I'll look into this a little longer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #362: bump httpcomponents versions
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/362
I've tested this with winrm4j and it's not working. It's sending the wrong `Content-Type`, resulting in a `415` response code.
Bumping the cxf version to `3.1.9` works fine though and it brings in almost the same dependencies:
```
[INFO] +- org.apache.cxf:cxf-rt-transports-http-hc:jar:3.1.9:compile
[INFO] | +- org.apache.httpcomponents:httpcore-nio:jar:4.4.4:compile
[INFO] | | \- org.apache.httpcomponents:httpcore:jar:4.4.4:compile
[INFO] | \- org.apache.httpcomponents:httpasyncclient:jar:4.1.2:compile
[INFO] | \- org.apache.httpcomponents:httpclient:jar:4.5.2:compile
```
Suggest upgrading `cxf` to `3.1.9` and downgrading core to `4.4.4`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #362: bump httpcomponents versions
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/362#discussion_r94937432
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -51,8 +51,8 @@
<bundle dependency="true">mvn:commons-codec/commons-codec/${commons-codec.version}</bundle>
<bundle dependency="true">mvn:org.slf4j/jul-to-slf4j/${slf4j.version}</bundle>
<bundle dependency="true">mvn:org.yaml/snakeyaml/${snakeyaml.version}</bundle>
- <bundle dependency="true">mvn:org.apache.httpcomponents/httpcore-osgi/${httpclient.version}</bundle>
- <bundle dependency="true">mvn:org.apache.httpcomponents/httpclient-osgi/${httpclient.version}</bundle>
+ <bundle dependency="true">mvn:org.apache.httpcomponents/httpcore-osgi/${httpclient.httpcore.version}</bundle>
--- End diff --
Should this not be `${httpcomponents.httpcore.version}` (and the line below `httpcomponents.httpclient.version`)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #362: bump httpcomponents versions
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/362
Can apply the changes on `feature.xml` as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #362: bump httpcomponents versions
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/362
#547 is a better more holistic fix; closing here in preference to that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #362: bump httpcomponents versions
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/362
I have some failing tests locally:
```
ApplicationResourceTest.testDeployApplicationFromBuilder:227->BrooklynRestResourceTest.waitForApplicationToBeRunning:157 expected [true] but found [false]
UsageResourceTest.testGetApplicationUsage:161->createApp:309->waitForTask:351 task AsOhrOHp not finished expected [true] but found [false]
UsageResourceTest.testListApplicationUsages:90->createApp:309->waitForTask:351 task R1AyyoGm not finished expected [true] but found [false]
UsageResourceTest.testListMachinesUsageForApp:302 usages=[UsageStatistics{statistics=[UsageStatistic{status=RUNNING, id='oawydt4n04', applicationId='oawydt4n04', start='2016-12-16T19:12:57+0000', end='2016-12-16T19:12:57+0000', duration=7, metadata={}}], links={}}] expected [true] but found [false]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #362: bump httpcomponents versions
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/362
This is probably ok, but we should double-check the conflicting dependencies (e.g. will it cause runtime errors in `httpasyncclient:jar:4.1` (a dependency of `cxf-rt-transports-http-hc`, which is needed by winrm4j)). There may well be other conflicts as well:
```
[INFO] | | +- org.apache.brooklyn:brooklyn-software-winrm:jar:0.10.0-SNAPSHOT:compile
[INFO] | | | +- (org.apache.brooklyn:brooklyn-core:jar:0.10.0-SNAPSHOT:compile - omitted for duplicate)
[INFO] | | | +- io.cloudsoft.windows:winrm4j:jar:0.4.0:compile
[INFO] | | | | \- io.cloudsoft.windows:winrm4j-client:jar:0.4.0:compile
[INFO] | | | | +- org.apache.cxf:cxf-rt-transports-http:jar:3.1.4:compile
[INFO] | | | | | \- org.apache.cxf:cxf-core:jar:3.1.4:compile
[INFO] | | | | | +- org.codehaus.woodstox:woodstox-core-asl:jar:4.4.1:compile
[INFO] | | | | | | \- org.codehaus.woodstox:stax2-api:jar:3.1.4:compile
[INFO] | | | | | \- org.apache.ws.xmlschema:xmlschema-core:jar:2.2.1:compile
[INFO] | | | | +- org.apache.cxf:cxf-rt-transports-http-hc:jar:3.1.4:compile
[INFO] | | | | | +- (org.apache.cxf:cxf-core:jar:3.1.4:compile - omitted for duplicate)
[INFO] | | | | | +- (org.apache.cxf:cxf-rt-transports-http:jar:3.1.4:compile - omitted for duplicate)
[INFO] | | | | | +- org.apache.httpcomponents:httpcore-nio:jar:4.4.1:compile
[INFO] | | | | | | \- (org.apache.httpcomponents:httpcore:jar:4.4.1:compile - omitted for conflict with 4.4.5)
[INFO] | | | | | \- org.apache.httpcomponents:httpasyncclient:jar:4.1:compile
[INFO] | | | | | +- (org.apache.httpcomponents:httpcore:jar:4.4.1:compile - omitted for conflict with 4.4.5)
[INFO] | | | | | +- (org.apache.httpcomponents:httpcore-nio:jar:4.4.1:compile - omitted for duplicate)
[INFO] | | | | | \- (org.apache.httpcomponents:httpclient:jar:4.4.1:compile - omitted for conflict with 4.5.2)
```
Also, does this work in karaf? Or might some dependent bundles have been built to depend on httpclient `[4.4,4.5)` (so fail to install, unless we include both versioned bundles in the karaf install)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #362: bump httpcomponents versions
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/362
Trying to test this (including the cxf upgrade to 3.1.9), it is failing when starting karaf with:
```
2017-01-06 15:29:40,191 ERROR 11 o.a.k.f.i.s.BootFeaturesInstaller [pool-7-thread-1] Error installing boot features
org.osgi.service.resolver.ResolutionException: Unable to resolve org.ops4j.pax.web.pax-web-jsp/4.2.4: missing requirement [org.ops4j.pax.web.pax-web-jsp/4.2.4] osgi.wiring.package; filter:="(&(osgi.wiring.package=javax.servlet.jsp.resources)(version>=2.2.0))"
at org.apache.felix.resolver.ResolutionError.toException(ResolutionError.java:42)[org.apache.felix.framework-5.4.0.jar:]
at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:404)[org.apache.felix.framework-5.4.0.jar:]
at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:158)[org.apache.felix.framework-5.4.0.jar:]
at org.apache.karaf.features.internal.region.SubsystemResolver.resolve(SubsystemResolver.java:216)[11:org.apache.karaf.features.core:4.0.4]
at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:263)[11:org.apache.karaf.features.core:4.0.4]
at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:259)[11:org.apache.karaf.features.core:4.0.4]
at org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1089)[11:org.apache.karaf.features.core:4.0.4]
at org.apache.karaf.features.internal.service.FeaturesServiceImpl$1.call(FeaturesServiceImpl.java:985)[11:org.apache.karaf.features.core:4.0.4]
at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_111]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_111]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_111]
at java.lang.Thread.run(Thread.java:745)[:1.8.0_111]
```
Talking to @m4rkmckenna, it is likely that the error shown is not the underlying cause.
I'm going to try applying these changes incrementally (starting with the cxf 3.1.9 upgrade), to see if I can get karaf to start properly!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #362: bump httpcomponents versions
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin closed the pull request at:
https://github.com/apache/brooklyn-server/pull/362
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---