You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/04 08:03:52 UTC
[GitHub] [maven-resolver] cstamas opened a new pull request, #215: [MRESOLVER-286] Improve basic connector closed state handling
cstamas opened a new pull request, #215:
URL: https://github.com/apache/maven-resolver/pull/215
Basic connector was last that handled closed state in a bit "wonky" way, rework to use it AtomicBoolean as everything else in resolver.
---
https://issues.apache.org/jira/browse/MRESOLVER-286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a diff in pull request #215: [MRESOLVER-286] Improve basic connector closed state handling
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #215:
URL: https://github.com/apache/maven-resolver/pull/215#discussion_r1014360127
##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##########
@@ -297,10 +303,7 @@ public void get( Collection<? extends ArtifactDownload> artifactDownloads,
public void put( Collection<? extends ArtifactUpload> artifactUploads,
Collection<? extends MetadataUpload> metadataUploads )
{
- if ( closed )
- {
- throw new IllegalStateException( "connector closed" );
- }
+ failIfClosed();
Review Comment:
`Connector already closed`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas merged pull request #215: [MRESOLVER-286] Improve basic connector closed state handling
Posted by GitBox <gi...@apache.org>.
cstamas merged PR #215:
URL: https://github.com/apache/maven-resolver/pull/215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #215: [MRESOLVER-286] Improve basic connector closed state handling
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #215:
URL: https://github.com/apache/maven-resolver/pull/215#discussion_r1015423070
##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##########
@@ -297,10 +303,7 @@ public void get( Collection<? extends ArtifactDownload> artifactDownloads,
public void put( Collection<? extends ArtifactUpload> artifactUploads,
Collection<? extends MetadataUpload> metadataUploads )
{
- if ( closed )
- {
- throw new IllegalStateException( "connector closed" );
- }
+ failIfClosed();
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #215: [MRESOLVER-286] Improve basic connector closed state handling
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #215:
URL: https://github.com/apache/maven-resolver/pull/215#issuecomment-1304037113
> So this makes it idiotproof from a concurrent point of view?
This just aligns to other shutdown-able stuff in resolver (same pattern applied). Kinda more like consistency issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org