You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by he...@apache.org on 2015/09/15 18:53:30 UTC

[11/15] incubator-brooklyn git commit: Update IntelliJ configuration

Update IntelliJ configuration

Remove reference to Java 1.6 (Brooklyn doesn't support this any more) and add a note about "optimize imports" reconfiguration.

Project: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/commit/fb7a70f4
Tree: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/tree/fb7a70f4
Diff: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/diff/fb7a70f4

Branch: refs/heads/master
Commit: fb7a70f47665720fea1e612fe58c4e5edaf4b154
Parents: 7ca2781
Author: Richard Downer <ri...@apache.org>
Authored: Tue Sep 15 13:32:29 2015 +0100
Committer: Richard Downer <ri...@apache.org>
Committed: Tue Sep 15 13:32:29 2015 +0100

----------------------------------------------------------------------
 docs/guide/dev/env/ide/index.md | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/blob/fb7a70f4/docs/guide/dev/env/ide/index.md
----------------------------------------------------------------------
diff --git a/docs/guide/dev/env/ide/index.md b/docs/guide/dev/env/ide/index.md
index f046abc..b33ef1a 100644
--- a/docs/guide/dev/env/ide/index.md
+++ b/docs/guide/dev/env/ide/index.md
@@ -87,11 +87,11 @@ To develop or debug Brooklyn in IntelliJ, you will need to ensure that the Groov
 via the IntelliJ IDEA | Preferences | Plugins menu. Once installed, you can open Brooklyn from the root folder, 
 (e.g. ``~/myfiles/brooklyn``) which will automatically open the subprojects.
 
-You will need the java compiler 1.7 or higher.
-There have previously been issues where the java 6 compiler incorrectly identified the return type of functions that use
-generics. These issues have been refactored away, however may return in future. 
-If you encounter these problems, ensure that your java compiler is set to level 1.7 or higher, 
-or setup IntelliJ to use the Eclipse compiler (Settings | Compiler | Java Compiler | "Use Compiler" combobox).
+Brooklyn has informally standardized on arranging `import` statements as per Eclipse's default configuration.
+IntelliJ's default configuration is different, which can result in unwanted "noise" in commits where imports are
+shuffled backward and forward between the two types - PRs which do this will likely fail the review. To avoid this,
+reconfigure IntelliJ to organize imports similar to Eclipse. See [this StackOverflow answer](http://stackoverflow.com/a/17194980/68898)
+for a suitable configuration.
 
 
 ## Netbeans