You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2024/02/14 11:25:13 UTC
[PR] [WIP][SQL] Replace `IllegalArgumentException` by `SparkIllegalArgumentException` in `sql/api` [spark]
MaxGekk opened a new pull request, #45098:
URL: https://github.com/apache/spark/pull/45098
### What changes were proposed in this pull request?
In the PR, I propose to replace all `IllegalArgumentException` by `SparkIllegalArgumentException` in `sql/api` code base, and introduce new legacy error classes with the `_LEGACY_ERROR_TEMP_` prefix.
### Why are the changes needed?
To unify Spark SQL exception, and port Java exceptions on Spark exceptions with error classes.
### Does this PR introduce _any_ user-facing change?
Yes, it can if user's code assumes some particular format of `IllegalArgumentException` messages.
### How was this patch tested?
By running existing test suites like:
```
$ build/sbt "core/testOnly *SparkThrowableSuite"
```
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47045][SQL] Replace `IllegalArgumentException` by `SparkIllegalArgumentException` in `sql/api` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #45098:
URL: https://github.com/apache/spark/pull/45098#issuecomment-1944212990
@HyukjinKwon @LuciferYang @panbingkun @srielau @hvanhovell @beliefer Could you review this PR, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47045][SQL] Replace `IllegalArgumentException` by `SparkIllegalArgumentException` in `sql/api` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #45098: [SPARK-47045][SQL] Replace `IllegalArgumentException` by `SparkIllegalArgumentException` in `sql/api`
URL: https://github.com/apache/spark/pull/45098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47045][SQL] Replace `IllegalArgumentException` by `SparkIllegalArgumentException` in `sql/api` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #45098:
URL: https://github.com/apache/spark/pull/45098#issuecomment-1945501972
Merging to master. Thank you, @srielau for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47045][SQL] Replace `IllegalArgumentException` by `SparkIllegalArgumentException` in `sql/api` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #45098:
URL: https://github.com/apache/spark/pull/45098#discussion_r1489927146
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -7767,6 +7767,76 @@
"Single backslash is prohibited. It has special meaning as beginning of an escape sequence. To get the backslash character, pass a string with two backslashes as the delimiter."
]
},
+ "_LEGACY_ERROR_TEMP_3249" : {
+ "message" : [
+ "Failed to convert value <value> (class of <valueClass>}) with the type of <dataType> to JSON."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3250" : {
+ "message" : [
+ "Failed to convert the JSON string '<other>' to a field."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3251" : {
+ "message" : [
+ "Failed to convert the JSON string '<other>' to a data type."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3252" : {
+ "message" : [
+ "<name> does not exist. Available: <fieldNames>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3253" : {
+ "message" : [
+ "<nonExistFields> do(es) not exist. Available: <fieldNames>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3254" : {
+ "message" : [
+ "<name> does not exist. Available: <fieldNames>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3255" : {
+ "message" : [
+ "Error parsing '<input>' to interval, <msg>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3256" : {
+ "message" : [
+ "Unrecognized datetime pattern: <pattern>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3257" : {
+ "message" : [
+ "All week-based patterns are unsupported since Spark 3.0, detected: <c>, Please use the SQL function EXTRACT instead"
Review Comment:
I preserved punctuation of the original error intentionally:
https://github.com/apache/spark/pull/45098/files#diff-1ada8897c412e27c3f73c8f5449f62f1fdc805b979cc7cfa35fcf8ad031529bbL313
to don't break existing tests. We should improve errors while assigning proper error class names, and writing tests for the errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47045][SQL] Replace `IllegalArgumentException` by `SparkIllegalArgumentException` in `sql/api` [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on code in PR #45098:
URL: https://github.com/apache/spark/pull/45098#discussion_r1489921713
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -7767,6 +7767,76 @@
"Single backslash is prohibited. It has special meaning as beginning of an escape sequence. To get the backslash character, pass a string with two backslashes as the delimiter."
]
},
+ "_LEGACY_ERROR_TEMP_3249" : {
+ "message" : [
+ "Failed to convert value <value> (class of <valueClass>}) with the type of <dataType> to JSON."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3250" : {
+ "message" : [
+ "Failed to convert the JSON string '<other>' to a field."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3251" : {
+ "message" : [
+ "Failed to convert the JSON string '<other>' to a data type."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3252" : {
+ "message" : [
+ "<name> does not exist. Available: <fieldNames>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3253" : {
+ "message" : [
+ "<nonExistFields> do(es) not exist. Available: <fieldNames>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3254" : {
+ "message" : [
+ "<name> does not exist. Available: <fieldNames>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3255" : {
+ "message" : [
+ "Error parsing '<input>' to interval, <msg>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3256" : {
+ "message" : [
+ "Unrecognized datetime pattern: <pattern>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3257" : {
+ "message" : [
+ "All week-based patterns are unsupported since Spark 3.0, detected: <c>, Please use the SQL function EXTRACT instead"
Review Comment:
nit: punctuation in `detected: <c>, Please` could be improved, feel free to ignore though :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org