You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/16 10:21:32 UTC

[GitHub] [flink] Airblader opened a new pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Airblader opened a new pull request #17808:
URL: https://github.com/apache/flink/pull/17808


   ## What is the purpose of the change
   
   This is a few commits which aim to slowly improve the code quality in Flink UI by improving type safety and various smaller fixes. With the exception of the last commit all changes are non-functional, and the last commit only fixes a bug which causes an error in the browser console.
   
   This PR also adds `angular-testing-library` which will make writing tests in the future easier.
   
   ## Brief change log
   
   See individual commits.
   
   ## Verifying this change
   
   Flink UI doesn't yet have tests. I added a couple here due to the addition of `angular-testing-library`, but we need to add more tests, of course.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): yes
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750474903



##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/subtask/job-checkpoints-subtask.component.ts
##########
@@ -40,31 +55,42 @@ import { deepFind } from 'utils';
   changeDetection: ChangeDetectionStrategy.OnPush
 })
 export class JobCheckpointsSubtaskComponent implements OnInit, OnChanges {
-  @Input() vertex: VerticesItemInterface;
-  @Input() checkPointId: number;
-  jobDetail: JobDetailCorrectInterface;
-  subTaskCheckPoint: CheckPointSubTaskInterface;
-  listOfSubTaskCheckPoint: Array<{ index: number; status: string }> = [];
-  isLoading = true;
-  sortName: string;
-  sortValue: string;
+  @Input() public vertex: VerticesItem;
+  @Input() public checkPointId: number;
+
+  public jobDetail: JobDetailCorrect;
+  public subTaskCheckPoint: CheckPointSubTask;
+  public listOfSubTaskCheckPoint: SubTaskCheckPointStatisticsItem[] = [];
+  public isLoading = true;
+  public sortName: string;
+  public sortValue: string;
 
-  sortAckTimestampFn = this.sortFn('ack_timestamp');
-  sortEndToEndDurationFn = this.sortFn('end_to_end_duration');
-  sortStateSizeFn = this.sortFn('state_size');
-  sortCpSyncFn = this.sortFn('checkpoint.sync');
-  sortCpAsyncFn = this.sortFn('checkpoint.async');
-  sortAlignmentProcessedFn = this.sortFn('alignment.processed');
-  sortAlignmentDurationFn = this.sortFn('alignment.duration');
-  sortStartDelayFn = this.sortFn('start_delay');
-  sortUnalignedCpFn = this.sortFn('unaligned_checkpoint');
+  public readonly sortAckTimestampFn = createSortFn(item => item.ack_timestamp);
+  public readonly sortEndToEndDurationFn = createSortFn(item => item.end_to_end_duration);
+  public readonly sortStateSizeFn = createSortFn(item => item.state_size);
+  public readonly sortCpSyncFn = createSortFn(item => item.checkpoint?.sync);

Review comment:
       The sort functions here never return 0, so there is no stability, no. But that's how it was before, I just switched from a type-unsafe string path to a type-safe selector function.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750476530



##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/list/job-overview-list.component.ts
##########
@@ -16,12 +16,17 @@
  * limitations under the License.
  */
 
-import { Component, EventEmitter, Input, Output, ChangeDetectionStrategy, ElementRef } from '@angular/core';
+import { ChangeDetectionStrategy, Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
 
 import { NzTableSortFn } from 'ng-zorro-antd/table/src/table.types';
 
 import { NodesItemCorrectInterface } from 'interfaces';
-import { deepFind } from 'utils';
+
+function createSortFn(
+  selector: (item: NodesItemCorrectInterface) => number | string | undefined
+): NzTableSortFn<NodesItemCorrectInterface> {
+  return (pre, next) => (selector(pre)! > selector(next)! ? 1 : -1);

Review comment:
       Yes, we are. Note that `undefined > …`, `… > undefined` and `undefined > undefined` are all "valid" in the sense that they don't error, so we're not running into the problem of possibly causing errors here (the behavior was pre-existent anyway, now it's just visible).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609",
       "triggerID" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ec014a9f6d9d5b409c3c5da395f77c0f29db7a85 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131265


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit e6db25a6c87ab4fa688edc2a5e050c8675cb336f (Tue Nov 16 10:26:54 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] nicoweidner commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
nicoweidner commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750493966



##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/list/job-overview-list.component.ts
##########
@@ -16,12 +16,17 @@
  * limitations under the License.
  */
 
-import { Component, EventEmitter, Input, Output, ChangeDetectionStrategy, ElementRef } from '@angular/core';
+import { ChangeDetectionStrategy, Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
 
 import { NzTableSortFn } from 'ng-zorro-antd/table/src/table.types';
 
 import { NodesItemCorrectInterface } from 'interfaces';
-import { deepFind } from 'utils';
+
+function createSortFn(
+  selector: (item: NodesItemCorrectInterface) => number | string | undefined
+): NzTableSortFn<NodesItemCorrectInterface> {
+  return (pre, next) => (selector(pre)! > selector(next)! ? 1 : -1);

Review comment:
       Maybe we could just return -1 whenever any of the values is undefined? That should have the same effect and be (a little bit) less awkward




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0060b55f1cbde54a64ac26fd25f372192e3902f3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0060b55f1cbde54a64ac26fd25f372192e3902f3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e6db25a6c87ab4fa688edc2a5e050c8675cb336f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597) 
   * 873d727b7155e2be6737354ab971c08971e2fb68 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605) 
   * 0060b55f1cbde54a64ac26fd25f372192e3902f3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e6db25a6c87ab4fa688edc2a5e050c8675cb336f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597) 
   * 873d727b7155e2be6737354ab971c08971e2fb68 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e6db25a6c87ab4fa688edc2a5e050c8675cb336f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597) 
   * 873d727b7155e2be6737354ab971c08971e2fb68 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609",
       "triggerID" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 873d727b7155e2be6737354ab971c08971e2fb68 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605) 
   * ec014a9f6d9d5b409c3c5da395f77c0f29db7a85 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609",
       "triggerID" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fd26a039df83a1cd7e64927cf08eb55633d6d1f2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fd26a039df83a1cd7e64927cf08eb55633d6d1f2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ec014a9f6d9d5b409c3c5da395f77c0f29db7a85 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609) 
   * fd26a039df83a1cd7e64927cf08eb55633d6d1f2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e6db25a6c87ab4fa688edc2a5e050c8675cb336f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597) 
   * 873d727b7155e2be6737354ab971c08971e2fb68 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605) 
   * ec014a9f6d9d5b409c3c5da395f77c0f29db7a85 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750481723



##########
File path: flink-runtime-web/web-dashboard/src/app/share/common/dagre/svg-container.component.ts
##########
@@ -32,7 +32,8 @@ import * as d3 from 'd3';
 import { select, Selection } from 'd3-selection';
 import { zoom, ZoomBehavior } from 'd3-zoom';
 
-import { SafeAny } from 'interfaces';
+/* eslint-disable-next-line @typescript-eslint/no-explicit-any */
+export type SafeAny = any;

Review comment:
       It really seems like that's more difficult here, yes. Unfortunately.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750480969



##########
File path: flink-runtime-web/web-dashboard/src/app/share/common/dagre/graph.ts
##########
@@ -40,10 +40,12 @@ export interface LayoutNodeOptions {
   focused: boolean;
 }
 
-export interface LayoutLink extends NodesItemLinkInterface {
-  [key: string]: SafeAny;
+export interface LayoutLink extends NodesItemLink {
+  [key: string]: unknown;
 
-  detail: SafeAny;
+  detail: {
+    [key: string]: unknown;
+  };

Review comment:
       It is! Will change it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AHeise commented on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970536415


   Thanks for the contribution. I cannot access the content but looking at the size, it's safe to assume that we are not talking about a hotfix. Please create a Jira ticket and use that instead of hotfix. The ticket will be then a point where future developers can refer to. (Imagine you are introducing a bug, it would be much easier to reference that in Jira as caused by)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AHeise edited a comment on pull request #17808: [FLINK-24928][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
AHeise edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970536415


   Thanks for the contribution. I cannot assess the content but looking at the size, it's safe to assume that we are not talking about a hotfix. Please create a Jira ticket and use that instead of hotfix. The ticket will be then a point where future developers can refer to. (Imagine you are introducing a bug, it would be much easier to reference that in Jira as caused by)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750479169



##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/timeline/job-timeline.component.ts
##########
@@ -143,16 +189,18 @@ export class JobTimelineComponent implements AfterViewInit, OnDestroy {
     this.mainChartInstance.tooltip({
       title: 'name'
     });
-    this.mainChartInstance.on('click', (e: SafeAny) => {
+    this.mainChartInstance.on('click', (e: { x: number; y: number }) => {
       if (this.mainChartInstance.getSnapRecords(e).length) {
-        const data = (this.mainChartInstance.getSnapRecords(e)[0] as SafeAny)._origin;
+        const data = ((this.mainChartInstance.getSnapRecords(e)[0] as unknown) as {

Review comment:
       `… as number as { _origin: }` will not work, no. The whole reason `as unknown` is in here in the first place is because TS will not let you type-assert a known type into another one when there is no overlap and it could never work. It then recommends the only way around that, which is asserting it to `unknown` first.
   
   Really this is all rather "broken", obviously the types do not match what is going on here. But I haven't (yet) addressed that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader commented on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader commented on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970538453


   @AHeise Would it be OK to create an issue and put multiple PRs on it? It'll be rather weird to create random open-ended issues that are basically all the same, so I'm wondering what the best approach for that would be. If you prefer individual issues I'm happy to do that too, though. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AHeise commented on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970546134


   It's in general okay to have multiple PRs for one issue. 
   However, at this size, I'd rather use an umbrella ticket and have smaller tasks on it like ("Improve typing in Web UI", "Reduce code clutter in X", "Increase test coverage of B") each having their own ticket.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e6db25a6c87ab4fa688edc2a5e050c8675cb336f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970479012


   @nicoweidner Thanks for the review, I addressed all your feedback, I believe. Note that I'm fully aware that this PR doesn't make things perfect – it'll take several iterations. Right now I focused on changes that do not cause behavioral changes but can be applied across the entire application (and even for that more can be done, but I have only so much time). We'll of course have to go over things in more detail in later steps and sort more things out, then ideally by adding tests as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750483455



##########
File path: flink-runtime-web/web-dashboard/src/app/share/common/dagre/svg-container.component.ts
##########
@@ -94,12 +86,12 @@ export class SvgContainerComponent implements OnInit, AfterContentInit {
           this.transform = `translate(${this.containerTransform.x} ,${this.containerTransform.y})scale(${this.containerTransform.k})`;
         }
         this.zoomEvent.emit(this.zoom);
-        this.transformEvent.emit(this.containerTransform as SafeAny);
+        this.transformEvent.emit((this.containerTransform as unknown) as { x: number; y: number; scale: number });

Review comment:
       Yes, so there is some really weird type mismatch going on between `k` and `scale` being used. You cannot type-assert this directly, the compiler won't let you because there is not enough overlap for that to ever work. The trick to assert it to `unknown` first is recommended by the compiler itself. This is definitely a symptom of something being broken, though.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] nicoweidner commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
nicoweidner commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750504080



##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/list/job-overview-list.component.ts
##########
@@ -16,12 +16,17 @@
  * limitations under the License.
  */
 
-import { Component, EventEmitter, Input, Output, ChangeDetectionStrategy, ElementRef } from '@angular/core';
+import { ChangeDetectionStrategy, Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
 
 import { NzTableSortFn } from 'ng-zorro-antd/table/src/table.types';
 
 import { NodesItemCorrectInterface } from 'interfaces';
-import { deepFind } from 'utils';
+
+function createSortFn(
+  selector: (item: NodesItemCorrectInterface) => number | string | undefined
+): NzTableSortFn<NodesItemCorrectInterface> {
+  return (pre, next) => (selector(pre)! > selector(next)! ? 1 : -1);

Review comment:
       Yes, that's why I suggested it. I just wanted to get rid of the assertions ;-)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [FLINK-24928][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609",
       "triggerID" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fd26a039df83a1cd7e64927cf08eb55633d6d1f2",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26618",
       "triggerID" : "fd26a039df83a1cd7e64927cf08eb55633d6d1f2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85fd8eeaff7f8fb59710257e0fe6289d7b34c802",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26623",
       "triggerID" : "85fd8eeaff7f8fb59710257e0fe6289d7b34c802",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fd26a039df83a1cd7e64927cf08eb55633d6d1f2 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26618) 
   * 85fd8eeaff7f8fb59710257e0fe6289d7b34c802 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26623) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750485951



##########
File path: flink-runtime-web/web-dashboard/src/app/interfaces/job-checkpoint.ts
##########
@@ -18,7 +18,7 @@
 
 import { SafeAny } from './safe-any';
 
-export interface CheckPointInterface {
+export interface CheckPoint {

Review comment:
       Sure, done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] nicoweidner commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
nicoweidner commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750160260



##########
File path: flink-runtime-web/web-dashboard/src/app/interfaces/job-checkpoint.ts
##########
@@ -18,7 +18,7 @@
 
 import { SafeAny } from './safe-any';
 
-export interface CheckPointInterface {
+export interface CheckPoint {

Review comment:
       Hm... this should always be `Checkpoint`, right? Since this seems to be widespread and was also spelled wrong before, fix if you like...

##########
File path: flink-runtime-web/web-dashboard/src/app/share/common/dagre/graph.ts
##########
@@ -40,10 +40,12 @@ export interface LayoutNodeOptions {
   focused: boolean;
 }
 
-export interface LayoutLink extends NodesItemLinkInterface {
-  [key: string]: SafeAny;
+export interface LayoutLink extends NodesItemLink {
+  [key: string]: unknown;
 
-  detail: SafeAny;
+  detail: {
+    [key: string]: unknown;
+  };

Review comment:
       Isn't this just `Record<string, unknown>`?
   
   

##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/subtask/job-checkpoints-subtask.component.ts
##########
@@ -40,31 +55,42 @@ import { deepFind } from 'utils';
   changeDetection: ChangeDetectionStrategy.OnPush
 })
 export class JobCheckpointsSubtaskComponent implements OnInit, OnChanges {
-  @Input() vertex: VerticesItemInterface;
-  @Input() checkPointId: number;
-  jobDetail: JobDetailCorrectInterface;
-  subTaskCheckPoint: CheckPointSubTaskInterface;
-  listOfSubTaskCheckPoint: Array<{ index: number; status: string }> = [];
-  isLoading = true;
-  sortName: string;
-  sortValue: string;
+  @Input() public vertex: VerticesItem;
+  @Input() public checkPointId: number;
+
+  public jobDetail: JobDetailCorrect;
+  public subTaskCheckPoint: CheckPointSubTask;
+  public listOfSubTaskCheckPoint: SubTaskCheckPointStatisticsItem[] = [];
+  public isLoading = true;
+  public sortName: string;
+  public sortValue: string;
 
-  sortAckTimestampFn = this.sortFn('ack_timestamp');
-  sortEndToEndDurationFn = this.sortFn('end_to_end_duration');
-  sortStateSizeFn = this.sortFn('state_size');
-  sortCpSyncFn = this.sortFn('checkpoint.sync');
-  sortCpAsyncFn = this.sortFn('checkpoint.async');
-  sortAlignmentProcessedFn = this.sortFn('alignment.processed');
-  sortAlignmentDurationFn = this.sortFn('alignment.duration');
-  sortStartDelayFn = this.sortFn('start_delay');
-  sortUnalignedCpFn = this.sortFn('unaligned_checkpoint');
+  public readonly sortAckTimestampFn = createSortFn(item => item.ack_timestamp);
+  public readonly sortEndToEndDurationFn = createSortFn(item => item.end_to_end_duration);
+  public readonly sortStateSizeFn = createSortFn(item => item.state_size);
+  public readonly sortCpSyncFn = createSortFn(item => item.checkpoint?.sync);

Review comment:
       If anything is undefined, are we comparing deterministically? This probably boils down to whether we compare the items in a deterministic order. Do these sort functions support a result of 0 as "leave order unchanged"?

##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/timeline/job-timeline.component.ts
##########
@@ -143,16 +189,18 @@ export class JobTimelineComponent implements AfterViewInit, OnDestroy {
     this.mainChartInstance.tooltip({
       title: 'name'
     });
-    this.mainChartInstance.on('click', (e: SafeAny) => {
+    this.mainChartInstance.on('click', (e: { x: number; y: number }) => {
       if (this.mainChartInstance.getSnapRecords(e).length) {
-        const data = (this.mainChartInstance.getSnapRecords(e)[0] as SafeAny)._origin;
+        const data = ((this.mainChartInstance.getSnapRecords(e)[0] as unknown) as {

Review comment:
       ... can we really not avoid typing this as `number[0]` and then later on typecasting it to access `._origin` after all?

##########
File path: flink-runtime-web/web-dashboard/src/app/pages/submit/submit.component.ts
##########
@@ -71,24 +113,14 @@ export class SubmitComponent implements OnInit, OnDestroy {
     );
   }
 
-  /**
-   * Delete jar
-   *
-   * @param jar
-   */

Review comment:
       How is anyone supposed to understand what these functions do now, without the docs?

##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/list/job-overview-list.component.ts
##########
@@ -16,12 +16,17 @@
  * limitations under the License.
  */
 
-import { Component, EventEmitter, Input, Output, ChangeDetectionStrategy, ElementRef } from '@angular/core';
+import { ChangeDetectionStrategy, Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
 
 import { NzTableSortFn } from 'ng-zorro-antd/table/src/table.types';
 
 import { NodesItemCorrectInterface } from 'interfaces';
-import { deepFind } from 'utils';
+
+function createSortFn(
+  selector: (item: NodesItemCorrectInterface) => number | string | undefined
+): NzTableSortFn<NodesItemCorrectInterface> {
+  return (pre, next) => (selector(pre)! > selector(next)! ? 1 : -1);

Review comment:
       Are we declaring that `selector` can return undefined, but then asserting that it does not?

##########
File path: flink-runtime-web/web-dashboard/src/app/share/common/dagre/svg-container.component.ts
##########
@@ -32,7 +32,8 @@ import * as d3 from 'd3';
 import { select, Selection } from 'd3-selection';
 import { zoom, ZoomBehavior } from 'd3-zoom';
 
-import { SafeAny } from 'interfaces';
+/* eslint-disable-next-line @typescript-eslint/no-explicit-any */
+export type SafeAny = any;

Review comment:
       No way to remove this?

##########
File path: flink-runtime-web/web-dashboard/src/app/interfaces/job-checkpoint.ts
##########
@@ -113,7 +111,7 @@ export interface CheckPointTaskStatistics {
 }
 
 export interface CheckPointConfig {
-  mode: SafeAny;
+  mode: 'exactly_once' | string;

Review comment:
       Why the special role for `exactly_once`?

##########
File path: flink-runtime-web/web-dashboard/src/app/interfaces/job-detail.ts
##########
@@ -149,12 +147,12 @@ export interface NodesItemLinkInterface {
   local_strategy?: string;
 }
 
-export interface JobDetailCorrectInterface extends JobDetailInterface {
+export interface JobDetailCorrect extends JobDetail {

Review comment:
       I am rather amused by interface names such as this one...

##########
File path: flink-runtime-web/web-dashboard/src/app/share/common/dagre/svg-container.component.ts
##########
@@ -94,12 +86,12 @@ export class SvgContainerComponent implements OnInit, AfterContentInit {
           this.transform = `translate(${this.containerTransform.x} ,${this.containerTransform.y})scale(${this.containerTransform.k})`;
         }
         this.zoomEvent.emit(this.zoom);
-        this.transformEvent.emit(this.containerTransform as SafeAny);
+        this.transformEvent.emit((this.containerTransform as unknown) as { x: number; y: number; scale: number });

Review comment:
       Why the weird double casting? I looked this one up as an example (since there were so many cases), and `containerTransform` has properties `x`, `y`, `k`. The latter might mean the same as `scale`, but here `scale` will just be undefined, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e6db25a6c87ab4fa688edc2a5e050c8675cb336f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597) 
   * 873d727b7155e2be6737354ab971c08971e2fb68 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AHeise commented on pull request #17808: [FLINK-24928][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-975311260


   My pleasure. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e6db25a6c87ab4fa688edc2a5e050c8675cb336f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e6db25a6c87ab4fa688edc2a5e050c8675cb336f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597) 
   * 873d727b7155e2be6737354ab971c08971e2fb68 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader commented on pull request #17808: [FLINK-24928][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader commented on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-972611394


   @AHeise And the CI has passed again now, too. :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609",
       "triggerID" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fd26a039df83a1cd7e64927cf08eb55633d6d1f2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26618",
       "triggerID" : "fd26a039df83a1cd7e64927cf08eb55633d6d1f2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ec014a9f6d9d5b409c3c5da395f77c0f29db7a85 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609) 
   * fd26a039df83a1cd7e64927cf08eb55633d6d1f2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26618) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750481939



##########
File path: flink-runtime-web/web-dashboard/src/app/share/common/dagre/svg-container.component.ts
##########
@@ -32,7 +32,8 @@ import * as d3 from 'd3';
 import { select, Selection } from 'd3-selection';
 import { zoom, ZoomBehavior } from 'd3-zoom';
 
-import { SafeAny } from 'interfaces';
+/* eslint-disable-next-line @typescript-eslint/no-explicit-any */
+export type SafeAny = any;

Review comment:
       We don't need to export this type, though, that I will change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] nicoweidner commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
nicoweidner commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750495888



##########
File path: flink-runtime-web/web-dashboard/src/app/pages/submit/submit.component.ts
##########
@@ -71,24 +113,14 @@ export class SubmitComponent implements OnInit, OnDestroy {
     );
   }
 
-  /**
-   * Delete jar
-   *
-   * @param jar
-   */

Review comment:
       Only if you add these lines as well:
   ```
        * @return void
        * @see JarFilesItem
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader edited a comment on pull request #17808: [FLINK-24928][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970590555






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609",
       "triggerID" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e6db25a6c87ab4fa688edc2a5e050c8675cb336f Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597) 
   * 873d727b7155e2be6737354ab971c08971e2fb68 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605) 
   * ec014a9f6d9d5b409c3c5da395f77c0f29db7a85 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750473428



##########
File path: flink-runtime-web/web-dashboard/src/app/interfaces/job-checkpoint.ts
##########
@@ -113,7 +111,7 @@ export interface CheckPointTaskStatistics {
 }
 
 export interface CheckPointConfig {
-  mode: SafeAny;
+  mode: 'exactly_once' | string;

Review comment:
       That's the only value I could find in the code, but I assume there's more, so I documented the known value and played it safe (IDEs can still auto-complete that value).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750500781



##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/list/job-overview-list.component.ts
##########
@@ -16,12 +16,17 @@
  * limitations under the License.
  */
 
-import { Component, EventEmitter, Input, Output, ChangeDetectionStrategy, ElementRef } from '@angular/core';
+import { ChangeDetectionStrategy, Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
 
 import { NzTableSortFn } from 'ng-zorro-antd/table/src/table.types';
 
 import { NodesItemCorrectInterface } from 'interfaces';
-import { deepFind } from 'utils';
+
+function createSortFn(
+  selector: (item: NodesItemCorrectInterface) => number | string | undefined
+): NzTableSortFn<NodesItemCorrectInterface> {
+  return (pre, next) => (selector(pre)! > selector(next)! ? 1 : -1);

Review comment:
       No need to – a comparison with `undefined` on either side will always yield `false` (and thus lead to `-1`) anyway.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] nicoweidner commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
nicoweidner commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750502031



##########
File path: flink-runtime-web/web-dashboard/src/app/share/common/dagre/svg-container.component.ts
##########
@@ -94,12 +86,12 @@ export class SvgContainerComponent implements OnInit, AfterContentInit {
           this.transform = `translate(${this.containerTransform.x} ,${this.containerTransform.y})scale(${this.containerTransform.k})`;
         }
         this.zoomEvent.emit(this.zoom);
-        this.transformEvent.emit(this.containerTransform as SafeAny);
+        this.transformEvent.emit((this.containerTransform as unknown) as { x: number; y: number; scale: number });

Review comment:
       Ok, I was just confused by the weird type mismatches going on, but as you said - let's fix it some other time




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [FLINK-24928][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609",
       "triggerID" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fd26a039df83a1cd7e64927cf08eb55633d6d1f2",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26618",
       "triggerID" : "fd26a039df83a1cd7e64927cf08eb55633d6d1f2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85fd8eeaff7f8fb59710257e0fe6289d7b34c802",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26623",
       "triggerID" : "85fd8eeaff7f8fb59710257e0fe6289d7b34c802",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 85fd8eeaff7f8fb59710257e0fe6289d7b34c802 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26623) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AHeise merged pull request #17808: [FLINK-24928][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
AHeise merged pull request #17808:
URL: https://github.com/apache/flink/pull/17808


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader commented on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader commented on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970479012


   @nicoweidner Thanks for the review, I addressed all your feedback, I believe. Note that I'm fully aware that this PR doesn't make things perfect – it'll take several iterations. Right now I focused on changes that do not cause behavioral changes but can be applied across the entire application. We'll of course have to go over things in more detail in later steps and sort more things out, then ideally by adding tests as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750480151



##########
File path: flink-runtime-web/web-dashboard/src/app/pages/submit/submit.component.ts
##########
@@ -71,24 +113,14 @@ export class SubmitComponent implements OnInit, OnDestroy {
     );
   }
 
-  /**
-   * Delete jar
-   *
-   * @param jar
-   */

Review comment:
       Would you like me to add them back? :-)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] nicoweidner commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
nicoweidner commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750499397



##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/timeline/job-timeline.component.ts
##########
@@ -143,16 +189,18 @@ export class JobTimelineComponent implements AfterViewInit, OnDestroy {
     this.mainChartInstance.tooltip({
       title: 'name'
     });
-    this.mainChartInstance.on('click', (e: SafeAny) => {
+    this.mainChartInstance.on('click', (e: { x: number; y: number }) => {
       if (this.mainChartInstance.getSnapRecords(e).length) {
-        const data = (this.mainChartInstance.getSnapRecords(e)[0] as SafeAny)._origin;
+        const data = ((this.mainChartInstance.getSnapRecords(e)[0] as unknown) as {

Review comment:
       Sorry, my message was a bit garbled. What I meant to point out was that it's rather strange that we apparently have a `number[]`, but then suddenly access property `._origin`. But you already addressed that in your answer




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] nicoweidner commented on a change in pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
nicoweidner commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750498215



##########
File path: flink-runtime-web/web-dashboard/src/app/interfaces/job-checkpoint.ts
##########
@@ -113,7 +111,7 @@ export interface CheckPointTaskStatistics {
 }
 
 export interface CheckPointConfig {
-  mode: SafeAny;
+  mode: 'exactly_once' | string;

Review comment:
       There seems to be only this and `at_least_once` in Flink, but yeah, not for this PR to resolve...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Airblader commented on pull request #17808: [FLINK-24928][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
Airblader commented on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970590555


   @AHeise Fair enough, thanks. I've created an umbrella and made this PR a sub-task thereof (https://issues.apache.org/jira/browse/FLINK-24928). I'm not sure if the JIRA will link up the PR with the issue after the fact now, though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e6db25a6c87ab4fa688edc2a5e050c8675cb336f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597) 
   * 873d727b7155e2be6737354ab971c08971e2fb68 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605) 
   * ec014a9f6d9d5b409c3c5da395f77c0f29db7a85 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e6db25a6c87ab4fa688edc2a5e050c8675cb336f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597) 
   * 873d727b7155e2be6737354ab971c08971e2fb68 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605) 
   * ec014a9f6d9d5b409c3c5da395f77c0f29db7a85 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [FLINK-24928][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609",
       "triggerID" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fd26a039df83a1cd7e64927cf08eb55633d6d1f2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26618",
       "triggerID" : "fd26a039df83a1cd7e64927cf08eb55633d6d1f2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85fd8eeaff7f8fb59710257e0fe6289d7b34c802",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26623",
       "triggerID" : "85fd8eeaff7f8fb59710257e0fe6289d7b34c802",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ec014a9f6d9d5b409c3c5da395f77c0f29db7a85 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609) 
   * fd26a039df83a1cd7e64927cf08eb55633d6d1f2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26618) 
   * 85fd8eeaff7f8fb59710257e0fe6289d7b34c802 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26623) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [FLINK-24928][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609",
       "triggerID" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fd26a039df83a1cd7e64927cf08eb55633d6d1f2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26618",
       "triggerID" : "fd26a039df83a1cd7e64927cf08eb55633d6d1f2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85fd8eeaff7f8fb59710257e0fe6289d7b34c802",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "85fd8eeaff7f8fb59710257e0fe6289d7b34c802",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ec014a9f6d9d5b409c3c5da395f77c0f29db7a85 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26609) 
   * fd26a039df83a1cd7e64927cf08eb55633d6d1f2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26618) 
   * 85fd8eeaff7f8fb59710257e0fe6289d7b34c802 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #17808: [FLINK-24928][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-974894700


   @AHeise Please merge :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e6db25a6c87ab4fa688edc2a5e050c8675cb336f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597) 
   * 873d727b7155e2be6737354ab971c08971e2fb68 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17808: [hotfix][flink-runtime-web] Typing improvements for Flink UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17808:
URL: https://github.com/apache/flink/pull/17808#issuecomment-970131146


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597",
       "triggerID" : "e6db25a6c87ab4fa688edc2a5e050c8675cb336f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605",
       "triggerID" : "873d727b7155e2be6737354ab971c08971e2fb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ec014a9f6d9d5b409c3c5da395f77c0f29db7a85",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e6db25a6c87ab4fa688edc2a5e050c8675cb336f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26597) 
   * 873d727b7155e2be6737354ab971c08971e2fb68 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26605) 
   * ec014a9f6d9d5b409c3c5da395f77c0f29db7a85 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org