You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Richard S. Hall (JIRA)" <ji...@apache.org> on 2009/12/04 18:32:20 UTC
[jira] Created: (FELIX-1920) RequiredBundle.getRequiringBundles()
incorrectly calculates result
RequiredBundle.getRequiringBundles() incorrectly calculates result
------------------------------------------------------------------
Key: FELIX-1920
URL: https://issues.apache.org/jira/browse/FELIX-1920
Project: Felix
Issue Type: Bug
Components: Framework, Specification compliance
Affects Versions: felix-2.0.2
Reporter: Richard S. Hall
Assignee: Richard S. Hall
Fix For: felix-2.2.0
Alan Keane noticed:
---
Is the following a bug?
Index: RequiredBundleImpl.java
===================================================================
--- RequiredBundleImpl.java (revision 886835)
+++ RequiredBundleImpl.java (working copy)
@@ -74,7 +74,7 @@
IModule[] dependents = ((ModuleImpl)
modules[modIdx]).getDependentRequirers();
for (int depIdx = 0; (dependents != null) && (depIdx <
dependents.length); depIdx++)
{
- moduleList.add(dependents[modIdx]);
+ moduleList.add(dependents[depIdx]);
}
Thanks,
Alan
---
It certainly appears to be a bug and clearly could lead to bad results.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (FELIX-1920) RequiredBundle.getRequiringBundles()
incorrectly calculates result
Posted by "Richard S. Hall" <he...@ungoverned.org>.
No problem. Thanks for checking the patch! Definitely keep reporting any
issues you uncover.
-> richard
On 12/4/09 13:10, Alan Keane wrote:
> Thanks Richard..
>
> Apologies, I should have sent to this mailing list.
> I tested with that update locally on the same set of bundles and all looks
> fine now.
>
> Alan
>
> On Fri, Dec 4, 2009 at 5:42 PM, Richard S. Hall (JIRA)<ji...@apache.org>wrote:
>
>
>> [
>> https://issues.apache.org/jira/browse/FELIX-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>>
>> Richard S. Hall resolved FELIX-1920.
>> ------------------------------------
>>
>> Resolution: Fixed
>>
>> I committed a fix for this and improved the method a little in the process
>> too.
>>
>>
>>> RequiredBundle.getRequiringBundles() incorrectly calculates result
>>> ------------------------------------------------------------------
>>>
>>> Key: FELIX-1920
>>> URL: https://issues.apache.org/jira/browse/FELIX-1920
>>> Project: Felix
>>> Issue Type: Bug
>>> Components: Framework, Specification compliance
>>> Affects Versions: felix-2.0.2
>>> Reporter: Richard S. Hall
>>> Assignee: Richard S. Hall
>>> Fix For: felix-2.2.0
>>>
>>>
>>> Alan Keane noticed:
>>> ---
>>> Is the following a bug?
>>> Index: RequiredBundleImpl.java
>>> ===================================================================
>>> --- RequiredBundleImpl.java (revision 886835)
>>> +++ RequiredBundleImpl.java (working copy)
>>> @@ -74,7 +74,7 @@
>>> IModule[] dependents = ((ModuleImpl)
>>> modules[modIdx]).getDependentRequirers();
>>> for (int depIdx = 0; (dependents != null)&& (depIdx<
>>> dependents.length); depIdx++)
>>> {
>>> - moduleList.add(dependents[modIdx]);
>>> + moduleList.add(dependents[depIdx]);
>>> }
>>> Thanks,
>>> Alan
>>> ---
>>> It certainly appears to be a bug and clearly could lead to bad results.
>>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>>
>
Re: [jira] Resolved: (FELIX-1920) RequiredBundle.getRequiringBundles()
incorrectly calculates result
Posted by Alan Keane <al...@gmail.com>.
Thanks Richard..
Apologies, I should have sent to this mailing list.
I tested with that update locally on the same set of bundles and all looks
fine now.
Alan
On Fri, Dec 4, 2009 at 5:42 PM, Richard S. Hall (JIRA) <ji...@apache.org>wrote:
>
> [
> https://issues.apache.org/jira/browse/FELIX-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Richard S. Hall resolved FELIX-1920.
> ------------------------------------
>
> Resolution: Fixed
>
> I committed a fix for this and improved the method a little in the process
> too.
>
> > RequiredBundle.getRequiringBundles() incorrectly calculates result
> > ------------------------------------------------------------------
> >
> > Key: FELIX-1920
> > URL: https://issues.apache.org/jira/browse/FELIX-1920
> > Project: Felix
> > Issue Type: Bug
> > Components: Framework, Specification compliance
> > Affects Versions: felix-2.0.2
> > Reporter: Richard S. Hall
> > Assignee: Richard S. Hall
> > Fix For: felix-2.2.0
> >
> >
> > Alan Keane noticed:
> > ---
> > Is the following a bug?
> > Index: RequiredBundleImpl.java
> > ===================================================================
> > --- RequiredBundleImpl.java (revision 886835)
> > +++ RequiredBundleImpl.java (working copy)
> > @@ -74,7 +74,7 @@
> > IModule[] dependents = ((ModuleImpl)
> > modules[modIdx]).getDependentRequirers();
> > for (int depIdx = 0; (dependents != null) && (depIdx <
> > dependents.length); depIdx++)
> > {
> > - moduleList.add(dependents[modIdx]);
> > + moduleList.add(dependents[depIdx]);
> > }
> > Thanks,
> > Alan
> > ---
> > It certainly appears to be a bug and clearly could lead to bad results.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Resolved: (FELIX-1920) RequiredBundle.getRequiringBundles()
incorrectly calculates result
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard S. Hall resolved FELIX-1920.
------------------------------------
Resolution: Fixed
I committed a fix for this and improved the method a little in the process too.
> RequiredBundle.getRequiringBundles() incorrectly calculates result
> ------------------------------------------------------------------
>
> Key: FELIX-1920
> URL: https://issues.apache.org/jira/browse/FELIX-1920
> Project: Felix
> Issue Type: Bug
> Components: Framework, Specification compliance
> Affects Versions: felix-2.0.2
> Reporter: Richard S. Hall
> Assignee: Richard S. Hall
> Fix For: felix-2.2.0
>
>
> Alan Keane noticed:
> ---
> Is the following a bug?
> Index: RequiredBundleImpl.java
> ===================================================================
> --- RequiredBundleImpl.java (revision 886835)
> +++ RequiredBundleImpl.java (working copy)
> @@ -74,7 +74,7 @@
> IModule[] dependents = ((ModuleImpl)
> modules[modIdx]).getDependentRequirers();
> for (int depIdx = 0; (dependents != null) && (depIdx <
> dependents.length); depIdx++)
> {
> - moduleList.add(dependents[modIdx]);
> + moduleList.add(dependents[depIdx]);
> }
> Thanks,
> Alan
> ---
> It certainly appears to be a bug and clearly could lead to bad results.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-1920) RequiredBundle.getRequiringBundles()
incorrectly calculates result
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard S. Hall closed FELIX-1920.
----------------------------------
> RequiredBundle.getRequiringBundles() incorrectly calculates result
> ------------------------------------------------------------------
>
> Key: FELIX-1920
> URL: https://issues.apache.org/jira/browse/FELIX-1920
> Project: Felix
> Issue Type: Bug
> Components: Framework, Specification compliance
> Affects Versions: felix-2.0.2
> Reporter: Richard S. Hall
> Assignee: Richard S. Hall
> Fix For: felix-2.2.0
>
>
> Alan Keane noticed:
> ---
> Is the following a bug?
> Index: RequiredBundleImpl.java
> ===================================================================
> --- RequiredBundleImpl.java (revision 886835)
> +++ RequiredBundleImpl.java (working copy)
> @@ -74,7 +74,7 @@
> IModule[] dependents = ((ModuleImpl)
> modules[modIdx]).getDependentRequirers();
> for (int depIdx = 0; (dependents != null) && (depIdx <
> dependents.length); depIdx++)
> {
> - moduleList.add(dependents[modIdx]);
> + moduleList.add(dependents[depIdx]);
> }
> Thanks,
> Alan
> ---
> It certainly appears to be a bug and clearly could lead to bad results.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.