You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/23 08:06:28 UTC
[GitHub] [spark] HeartSaVioR opened a new pull request, #37258: [DO-NOT-MERGE] trigger CI
HeartSaVioR opened a new pull request, #37258:
URL: https://github.com/apache/spark/pull/37258
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #37258: [DO-NOT-MERGE] trigger CI
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #37258:
URL: https://github.com/apache/spark/pull/37258#issuecomment-1193116170
I'm only targeting to sql-others as I see almost consistent failure in sql-others, though I had to touch some code here to trigger test run. Are you investigating the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37258: [DO-NOT-MERGE] trigger CI
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37258:
URL: https://github.com/apache/spark/pull/37258#issuecomment-1193500196
Made a PR for TPC-DS https://github.com/apache/spark/pull/37270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37258: [DO-NOT-MERGE] trigger CI
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37258:
URL: https://github.com/apache/spark/pull/37258#issuecomment-1198825739
> Sorry for late reply, I'm busy in some local meeting recent days.
>
> > In addition, can we get the content of dmesg?
>
> @LuciferYang We can add a separate step like:
>
> ```
> - name: Print debug info
> if: failure()
> run: |
> # print demsg info
> ```
Thanks for your reply, I have tested, the account executing GA should not have permission to execute `demsg` and GA test should already stability now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37258: [DO-NOT-MERGE] trigger CI
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37258:
URL: https://github.com/apache/spark/pull/37258#issuecomment-1193101634
To solve the stability of `sql-others`, `hive-others` and `tpcds`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37258: [DO-NOT-MERGE] trigger CI
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37258:
URL: https://github.com/apache/spark/pull/37258#issuecomment-1193257070
Seems like TPC-DS consistently fails too most likely because of out-of-memory. I worked around this by splitting the queries to run but .. it'd be great if we can find a way to fix this up. I'll likely take a look too around early next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #37258: [DO-NOT-MERGE] trigger CI
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37258: [DO-NOT-MERGE] trigger CI
URL: https://github.com/apache/spark/pull/37258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37258: [DO-NOT-MERGE] trigger CI
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37258:
URL: https://github.com/apache/spark/pull/37258#issuecomment-1198843792
Let me close this one. I believe all are fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37258: [DO-NOT-MERGE] trigger CI
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37258:
URL: https://github.com/apache/spark/pull/37258#issuecomment-1193501200
```
sbt.ForkMain 34895 failed with exit code 137[0m
2022-07-24T06:25:51.5368193Z [0m[[0m[33mwarn[0m] [0m[0mIn the last 5506 seconds, 21.985 (0.4%) were spent in GC. [Heap: 2.99GB free of 3.62GB, max 3.62GB] Consider increasing the JVM heap using `-Xmx` or try a different collector, e.g. `-XX:+UseG1GC`, for better performance.[0m
```
Sorry for the late reply, I found that before GA task was killed, there would be logs like the one above, can we try to increase `-Xmx`?
In addition, can we get the content of `dmesg`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #37258: [DO-NOT-MERGE] trigger CI
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37258:
URL: https://github.com/apache/spark/pull/37258#issuecomment-1198812267
Sorry for late reply, I'm busy in some local meeting recent days.
> In addition, can we get the content of dmesg?
@LuciferYang We can add a separate step like:
```
- name: Print debug info
if: failure()
run: |
# print demsg info
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37258: [DO-NOT-MERGE] trigger CI
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37258:
URL: https://github.com/apache/spark/pull/37258#issuecomment-1195084600
https://github.com/apache/spark/blob/72b55ccf8327c00e173ab6130fdb428ad0d5aacc/project/SparkBuild.scala#L1194-L1199
I change the 2 `-Xmx4g` in `SparkBuild.scala` to `-Xmx3200m` and add `-XX:+UseG1GC` options, but still found logs as follows:
```
sbt.ForkMain 42403 failed with exit code 137
2022-07-26T05:27:04.8785522Z [warn] In the last 3341 seconds, 19.769 (0.6%) were spent in GC. [Heap: 3.28GB free of 3.99GB, max 3.99GB] Consider increasing the JVM heap using `-Xmx` or try a different collector, e.g. `-XX:+UseG1GC`, for better performance.
2022-07-26T05:27:06.9932313Z [error] (hive / Test / test) sbt.TestsFailedException: Tests unsuccessful
2022-07-26T05:27:07.0186283Z [error] Total time: 3343 s (55:43), completed Jul 26, 2022 5:27:07 AM
2022-07-26T05:27:07.7573628Z [error] running /home/runner/work/spark/spark/build/sbt -Phadoop-3 -Phive -Dtest.include.tags=org.apache.spark.tags.SlowHiveTest hive/test ; received return code 1
```
The max heap size still 4GB, it doesn't seem understandable,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37258: [DO-NOT-MERGE] trigger CI
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37258:
URL: https://github.com/apache/spark/pull/37258#issuecomment-1194865358
cc @Yikun too FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org