You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/29 17:54:20 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request #794: Fix: Update clippy lints for Rust 1.54

alamb opened a new pull request #794:
URL: https://github.com/apache/arrow-datafusion/pull/794


   # Rationale:
   
   It's that time again! [Rust released 1.54 today](https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1540-2021-07-29) which causes some additional clippy errors:
   
   If you run clippy on master after running `rustup update` you get erros such as the following
   
   ```
   error: this expression borrows a reference (`&datafusion::logical_plan::JoinType`) that is immediately dereferenced by the compiler
      --> ballista/rust/core/src/serde/physical_plan/mod.rs:108:21
       |
   108 |                     &join_type,
       |                     ^^^^^^^^^^ help: change this to: `join_type`
       |
       = note: `-D clippy::needless-borrow` implied by `-D warnings`
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   
   error: aborting due to previous error
   
   error: this expression borrows a reference (`&ballista_core::config::BallistaConfig`) that is immediately dereferenced by the compiler
      --> ballista/rust/client/src/context.rs:136:13
       |
   136 |             &guard.config(),
       |             ^^^^^^^^^^^^^^^ help: change this to: `guard.config()`
       |
       = note: `-D clippy::needless-borrow` implied by `-D warnings`
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   
   ...
   
   ```
   
   # Changes:
   
   1. Fix clippy errors
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan commented on pull request #794: Fix: Update clippy lints for Rust 1.54

Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #794:
URL: https://github.com/apache/arrow-datafusion/pull/794#issuecomment-889359460


   Thanks @alamb for fixing it so fast


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #794: Fix: Update clippy lints for Rust 1.54

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #794:
URL: https://github.com/apache/arrow-datafusion/pull/794#issuecomment-889367618


   👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #794: Fix: Update clippy lints for Rust 1.54

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #794:
URL: https://github.com/apache/arrow-datafusion/pull/794#issuecomment-889409042


   LOL here is a sister PR for arrow-rs https://github.com/apache/arrow-rs/pull/631 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan merged pull request #794: Fix: Update clippy lints for Rust 1.54

Posted by GitBox <gi...@apache.org>.
Dandandan merged pull request #794:
URL: https://github.com/apache/arrow-datafusion/pull/794


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org