You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/29 08:49:30 UTC
[GitHub] [dubbo-go] YuzeZhang opened a new pull request #545: Add comments for config_center
YuzeZhang opened a new pull request #545:
URL: https://github.com/apache/dubbo-go/pull/545
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
Add comments for config_center
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #545: Add comments for config_center
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #545:
URL: https://github.com/apache/dubbo-go/pull/545#issuecomment-635880267
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=h1) Report
> Merging [#545](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go/commit/8a3c02c9b7737a12712451b16a3cdc8ce46a5c7d&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #545 +/- ##
==========================================
- Coverage 67.20% 67.18% -0.03%
==========================================
Files 174 174
Lines 9261 9261
==========================================
- Hits 6224 6222 -2
- Misses 2432 2434 +2
Partials 605 605
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/apollo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vbGlzdGVuZXIuZ28=) | `100.00% <ø> (ø)` | |
| [config\_center/configurator/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3IvbW9jay5nbw==) | `0.00% <ø> (ø)` | |
| [config\_center/parser/configuration\_parser.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9wYXJzZXIvY29uZmlndXJhdGlvbl9wYXJzZXIuZ28=) | `2.25% <ø> (ø)` | |
| [config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=) | `73.91% <ø> (ø)` | |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <0.00%> (-3.39%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=footer). Last update [8a3c02c...ee0ff17](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #545: Add comments for config_center
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #545:
URL: https://github.com/apache/dubbo-go/pull/545#discussion_r432377779
##########
File path: config_center/apollo/listener.go
##########
@@ -29,7 +29,7 @@ type apolloListener struct {
listeners map[config_center.ConfigurationListener]struct{}
}
-// NewApolloListener ...
+// NewApolloListener new an apolloListener
Review comment:
```suggestion
// NewApolloListener creates a new apolloListener
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx merged pull request #545: Add comments for config_center
Posted by GitBox <gi...@apache.org>.
zouyx merged pull request #545:
URL: https://github.com/apache/dubbo-go/pull/545
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #545: Add comments for config_center
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #545:
URL: https://github.com/apache/dubbo-go/pull/545#issuecomment-635880267
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=h1) Report
> Merging [#545](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/8a3c02c9b7737a12712451b16a3cdc8ce46a5c7d&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #545 +/- ##
===========================================
- Coverage 67.20% 66.92% -0.29%
===========================================
Files 174 174
Lines 9261 9261
===========================================
- Hits 6224 6198 -26
- Misses 2432 2455 +23
- Partials 605 608 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/apollo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vbGlzdGVuZXIuZ28=) | `100.00% <ø> (ø)` | |
| [config\_center/configurator/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3IvbW9jay5nbw==) | `0.00% <ø> (ø)` | |
| [config\_center/parser/configuration\_parser.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9wYXJzZXIvY29uZmlndXJhdGlvbl9wYXJzZXIuZ28=) | `2.25% <ø> (ø)` | |
| [config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=) | `73.91% <ø> (ø)` | |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `72.50% <0.00%> (-5.00%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `76.71% <0.00%> (-4.57%)` | :arrow_down: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <0.00%> (-3.39%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `68.29% <0.00%> (-2.44%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=footer). Last update [8a3c02c...517b521](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #545: Add comments for config_center
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #545:
URL: https://github.com/apache/dubbo-go/pull/545#discussion_r432377649
##########
File path: config_center/apollo/listener.go
##########
@@ -49,15 +49,15 @@ func (a *apolloListener) OnChange(changeEvent *agollo.ChangeEvent) {
}
}
-// AddListener ...
+// AddListener add a listener for apollo
Review comment:
```suggestion
// AddListener adds a listener for apollo
```
##########
File path: config_center/apollo/listener.go
##########
@@ -29,7 +29,7 @@ type apolloListener struct {
listeners map[config_center.ConfigurationListener]struct{}
}
-// NewApolloListener ...
+// NewApolloListener new an apolloListener
Review comment:
```suggestion
// NewApolloListener makes an new apolloListener
```
##########
File path: config_center/apollo/listener.go
##########
@@ -49,15 +49,15 @@ func (a *apolloListener) OnChange(changeEvent *agollo.ChangeEvent) {
}
}
-// AddListener ...
+// AddListener add a listener for apollo
func (a *apolloListener) AddListener(l config_center.ConfigurationListener) {
if _, ok := a.listeners[l]; !ok {
a.listeners[l] = struct{}{}
agollo.AddChangeListener(a)
}
}
-// RemoveListener ...
+// RemoveListener remove listeners of apollo
Review comment:
```suggestion
// RemoveListener removes listeners of apollo
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #545: Add comments for config_center
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #545:
URL: https://github.com/apache/dubbo-go/pull/545#issuecomment-635880267
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=h1) Report
> Merging [#545](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/8a3c02c9b7737a12712451b16a3cdc8ce46a5c7d&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #545 +/- ##
===========================================
- Coverage 67.20% 66.92% -0.29%
===========================================
Files 174 174
Lines 9261 9261
===========================================
- Hits 6224 6198 -26
- Misses 2432 2455 +23
- Partials 605 608 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/apollo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vbGlzdGVuZXIuZ28=) | `100.00% <ø> (ø)` | |
| [config\_center/configurator/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3IvbW9jay5nbw==) | `0.00% <ø> (ø)` | |
| [config\_center/parser/configuration\_parser.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9wYXJzZXIvY29uZmlndXJhdGlvbl9wYXJzZXIuZ28=) | `2.25% <ø> (ø)` | |
| [config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=) | `73.91% <ø> (ø)` | |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `72.50% <0.00%> (-5.00%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `76.71% <0.00%> (-4.57%)` | :arrow_down: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <0.00%> (-3.39%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `68.29% <0.00%> (-2.44%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=footer). Last update [8a3c02c...20fbbb5](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #545: Add comments for config_center
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #545:
URL: https://github.com/apache/dubbo-go/pull/545#issuecomment-635880267
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=h1) Report
> Merging [#545](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go/commit/8a3c02c9b7737a12712451b16a3cdc8ce46a5c7d&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #545 +/- ##
==========================================
- Coverage 67.20% 67.18% -0.03%
==========================================
Files 174 174
Lines 9261 9261
==========================================
- Hits 6224 6222 -2
- Misses 2432 2434 +2
Partials 605 605
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/apollo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vbGlzdGVuZXIuZ28=) | `100.00% <ø> (ø)` | |
| [config\_center/configurator/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3IvbW9jay5nbw==) | `0.00% <ø> (ø)` | |
| [config\_center/parser/configuration\_parser.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9wYXJzZXIvY29uZmlndXJhdGlvbl9wYXJzZXIuZ28=) | `2.25% <ø> (ø)` | |
| [config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=) | `73.91% <ø> (ø)` | |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <0.00%> (-3.39%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/545/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=footer). Last update [8a3c02c...20fbbb5](https://codecov.io/gh/apache/dubbo-go/pull/545?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #545: Add comments for config_center
Posted by GitBox <gi...@apache.org>.
zouyx commented on pull request #545:
URL: https://github.com/apache/dubbo-go/pull/545#issuecomment-635882810
change base to develop pls
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org