You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "chia7712 (via GitHub)" <gi...@apache.org> on 2026/04/21 08:17:08 UTC
Re: [PR] KAFKA-20506 kafka-configs.sh can't delete the config from a offline broker when using bootstrap controller [kafka]
chia7712 commented on code in PR #22104:
URL: https://github.com/apache/kafka/pull/22104#discussion_r3116009063
##########
tools/src/main/java/org/apache/kafka/tools/ConfigCommand.java:
##########
@@ -263,7 +266,7 @@ static void alterConfig(Admin adminClient, ConfigCommandOptions opts) throws IOE
throw ee;
}
} else if (BROKER_LOGGER_CONFIG_TYPE.equals(entityType)) {
- List<String> validLoggers = getResourceConfig(adminClient, entityType, entityName, true, false).stream().map(ConfigEntry::name).toList();
Review Comment:
It looks like an existing bug, as the synonyms are not actually being used. Therefore, it should pass true instead of false.
##########
tools/src/main/java/org/apache/kafka/tools/ConfigCommand.java:
##########
@@ -577,18 +580,7 @@ private static void describeResourceConfig(Admin adminClient, String entityType,
}
}
- private static void alterResourceConfig(Admin adminClient, String entityTypeHead, String entityNameHead, List<String> configsToBeDeleted, Map<String, ConfigEntry> configsToBeAdded, ConfigResource.Type resourceType) throws ExecutionException, InterruptedException, TimeoutException {
- Map<String, ConfigEntry> oldConfig = getResourceConfig(adminClient, entityTypeHead, entityNameHead, false, false)
Review Comment:
please add this changes to `upgrade.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org