You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jun Rao (JIRA)" <ji...@apache.org> on 2012/11/27 06:27:57 UTC

[jira] [Created] (KAFKA-632) ProducerRequest should take ByteBufferMessageSet instead of MessageSet

Jun Rao created KAFKA-632:
-----------------------------

             Summary: ProducerRequest should take ByteBufferMessageSet instead of MessageSet
                 Key: KAFKA-632
                 URL: https://issues.apache.org/jira/browse/KAFKA-632
             Project: Kafka
          Issue Type: Improvement
          Components: core
    Affects Versions: 0.8
            Reporter: Jun Rao


Currently, ProducerRequest takes MessageSet in the constructor and casts it to ByteBufferMessageSet. It should take ByteBufferMessageSet directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (KAFKA-632) ProducerRequest should take ByteBufferMessageSet instead of MessageSet

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jun Rao updated KAFKA-632:
--------------------------

    Attachment: kafka-632.patch

Attach a patch.
                
> ProducerRequest should take ByteBufferMessageSet instead of MessageSet
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-632
>                 URL: https://issues.apache.org/jira/browse/KAFKA-632
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>             Fix For: 0.8
>
>         Attachments: kafka-632.patch
>
>
> Currently, ProducerRequest takes MessageSet in the constructor and casts it to ByteBufferMessageSet. It should take ByteBufferMessageSet directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (KAFKA-632) ProducerRequest should take ByteBufferMessageSet instead of MessageSet

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jun Rao reassigned KAFKA-632:
-----------------------------

    Assignee: Jun Rao
    
> ProducerRequest should take ByteBufferMessageSet instead of MessageSet
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-632
>                 URL: https://issues.apache.org/jira/browse/KAFKA-632
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>             Fix For: 0.8
>
>         Attachments: kafka-632.patch
>
>
> Currently, ProducerRequest takes MessageSet in the constructor and casts it to ByteBufferMessageSet. It should take ByteBufferMessageSet directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (KAFKA-632) ProducerRequest should take ByteBufferMessageSet instead of MessageSet

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jun Rao closed KAFKA-632.
-------------------------

    
> ProducerRequest should take ByteBufferMessageSet instead of MessageSet
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-632
>                 URL: https://issues.apache.org/jira/browse/KAFKA-632
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>             Fix For: 0.8
>
>         Attachments: kafka-632.patch
>
>
> Currently, ProducerRequest takes MessageSet in the constructor and casts it to ByteBufferMessageSet. It should take ByteBufferMessageSet directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (KAFKA-632) ProducerRequest should take ByteBufferMessageSet instead of MessageSet

Posted by "Neha Narkhede (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KAFKA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505781#comment-13505781 ] 

Neha Narkhede commented on KAFKA-632:
-------------------------------------

+1
                
> ProducerRequest should take ByteBufferMessageSet instead of MessageSet
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-632
>                 URL: https://issues.apache.org/jira/browse/KAFKA-632
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>             Fix For: 0.8
>
>         Attachments: kafka-632.patch
>
>
> Currently, ProducerRequest takes MessageSet in the constructor and casts it to ByteBufferMessageSet. It should take ByteBufferMessageSet directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (KAFKA-632) ProducerRequest should take ByteBufferMessageSet instead of MessageSet

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jun Rao updated KAFKA-632:
--------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Thanks for the review. Committed to 0.8.
                
> ProducerRequest should take ByteBufferMessageSet instead of MessageSet
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-632
>                 URL: https://issues.apache.org/jira/browse/KAFKA-632
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>             Fix For: 0.8
>
>         Attachments: kafka-632.patch
>
>
> Currently, ProducerRequest takes MessageSet in the constructor and casts it to ByteBufferMessageSet. It should take ByteBufferMessageSet directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (KAFKA-632) ProducerRequest should take ByteBufferMessageSet instead of MessageSet

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jun Rao updated KAFKA-632:
--------------------------

    Fix Version/s: 0.8
           Status: Patch Available  (was: Open)
    
> ProducerRequest should take ByteBufferMessageSet instead of MessageSet
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-632
>                 URL: https://issues.apache.org/jira/browse/KAFKA-632
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>             Fix For: 0.8
>
>         Attachments: kafka-632.patch
>
>
> Currently, ProducerRequest takes MessageSet in the constructor and casts it to ByteBufferMessageSet. It should take ByteBufferMessageSet directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira