You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2023/11/20 15:22:27 UTC
[PR] Removed TabletStatistics.getSplitCreationTime SPI method [accumulo]
dlmarion opened a new pull request, #3959:
URL: https://github.com/apache/accumulo/pull/3959
Fixes #3595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed TabletStatistics.getSplitCreationTime SPI method [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #3959:
URL: https://github.com/apache/accumulo/pull/3959#issuecomment-1827831637
> Was this done?
Done in #3977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed TabletStatistics.getSplitCreationTime SPI method [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #3959:
URL: https://github.com/apache/accumulo/pull/3959#issuecomment-1819275304
I will create a follow-on task on merge to mark this method as deprecated in main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed TabletStatistics.getSplitCreationTime SPI method [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #3959:
URL: https://github.com/apache/accumulo/pull/3959#discussion_r1399908353
##########
core/src/main/java/org/apache/accumulo/core/spi/balancer/SimpleLoadBalancer.java:
##########
@@ -265,7 +265,10 @@ List<TabletMigration> move(ServerCounts tooMuch, ServerCounts tooLittle, int cou
log.error("Unable to select a tablet to move", ex);
return result;
}
- TabletId tabletId = selectTablet(onlineTabletsForTable);
+ if (onlineTabletsForTable.isEmpty()) {
+ return result;
+ }
+ TabletId tabletId = onlineTabletsForTable.keySet().iterator().next();
Review Comment:
Can probably remove the `if (tabletId == null) { return result;}` a few lines down. The new `if (onlineTabletsForTable.isEmpty()) {` a few lines above probably covers the case it was covering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed TabletStatistics.getSplitCreationTime SPI method [accumulo]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #3959:
URL: https://github.com/apache/accumulo/pull/3959#issuecomment-1821831494
> I will create a follow-on task on merge to mark this method as deprecated in main.
Was this done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed TabletStatistics.getSplitCreationTime SPI method [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #3959:
URL: https://github.com/apache/accumulo/pull/3959#discussion_r1400953161
##########
core/src/main/java/org/apache/accumulo/core/spi/balancer/SimpleLoadBalancer.java:
##########
@@ -265,7 +265,10 @@ List<TabletMigration> move(ServerCounts tooMuch, ServerCounts tooLittle, int cou
log.error("Unable to select a tablet to move", ex);
return result;
}
- TabletId tabletId = selectTablet(onlineTabletsForTable);
+ if (onlineTabletsForTable.isEmpty()) {
+ return result;
+ }
+ TabletId tabletId = onlineTabletsForTable.keySet().iterator().next();
Review Comment:
Removed the other `if` in b82d5e3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed TabletStatistics.getSplitCreationTime SPI method [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #3959:
URL: https://github.com/apache/accumulo/pull/3959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org