You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "comphead (via GitHub)" <gi...@apache.org> on 2024/06/12 00:03:03 UTC

[I] SMJ: incorrect result for filtered right outer join [datafusion]

comphead opened a new issue, #10882:
URL: https://github.com/apache/datafusion/issues/10882

   ### Describe the bug
   
   It seems DF not correctly handling the right filtered join.
   
   ### To Reproduce
   
   ```
   #[tokio::test]
       async fn test_smj_right_filtered() -> Result<()> {
           let ctx: SessionContext = SessionContext::new();
   
           let sql = "set datafusion.optimizer.prefer_hash_join = false;";
           let _ = ctx.sql(sql).await?.collect().await?;
   
           let sql = "set datafusion.execution.batch_size = 100";
           let _ = ctx.sql(sql).await?.collect().await?;
   
           let sql = "
               select * from (
               with t as (
                   select id, id % 5 id1 from (select unnest(range(0,10)) id)
               ), t1 as (
                   select id % 10 id, id + 2 id1 from (select unnest(range(0,10)) id)
               )
               select * from  t right join  t1 on t.id1 = t1.id and t.id > t1.id1
               ) order by 1, 2, 3, 4
           ";
   
           let actual = ctx.sql(sql).await?.collect().await?;
   
           let expected: Vec<&str> = vec![
               "+----+-----+----+-----+",
               "| id | id1 | id | id1 |",
               "+----+-----+----+-----+",
               "| 5  | 0   | 0  | 2   |",
               "| 6  | 1   | 1  | 3   |",
               "| 7  | 2   | 2  | 4   |",
               "| 8  | 3   | 3  | 5   |",
               "| 9  | 4   | 4  | 6   |",
               "|    |     | 5  | 7   |",
               "|    |     | 6  | 8   |",
               "|    |     | 7  | 9   |",
               "|    |     | 8  | 10  |",
               "|    |     | 9  | 11  |",
               "+----+-----+----+-----+",
           ];
           datafusion_common::assert_batches_eq!(expected, &actual);
   
           Ok(())
       }
   ```
   
   ### Expected behavior
   
   Test should pass
   
   ### Additional context
   
   Found in https://github.com/apache/datafusion-comet/pull/553


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] SMJ: incorrect result for filtered right outer join [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #10882: SMJ: incorrect result for filtered right outer join
URL: https://github.com/apache/datafusion/issues/10882


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] SMJ: incorrect result for filtered right outer join [datafusion]

Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on issue #10882:
URL: https://github.com/apache/datafusion/issues/10882#issuecomment-2161834369

   I'm looking this for Comet issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org