You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "peterxcli (via GitHub)" <gi...@apache.org> on 2025/04/14 06:14:58 UTC

[PR] HDDS-11703. xcompat audit logs are overwritten [ozone]

peterxcli opened a new pull request, #8279:
URL: https://github.com/apache/ozone/pull/8279

   ## What changes were proposed in this pull request?
   
   Audit logs are saved when shutting down Docker Compose cluster during tests. xcompat starts/stops a cluster for each version being tested. Audit logs from each run overwrite those from previous run.
   
   We should assign a unique prefix or suffix to each run's audit logs to prevent overwrites.
   
   ---
   
   For compact old:
   create a subdir for each `${cluster_version}-${current_version}`
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-11703
   
   ## How was this patch tested?
   
   CI:
   https://github.com/peterxcli/ozone/actions/runs/14436894307
   
   compact old:
   ```
   'result/xcompat/old/xcompat/old/1.1.0-2.1.0/dn-audit-dn.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.1.0-2.1.0/dn-audit-dn.log'
   'result/xcompat/old/xcompat/old/1.1.0-2.1.0/kms-audit.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.1.0-2.1.0/kms-audit.log'
   'result/xcompat/old/xcompat/old/1.1.0-2.1.0/om-audit-om.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.1.0-2.1.0/om-audit-om.log'
   'result/xcompat/old/xcompat/old/1.1.0-2.1.0/om-sys-audit-om.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.1.0-2.1.0/om-sys-audit-om.log'
   'result/xcompat/old/xcompat/old/1.1.0-2.1.0/scm-audit-scm.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.1.0-2.1.0/scm-audit-scm.log'
   
   ...
   
   'result/xcompat/old/xcompat/old/1.2.1-2.1.0/dn-audit-dn.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.2.1-2.1.0/dn-audit-dn.log'
   'result/xcompat/old/xcompat/old/1.2.1-2.1.0/kms-audit.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.2.1-2.1.0/kms-audit.log'
   'result/xcompat/old/xcompat/old/1.2.1-2.1.0/om-audit-om.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.2.1-2.1.0/om-audit-om.log'
   'result/xcompat/old/xcompat/old/1.2.1-2.1.0/om-sys-audit-om.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.2.1-2.1.0/om-sys-audit-om.log'
   'result/xcompat/old/xcompat/old/1.2.1-2.1.0/scm-audit-scm.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.2.1-2.1.0/scm-audit-scm.log'
   
   ...
   
   'result/xcompat/old/xcompat/old/1.3.0-2.1.0/dn-audit-dn.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.3.0-2.1.0/dn-audit-dn.log'
   'result/xcompat/old/xcompat/old/1.3.0-2.1.0/kms-audit.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.3.0-2.1.0/kms-audit.log'
   'result/xcompat/old/xcompat/old/1.3.0-2.1.0/om-audit-om.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.3.0-2.1.0/om-audit-om.log'
   'result/xcompat/old/xcompat/old/1.3.0-2.1.0/om-sys-audit-om.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.3.0-2.1.0/om-sys-audit-om.log'
   'result/xcompat/old/xcompat/old/1.3.0-2.1.0/s3g-audit-s3g.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.3.0-2.1.0/s3g-audit-s3g.log'
   'result/xcompat/old/xcompat/old/1.3.0-2.1.0/scm-audit-scm.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.3.0-2.1.0/scm-audit-scm.log'
   
   ...
   
   'result/xcompat/old/xcompat/old/1.4.0-2.1.0/dn-audit-dn.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.4.0-2.1.0/dn-audit-dn.log'
   'result/xcompat/old/xcompat/old/1.4.0-2.1.0/kms-audit.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.4.0-2.1.0/kms-audit.log'
   'result/xcompat/old/xcompat/old/1.4.0-2.1.0/om-audit-om.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.4.0-2.1.0/om-audit-om.log'
   'result/xcompat/old/xcompat/old/1.4.0-2.1.0/om-sys-audit-om.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.4.0-2.1.0/om-sys-audit-om.log'
   'result/xcompat/old/xcompat/old/1.4.0-2.1.0/s3g-audit-s3g.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.4.0-2.1.0/s3g-audit-s3g.log'
   'result/xcompat/old/xcompat/old/1.4.0-2.1.0/scm-audit-scm.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.4.0-2.1.0/scm-audit-scm.log'
   
   ...
   
   'result/xcompat/old/xcompat/old/1.4.1-2.1.0/dn-audit-dn.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.4.1-2.1.0/dn-audit-dn.log'
   'result/xcompat/old/xcompat/old/1.4.1-2.1.0/kms-audit.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.4.1-2.1.0/kms-audit.log'
   'result/xcompat/old/xcompat/old/1.4.1-2.1.0/om-audit-om.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.4.1-2.1.0/om-audit-om.log'
   'result/xcompat/old/xcompat/old/1.4.1-2.1.0/om-sys-audit-om.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.4.1-2.1.0/om-sys-audit-om.log'
   'result/xcompat/old/xcompat/old/1.4.1-2.1.0/s3g-audit-s3g.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.4.1-2.1.0/s3g-audit-s3g.log'
   'result/xcompat/old/xcompat/old/1.4.1-2.1.0/scm-audit-scm.log' -> '/home/runner/work/ozone/ozone/target/acceptance/xcompat/old/xcompat/old/1.4.1-2.1.0/scm-audit-scm.log'
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-11703. xcompat audit logs are overwritten [ozone]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8279:
URL: https://github.com/apache/ozone/pull/8279#issuecomment-3549966676

   Thank you for your contribution. This PR is being closed due to inactivity. If needed, feel free to reopen it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-11703. xcompat audit logs are overwritten [ozone]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #8279: HDDS-11703. xcompat audit logs are overwritten
URL: https://github.com/apache/ozone/pull/8279


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-11703. xcompat audit logs are overwritten [ozone]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8279:
URL: https://github.com/apache/ozone/pull/8279#issuecomment-3519268315

   This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-11703. xcompat audit logs are overwritten [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #8279:
URL: https://github.com/apache/ozone/pull/8279#discussion_r2044106700


##########
hadoop-ozone/dist/src/main/compose/xcompat/test-old.sh:
##########
@@ -26,5 +26,6 @@ source "${COMPOSE_DIR}/lib.sh"
 # old cluster with clients: same version and current version
 for cluster_version in ${old_versions}; do
   export OZONE_VERSION=${cluster_version}
+  export RESULT_DIR="${COMPOSE_DIR}/result/xcompat/old/${cluster_version}-${current_version}"

Review Comment:
   `xcompat/old` can be omitted, now it is duplicated in the directory structure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org