You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by em...@apache.org on 2020/08/27 00:18:25 UTC
[groovy] branch GROOVY-9703 created (now 8e407c5)
This is an automated email from the ASF dual-hosted git repository.
emilles pushed a change to branch GROOVY-9703
in repository https://gitbox.apache.org/repos/asf/groovy.git.
at 8e407c5 GROOVY-9703: remove superflous System.arraycopy
This branch includes the following new commits:
new 8e407c5 GROOVY-9703: remove superflous System.arraycopy
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[groovy] 01/01: GROOVY-9703: remove superflous System.arraycopy
Posted by em...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
emilles pushed a commit to branch GROOVY-9703
in repository https://gitbox.apache.org/repos/asf/groovy.git
commit 8e407c52c801636a10adb21c0b6a37b53baf1b62
Author: Eric Milles <er...@thomsonreuters.com>
AuthorDate: Wed Aug 26 19:18:06 2020 -0500
GROOVY-9703: remove superflous System.arraycopy
---
.../groovy/runtime/DefaultGroovyMethods.java | 28 +++++++++++++++-------
1 file changed, 20 insertions(+), 8 deletions(-)
diff --git a/src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java b/src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java
index ff84038..2e8261c 100644
--- a/src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java
+++ b/src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java
@@ -11863,20 +11863,32 @@ public class DefaultGroovyMethods extends DefaultGroovyMethodsSupport {
* Reverse the items in an array. If mutate is true, the original array is modified in place and returned.
* Otherwise, a new array containing the reversed items is produced.
*
+ * <pre class="groovyTestCase">
+ * def array = new Object[] {1,2,3}
+ * def yarra = array.reverse(true)
+ * assert array == 3..1
+ * assert yarra == 3..1
+ *
+ * yarra = array.reverse(false)
+ * assert array == 3..1
+ * assert yarra == 1..3
+ * </pre>
+ *
* @param self an array
- * @param mutate true if the array itself should be reversed in place and returned, false if a new array should be created
+ * @param mutate {@code true} if the array itself should be reversed in place, {@code false} if a new array should be created
* @return an array containing the reversed items
+ *
* @since 1.8.1
*/
- @SuppressWarnings("unchecked")
public static <T> T[] reverse(T[] self, boolean mutate) {
- if (!mutate) {
- return (T[]) toList(new ReverseListIterator<>(Arrays.asList(self))).toArray();
+ List<T> list = Arrays.asList(self);
+ if (mutate) {
+ Collections.reverse(list);
+ return self;
}
- List<T> items = Arrays.asList(self);
- Collections.reverse(items);
- System.arraycopy(items.toArray(), 0, self, 0, items.size());
- return self;
+ @SuppressWarnings("unchecked")
+ T[] result = (T[]) toList(new ReverseListIterator<>(list)).toArray();
+ return result;
}
/**