You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Igor Vaynberg <ig...@gmail.com> on 2007/03/19 23:59:26 UTC
VOTE: 1.3: change return type of IDataProvider.size() from int to long
hibernate 3.2 has switched from using an int to a long for returntype of
their count queries. jpa also uses a long. so i figure its time to switch
idataprovider to the long as well so that it maps nicely. since we have
broken 1.3 already, we might as well do it now.
-igor
Re: VOTE: 1.3: change return type of IDataProvider.size() from int to long
Posted by Martijn Dashorst <ma...@gmail.com>.
Ah the wonders of the JPA never amaze me.
Martijn
On 3/21/07, Igor Vaynberg <ig...@gmail.com> wrote:
> well given the above and the fact that idataprovider is mostly about paging
> i dont think this refactor is needed at this time until they fix those two
> ints. now given that this is jpa and the said methods are in an interface we
> can expect that fix to happen in a few months after never. so, i guess
> forget about this whole idea for now.
>
> -igor
>
>
> On 3/21/07, Igor Vaynberg <ig...@gmail.com> wrote:
> >
> > ok i am having a serious wtf moment
> >
> > so count queries in jpa now return a long instead of int
> >
> > but
> >
> > public Query setMaxResults(int maxResult);
> > public Query setFirstResult(int startPosition);
> >
> > so wtf? you can return a huge count but you cant page over the query?
> >
> > -igor
> >
> >
> > On 3/21/07, Igor Vaynberg <ig...@gmail.com> wrote:
> > >
> > > so i think this very simple refactor gout a bit out of control. see
> > > attached patches. thoughts?
> > >
> > > -igor
> > >
> > >
> > > On 3/19/07, Igor Vaynberg < igor.vaynberg@gmail.com> wrote:
> > > >
> > > > hibernate 3.2 has switched from using an int to a long for returntype
> > > > of their count queries. jpa also uses a long. so i figure its time to
> > > > switch idataprovider to the long as well so that it maps nicely. since
> > > > we have broken 1.3 already, we might as well do it now.
> > > >
> > > > -igor
> > > >
> > >
> > >
> > >
> >
>
--
Learn Wicket at ApacheCon Europe: http://apachecon.com
Join the wicket community at irc.freenode.net: ##wicket
Wicket 1.2.5 will keep your server alive. Download Wicket now!
http://wicketframework.org
Re: VOTE: 1.3: change return type of IDataProvider.size() from int to long
Posted by Igor Vaynberg <ig...@gmail.com>.
well given the above and the fact that idataprovider is mostly about paging
i dont think this refactor is needed at this time until they fix those two
ints. now given that this is jpa and the said methods are in an interface we
can expect that fix to happen in a few months after never. so, i guess
forget about this whole idea for now.
-igor
On 3/21/07, Igor Vaynberg <ig...@gmail.com> wrote:
>
> ok i am having a serious wtf moment
>
> so count queries in jpa now return a long instead of int
>
> but
>
> public Query setMaxResults(int maxResult);
> public Query setFirstResult(int startPosition);
>
> so wtf? you can return a huge count but you cant page over the query?
>
> -igor
>
>
> On 3/21/07, Igor Vaynberg <ig...@gmail.com> wrote:
> >
> > so i think this very simple refactor gout a bit out of control. see
> > attached patches. thoughts?
> >
> > -igor
> >
> >
> > On 3/19/07, Igor Vaynberg < igor.vaynberg@gmail.com> wrote:
> > >
> > > hibernate 3.2 has switched from using an int to a long for returntype
> > > of their count queries. jpa also uses a long. so i figure its time to
> > > switch idataprovider to the long as well so that it maps nicely. since
> > > we have broken 1.3 already, we might as well do it now.
> > >
> > > -igor
> > >
> >
> >
> >
>
Re: VOTE: 1.3: change return type of IDataProvider.size() from int to long
Posted by Igor Vaynberg <ig...@gmail.com>.
ok i am having a serious wtf moment
so count queries in jpa now return a long instead of int
but
public Query setMaxResults(int maxResult);
public Query setFirstResult(int startPosition);
so wtf? you can return a huge count but you cant page over the query?
-igor
On 3/21/07, Igor Vaynberg <ig...@gmail.com> wrote:
>
> so i think this very simple refactor gout a bit out of control. see
> attached patches. thoughts?
>
> -igor
>
>
> On 3/19/07, Igor Vaynberg < igor.vaynberg@gmail.com> wrote:
> >
> > hibernate 3.2 has switched from using an int to a long for returntype of
> > their count queries. jpa also uses a long. so i figure its time to
> > switch idataprovider to the long as well so that it maps nicely. since
> > we have broken 1.3 already, we might as well do it now.
> >
> > -igor
> >
>
>
>
Re: VOTE: 1.3: change return type of IDataProvider.size() from int to long
Posted by Igor Vaynberg <ig...@gmail.com>.
so i think this very simple refactor gout a bit out of control. see attached
patches. thoughts?
-igor
On 3/19/07, Igor Vaynberg <ig...@gmail.com> wrote:
>
> hibernate 3.2 has switched from using an int to a long for returntype of
> their count queries. jpa also uses a long. so i figure its time to switch
> idataprovider to the long as well so that it maps nicely. since we have
> broken 1.3 already, we might as well do it now.
>
> -igor
>
Re: VOTE: 1.3: change return type of IDataProvider.size() from int to long
Posted by Gwyn Evans <gw...@gmail.com>.
+1
On 19/03/07, Igor Vaynberg <ig...@gmail.com> wrote:
> hibernate 3.2 has switched from using an int to a long for returntype of
> their count queries. jpa also uses a long. so i figure its time to switch
> idataprovider to the long as well so that it maps nicely. since we have
> broken 1.3 already, we might as well do it now.
>
> -igor
>
--
Download Wicket 1.2.5 now! - http://wicketframework.org
Re: VOTE: 1.3: change return type of IDataProvider.size() from int to long
Posted by Frank Bille <fr...@gmail.com>.
+1
Frank
On 3/19/07, Igor Vaynberg <ig...@gmail.com> wrote:
>
> hibernate 3.2 has switched from using an int to a long for returntype of
> their count queries. jpa also uses a long. so i figure its time to switch
> idataprovider to the long as well so that it maps nicely. since we have
> broken 1.3 already, we might as well do it now.
>
> -igor
>
Re: VOTE: 1.3: change return type of IDataProvider.size() from int to long
Posted by Matej Knopp <ma...@gmail.com>.
+1
I'm going with the crowd
On 3/20/07, Eelco Hillenius <ee...@gmail.com> wrote:
> +1
>
> Eelco
>
>
> On 3/19/07, Igor Vaynberg <ig...@gmail.com> wrote:
> > hibernate 3.2 has switched from using an int to a long for returntype of
> > their count queries. jpa also uses a long. so i figure its time to switch
> > idataprovider to the long as well so that it maps nicely. since we have
> > broken 1.3 already, we might as well do it now.
> >
> > -igor
> >
>
Re: VOTE: 1.3: change return type of IDataProvider.size() from int to long
Posted by Eelco Hillenius <ee...@gmail.com>.
+1
Eelco
On 3/19/07, Igor Vaynberg <ig...@gmail.com> wrote:
> hibernate 3.2 has switched from using an int to a long for returntype of
> their count queries. jpa also uses a long. so i figure its time to switch
> idataprovider to the long as well so that it maps nicely. since we have
> broken 1.3 already, we might as well do it now.
>
> -igor
>
Re: VOTE: 1.3: change return type of IDataProvider.size() from int to long
Posted by Johan Compagner <jc...@gmail.com>.
+1
On 3/19/07, Igor Vaynberg <ig...@gmail.com> wrote:
>
> hibernate 3.2 has switched from using an int to a long for returntype of
> their count queries. jpa also uses a long. so i figure its time to switch
> idataprovider to the long as well so that it maps nicely. since we have
> broken 1.3 already, we might as well do it now.
>
> -igor
>
Re: VOTE: 1.3: change return type of IDataProvider.size() from int to long
Posted by Nick Heudecker <nh...@gmail.com>.
+1, non-binding.
On 3/19/07, Igor Vaynberg <ig...@gmail.com> wrote:
>
> +1
>
> -igor
>
> On 3/19/07, Igor Vaynberg <ig...@gmail.com> wrote:
> >
> > hibernate 3.2 has switched from using an int to a long for returntype of
> > their count queries. jpa also uses a long. so i figure its time to
> switch
> > idataprovider to the long as well so that it maps nicely. since we have
> > broken 1.3 already, we might as well do it now.
> >
> > -igor
> >
>
--
Nick Heudecker
Professional Wicket Training & Consulting
http://www.systemmobile.com
Eventful - Intelligent Event Management
http://www.eventfulhq.com
Re: VOTE: 1.3: change return type of IDataProvider.size() from int to long
Posted by Igor Vaynberg <ig...@gmail.com>.
+1
-igor
On 3/19/07, Igor Vaynberg <ig...@gmail.com> wrote:
>
> hibernate 3.2 has switched from using an int to a long for returntype of
> their count queries. jpa also uses a long. so i figure its time to switch
> idataprovider to the long as well so that it maps nicely. since we have
> broken 1.3 already, we might as well do it now.
>
> -igor
>