You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2013/02/27 15:07:04 UTC
git commit: WICKET-5058
org.apache.wicket.markup.html.link.PopupSettings.java problem (version 6.5.0)
target problem
Updated Branches:
refs/heads/master 1a029c001 -> d42e91d6a
WICKET-5058 org.apache.wicket.markup.html.link.PopupSettings.java problem (version 6.5.0) target problem
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/d42e91d6
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/d42e91d6
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/d42e91d6
Branch: refs/heads/master
Commit: d42e91d6aa2abf43bfad19c5d19b658a05d57859
Parents: 1a029c0
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Wed Feb 27 16:06:32 2013 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Wed Feb 27 16:06:32 2013 +0200
----------------------------------------------------------------------
.../wicket/markup/html/link/PopupSettings.java | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/d42e91d6/wicket-core/src/main/java/org/apache/wicket/markup/html/link/PopupSettings.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/PopupSettings.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/PopupSettings.java
index 418d0e5..b446034 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/PopupSettings.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/PopupSettings.java
@@ -217,9 +217,14 @@ public class PopupSettings implements IClusterable
}
/**
- * Sets the target of the link. The default implementation simply refers to the href element,
- * but clients may want to override this (e.g. when the HTML element is not an anchor) by
+ * Sets the target of the link. The default implementation simply refers to the href attribute of
+ * the anchor element, but clients may want to override this (e.g. when the HTML element is not an anchor) by
* setting the target explicitly.
+ *
+ * <strong>Note</strong>: if the target is an url (relative or absolute) then it should be wrapped in
+ * quotes, for example: <code>setTarget("'some/url'")</code>. If the url is delivered with an HTML attribute then
+ * it should be without quotes, for example: <code>setTarget("this.dataset['popup-url']")</code> with markup like:
+ * <pre><code><a data-popup-url="some/url">Link</a></code></pre>.
*
* @param target
* the target of the link