You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/04/29 00:16:44 UTC
[kudu-CR] [security] handle BIO new
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19819
Change subject: [security] handle BIO_new
......................................................................
[security] handle BIO_new
This patch adds verification of the result returned by the OpenSSL's
BIO_new() function. It's a rare case when BIO_new() returns nullptr,
but if it does so, let's handle the results as documented.
Change-Id: I7a18034fde219c181f13d2d4c1ee9acb7e8e1a46
---
M src/kudu/security/cert.cc
M src/kudu/security/cert.h
M src/kudu/security/crypto.cc
M src/kudu/security/tls_handshake.cc
M src/kudu/util/openssl_util.h
M src/kudu/util/openssl_util_bio.h
6 files changed, 15 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/19819/1
--
To view, visit http://gerrit.cloudera.org:8080/19819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a18034fde219c181f13d2d4c1ee9acb7e8e1a46
Gerrit-Change-Number: 19819
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [security] handle BIO new
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19819 )
Change subject: [security] handle BIO_new
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a18034fde219c181f13d2d4c1ee9acb7e8e1a46
Gerrit-Change-Number: 19819
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sat, 29 Apr 2023 16:03:37 +0000
Gerrit-HasComments: No
[kudu-CR] [security] handle BIO new
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19819 )
Change subject: [security] handle BIO_new
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a18034fde219c181f13d2d4c1ee9acb7e8e1a46
Gerrit-Change-Number: 19819
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sun, 30 Apr 2023 23:34:08 +0000
Gerrit-HasComments: No
[kudu-CR] [security] handle BIO new
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19819 )
Change subject: [security] handle BIO_new
......................................................................
[security] handle BIO_new
This patch adds verification of the result returned by the OpenSSL's
BIO_new() function. It's a rare case when BIO_new() returns nullptr,
but if it does so, let's handle the results as documented.
Change-Id: I7a18034fde219c181f13d2d4c1ee9acb7e8e1a46
Reviewed-on: http://gerrit.cloudera.org:8080/19819
Tested-by: Kudu Jenkins
Reviewed-by: Yuqi Du <sh...@gmail.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/security/cert.cc
M src/kudu/security/cert.h
M src/kudu/security/crypto.cc
M src/kudu/security/tls_handshake.cc
M src/kudu/util/openssl_util.h
M src/kudu/util/openssl_util_bio.h
6 files changed, 15 insertions(+), 13 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yuqi Du: Looks good to me, but someone else must approve
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a18034fde219c181f13d2d4c1ee9acb7e8e1a46
Gerrit-Change-Number: 19819
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>